Patchwork make EPoX EP-8NPA7I board enable actually work

login
register
about
Submitter Jonathan A. Kollasch
Date 2010-10-16 15:43:08
Message ID <20101016154307.GK20411@tarantulon.kollasch.net>
Download mbox | patch
Permalink /patch/2125/
State Superseded
Headers show

Comments

Jonathan A. Kollasch - 2010-10-16 15:43:08
The OEM BIOS on the EPoX EP-8PA7I clears byte 0x92 in the LPC bridge
configuration space.  Do the same for all CK804 chips, assuming this to
be some sort of chipset-generic write-enable.

Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
---
Idwer Vollering - 2011-01-29 02:52:32
2010/10/16 Jonathan A. Kollasch <jakllsch@kollasch.net>

> The OEM BIOS on the EPoX EP-8PA7I clears byte 0x92 in the LPC bridge
> configuration space.  Do the same for all CK804 chips, assuming this to
> be some sort of chipset-generic write-enable.
>

Chipset-set generic, does the ASUS K8N-DRE handle this write enable as well
?


> Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
>

Acked-by: Idwer Vollering <vidwer@gmail.com>


> ---
>
> _______________________________________________
> flashrom mailing list
> flashrom@flashrom.org
> http://www.flashrom.org/mailman/listinfo/flashrom
>
Joshua Roys - 2011-02-27 04:17:13
On 01/28/2011 09:52 PM, Idwer Vollering wrote:
> 2010/10/16 Jonathan A. Kollasch <jakllsch@kollasch.net
> <mailto:jakllsch@kollasch.net>>
>
>     The OEM BIOS on the EPoX EP-8PA7I clears byte 0x92 in the LPC bridge
>     configuration space.  Do the same for all CK804 chips, assuming this to
>     be some sort of chipset-generic write-enable.
>
>

Hello,

The ASUS P5N-E SLI (the recent FAILED post), as well as a few other 
boards I've looked at, clear this byte... it would be good to have 
committed.  If it doesn't apply to all ck804, then perhaps we can make a 
wrapper function that clears 0x92 and then calls enable_flash_ck804?

Josh

Patch

Index: chipset_enable.c
===================================================================
--- chipset_enable.c	(revision 1213)
+++ chipset_enable.c	(working copy)
@@ -778,6 +778,11 @@ 
 {
 	uint8_t old, new;
 
+	pci_write_byte(dev, 0x92, 0x00);
+	if (pci_read_byte(dev, 0x92) != 0x00) {
+		msg_pinfo("tried to set 0x%x to 0x%x on %s failed (WARNING ONLY)\n", 0x92, 0x00, name);
+	}
+
 	old = pci_read_byte(dev, 0x88);
 	new = old | 0xc0;
 	if (new != old) {