Patchwork Various PIRQ/MPTABLE/ACPI Kconfig fixes

login
register
about
Submitter Uwe Hermann
Date 2010-10-31 19:01:12
Message ID <20101031190112.GF3256@greenwood>
Download mbox | patch
Permalink /patch/2217/
State Accepted
Headers show

Comments

Uwe Hermann - 2010-10-31 19:01:12
See patch.


Uwe.

Patch

Various PIRQ/MPTABLE/ACPI Kconfig fixes.

 - Use HAVE_ACPI_TABLES, HAVE_MP_TABLE, and HAVE_PIRQ_TABLE (instead of
   GENERATE_*) in the board's Kconfig file, as all other boards do.

 - Add missing HAVE_ACPI_TABLES/HAVE_MP_TABLE/HAVE_PIRQ_TABLE to boards
   which have the respective files. The only exception: EPIA-M700 doesn't
   select ACPI, as it doesn't have dsdt.asl. Added a comment that the user
   is supposed to run the 'get_dsdt' script and edit Kconfig afterwards.

 - Fix minor warning/error in src/mainboard/msi/ms9652_fam10/acpi_tables.c,
   now that the file is actually used.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Index: src/mainboard/asrock/939a785gmh/Kconfig
===================================================================
--- src/mainboard/asrock/939a785gmh/Kconfig	(Revision 6005)
+++ src/mainboard/asrock/939a785gmh/Kconfig	(Arbeitskopie)
@@ -11,9 +11,9 @@ 
 	select SOUTHBRIDGE_AMD_SB700
 	select SUPERIO_WINBOND_W83627DHG
 	select BOARD_HAS_FADT
-	select GENERATE_ACPI_TABLES
-	select GENERATE_MP_TABLE
-	select GENERATE_PIRQ_TABLE
+	select HAVE_ACPI_TABLES
+	select HAVE_MP_TABLE
+	select HAVE_PIRQ_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select HAVE_OPTION_TABLE
 	select HAVE_BUS_CONFIG
Index: src/mainboard/getac/p470/Kconfig
===================================================================
--- src/mainboard/getac/p470/Kconfig	(Revision 6005)
+++ src/mainboard/getac/p470/Kconfig	(Arbeitskopie)
@@ -29,9 +29,9 @@ 
 	select SUPERIO_SMSC_FDC37N972
 	select SUPERIO_SMSC_SIO10N268
 	select BOARD_HAS_FADT
-	select GENERATE_ACPI_TABLES
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_ACPI_TABLES
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_SLIC
Index: src/mainboard/kontron/986lcd-m/Kconfig
===================================================================
--- src/mainboard/kontron/986lcd-m/Kconfig	(Revision 6005)
+++ src/mainboard/kontron/986lcd-m/Kconfig	(Arbeitskopie)
@@ -9,9 +9,9 @@ 
 	select SOUTHBRIDGE_INTEL_I82801GX
 	select SUPERIO_WINBOND_W83627THG
 	select BOARD_HAS_FADT
-	select GENERATE_ACPI_TABLES
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_ACPI_TABLES
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_RESUME
 	select MMCONF_SUPPORT
Index: src/mainboard/gigabyte/ma78gm/Kconfig
===================================================================
--- src/mainboard/gigabyte/ma78gm/Kconfig	(Revision 6005)
+++ src/mainboard/gigabyte/ma78gm/Kconfig	(Arbeitskopie)
@@ -13,8 +13,8 @@ 
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
@@ -22,7 +22,7 @@ 
 	select LIFT_BSP_APIC_ID
 	select SERIAL_CPU_INIT
 	select AMDMCT
-	select GENERATE_ACPI_TABLES
+	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
 	select ENABLE_APIC_EXT_ID
 	select TINY_BOOTBLOCK
Index: src/mainboard/gigabyte/ga_2761gxdk/Kconfig
===================================================================
--- src/mainboard/gigabyte/ga_2761gxdk/Kconfig	(Revision 6005)
+++ src/mainboard/gigabyte/ga_2761gxdk/Kconfig	(Arbeitskopie)
@@ -12,6 +12,7 @@ 
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
 	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
 	select LIFT_BSP_APIC_ID
Index: src/mainboard/gigabyte/ma785gmt/Kconfig
===================================================================
--- src/mainboard/gigabyte/ma785gmt/Kconfig	(Revision 6005)
+++ src/mainboard/gigabyte/ma785gmt/Kconfig	(Arbeitskopie)
@@ -13,8 +13,8 @@ 
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
@@ -22,7 +22,7 @@ 
 	select LIFT_BSP_APIC_ID
 	select SERIAL_CPU_INIT
 	select AMDMCT
-	select GENERATE_ACPI_TABLES
+	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
 	select ENABLE_APIC_EXT_ID
 	select TINY_BOOTBLOCK
Index: src/mainboard/amd/mahogany/Kconfig
===================================================================
--- src/mainboard/amd/mahogany/Kconfig	(Revision 6005)
+++ src/mainboard/amd/mahogany/Kconfig	(Arbeitskopie)
@@ -11,9 +11,9 @@ 
 	select SOUTHBRIDGE_AMD_SB700
 	select SUPERIO_ITE_IT8718F
 	select BOARD_HAS_FADT
-	select GENERATE_ACPI_TABLES
-	select GENERATE_MP_TABLE
-	select GENERATE_PIRQ_TABLE
+	select HAVE_ACPI_TABLES
+	select HAVE_MP_TABLE
+	select HAVE_PIRQ_TABLE
 	select HAVE_OPTION_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select HAVE_BUS_CONFIG
Index: src/mainboard/amd/dbm690t/Kconfig
===================================================================
--- src/mainboard/amd/dbm690t/Kconfig	(Revision 6005)
+++ src/mainboard/amd/dbm690t/Kconfig	(Arbeitskopie)
@@ -10,9 +10,9 @@ 
 	select SOUTHBRIDGE_AMD_SB600
 	select SUPERIO_ITE_IT8712F
 	select BOARD_HAS_FADT
-	select GENERATE_ACPI_TABLES
-	select GENERATE_MP_TABLE
-	select GENERATE_PIRQ_TABLE
+	select HAVE_ACPI_TABLES
+	select HAVE_MP_TABLE
+	select HAVE_PIRQ_TABLE
 	select HAVE_OPTION_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select HAVE_BUS_CONFIG
Index: src/mainboard/amd/mahogany_fam10/Kconfig
===================================================================
--- src/mainboard/amd/mahogany_fam10/Kconfig	(Revision 6005)
+++ src/mainboard/amd/mahogany_fam10/Kconfig	(Arbeitskopie)
@@ -13,8 +13,8 @@ 
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
@@ -22,7 +22,7 @@ 
 	select LIFT_BSP_APIC_ID
 	select SERIAL_CPU_INIT
 	select AMDMCT
-	select GENERATE_ACPI_TABLES
+	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
 	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
Index: src/mainboard/amd/tilapia_fam10/Kconfig
===================================================================
--- src/mainboard/amd/tilapia_fam10/Kconfig	(Revision 6005)
+++ src/mainboard/amd/tilapia_fam10/Kconfig	(Arbeitskopie)
@@ -13,8 +13,8 @@ 
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
@@ -22,7 +22,7 @@ 
 	select LIFT_BSP_APIC_ID
 	select SERIAL_CPU_INIT
 	select AMDMCT
-	select GENERATE_ACPI_TABLES
+	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
 	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
Index: src/mainboard/iei/juki-511p/Kconfig
===================================================================
--- src/mainboard/iei/juki-511p/Kconfig	(Revision 6005)
+++ src/mainboard/iei/juki-511p/Kconfig	(Arbeitskopie)
@@ -27,6 +27,7 @@ 
 	select SUPERIO_WINBOND_W83977F
 	select ROMCC
 	select PIRQ_ROUTE
+	select HAVE_PIRQ_TABLE
 	select HAVE_OPTION_TABLE
 	select BOARD_ROMSIZE_KB_256
 
Index: src/mainboard/iei/kino-780am2-fam10/Kconfig
===================================================================
--- src/mainboard/iei/kino-780am2-fam10/Kconfig	(Revision 6005)
+++ src/mainboard/iei/kino-780am2-fam10/Kconfig	(Arbeitskopie)
@@ -13,8 +13,8 @@ 
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
@@ -22,7 +22,7 @@ 
 	select LIFT_BSP_APIC_ID
 	select SERIAL_CPU_INIT
 	select AMDMCT
-	select GENERATE_ACPI_TABLES
+	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
 	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
Index: src/mainboard/via/epia-m700/Kconfig
===================================================================
--- src/mainboard/via/epia-m700/Kconfig	(Revision 6005)
+++ src/mainboard/via/epia-m700/Kconfig	(Arbeitskopie)
@@ -7,6 +7,10 @@ 
 	select NORTHBRIDGE_VIA_VX800
 	select SUPERIO_WINBOND_W83697HF
 	select BOARD_HAS_FADT
+	select HAVE_PIRQ_TABLE
+	# Note: For ACPI, you need to use the 'get_dsdt' script and uncomment
+	# the "select HAVE_ACPI_TABLES" line below.
+	# select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
 	select BOARD_ROMSIZE_KB_512
 	select RAMINIT_SYSINFO
Index: src/mainboard/ibase/mb899/Kconfig
===================================================================
--- src/mainboard/ibase/mb899/Kconfig	(Revision 6005)
+++ src/mainboard/ibase/mb899/Kconfig	(Arbeitskopie)
@@ -9,9 +9,9 @@ 
 	select SOUTHBRIDGE_INTEL_I82801GX
 	select SUPERIO_WINBOND_W83627EHG
 	select BOARD_HAS_FADT
-	select GENERATE_ACPI_TABLES
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_ACPI_TABLES
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_RESUME
 	select MMCONF_SUPPORT
Index: src/mainboard/msi/ms9652_fam10/Kconfig
===================================================================
--- src/mainboard/msi/ms9652_fam10/Kconfig	(Revision 6005)
+++ src/mainboard/msi/ms9652_fam10/Kconfig	(Arbeitskopie)
@@ -14,6 +14,7 @@ 
 	select HAVE_BUS_CONFIG
 	select HAVE_PIRQ_TABLE
 	select HAVE_MP_TABLE
+	select HAVE_ACPI_TABLES
 	select CACHE_AS_RAM
 	select HAVE_OPTION_TABLE
 	select HAVE_HARD_RESET
Index: src/mainboard/msi/ms9652_fam10/acpi_tables.c
===================================================================
--- src/mainboard/msi/ms9652_fam10/acpi_tables.c	(Revision 6005)
+++ src/mainboard/msi/ms9652_fam10/acpi_tables.c	(Arbeitskopie)
@@ -151,7 +151,7 @@ 
 	current += dsdt->length;
 	memcpy(dsdt, &AmlCode, dsdt->length);
 	dsdt->checksum = 0;	/* Don't trust iasl to get this right. */
-	dsdt->checksum = acpi_checksum(dsdt, dsdt->length);
+	dsdt->checksum = acpi_checksum((u8 *)dsdt, dsdt->length);
 	printk(BIOS_DEBUG, "ACPI:     * DSDT @ %p Length %x\n", dsdt,
 		     dsdt->length);
 	printk(BIOS_DEBUG, "ACPI:     * FADT\n");
Index: src/mainboard/jetway/pa78vm5/Kconfig
===================================================================
--- src/mainboard/jetway/pa78vm5/Kconfig	(Revision 6005)
+++ src/mainboard/jetway/pa78vm5/Kconfig	(Arbeitskopie)
@@ -13,8 +13,8 @@ 
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select HAVE_MAINBOARD_RESOURCES
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
@@ -22,7 +22,7 @@ 
 	select LIFT_BSP_APIC_ID
 	select SERIAL_CPU_INIT
 	select AMDMCT
-	select GENERATE_ACPI_TABLES
+	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
 	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
Index: src/mainboard/asus/m4a785-m/Kconfig
===================================================================
--- src/mainboard/asus/m4a785-m/Kconfig	(Revision 6005)
+++ src/mainboard/asus/m4a785-m/Kconfig	(Arbeitskopie)
@@ -13,15 +13,15 @@ 
 	select BOARD_HAS_FADT
 	select HAVE_BUS_CONFIG
 	select HAVE_OPTION_TABLE
-	select GENERATE_PIRQ_TABLE
-	select GENERATE_MP_TABLE
+	select HAVE_PIRQ_TABLE
+	select HAVE_MP_TABLE
 	select CACHE_AS_RAM
 	select HAVE_HARD_RESET
 	select SB_HT_CHAIN_UNITID_OFFSET_ONLY
 	select LIFT_BSP_APIC_ID
 	select SERIAL_CPU_INIT
 	select AMDMCT
-	select GENERATE_ACPI_TABLES
+	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
 	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID