Patchwork Add amd/dbm690t comments to devicetree.cb

login
register
about
Submitter Carl-Daniel Hailfinger
Date 2009-08-28 13:53:00
Message ID <4A97E13C.3090403@gmx.net>
Download mbox | patch
Permalink /patch/222/
State Accepted
Headers show

Comments

Carl-Daniel Hailfinger - 2009-08-28 13:53:00
r4534 introduced devicetree.cb in every mainboard directory, but didn't
copy any comment lines before the start of the device tree. Sometimes,
these comments refer to the device tree and need to be present on
devicetree.cb if Config.lb is ever dropped.
Fix the amd/dbm690t target. I went through the remaining 110 boards by
hand and the following files are in need of attention:
amd/pistachio/Config.lb missing comment
msi/ms6178/Config.lb change
via/epia-m700/Config.lb change
lippert/spacerunner-lx/Config.lb missing setting
lippert/roadrunner-lx/Config.lb misssing setting
technexion/tim8690/Config.lb misssing comment
gigabyte/m57sli/Config.lb change

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
ron minnich - 2009-08-28 14:15:59
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Uwe Hermann - 2009-08-28 14:29:45
On Fri, Aug 28, 2009 at 03:53:00PM +0200, Carl-Daniel Hailfinger wrote:
> r4534 introduced devicetree.cb in every mainboard directory, but didn't
> copy any comment lines before the start of the device tree. Sometimes,
> these comments refer to the device tree and need to be present on
> devicetree.cb if Config.lb is ever dropped.

Makes sense.


> Fix the amd/dbm690t target. I went through the remaining 110 boards by
> hand and the following files are in need of attention:
> amd/pistachio/Config.lb missing comment

> msi/ms6178/Config.lb change

I have a patch for this in my queue, will send later.


> via/epia-m700/Config.lb change
> lippert/spacerunner-lx/Config.lb missing setting
> lippert/roadrunner-lx/Config.lb misssing setting
> technexion/tim8690/Config.lb misssing comment
> gigabyte/m57sli/Config.lb change
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>

 
Uwe.
Carl-Daniel Hailfinger - 2009-08-28 19:05:44
On 28.08.2009 16:29, Uwe Hermann wrote:
> On Fri, Aug 28, 2009 at 03:53:00PM +0200, Carl-Daniel Hailfinger wrote:
>   
>> msi/ms6178/Config.lb change
>>     
>
> I have a patch for this in my queue, will send later.
>   

Great.


>> via/epia-m700/Config.lb change
>> lippert/spacerunner-lx/Config.lb missing setting
>> lippert/roadrunner-lx/Config.lb misssing setting
>> gigabyte/m57sli/Config.lb change
>>     

The boards above need some love.

>> amd/pistachio/Config.lb missing comment
>> technexion/tim8690/Config.lb misssing comment
>>     

I'll send a followup patch for these two.

>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>>     
>
> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
>   

Thanks, r4614.

Regards,
Carl-Daniel

Patch

Index: LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/devicetree.cb
===================================================================
--- LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/devicetree.cb	(Revision 4605)
+++ LinuxBIOSv2-asus_m2a-vm/src/mainboard/amd/dbm690t/devicetree.cb	(Arbeitskopie)
@@ -1,3 +1,14 @@ 
+#Define gpp_configuration,	A=0, B=1, C=2, D=3, E=4(default)
+#Define vga_rom_address = 0xfff0000
+#Define port_enable, (bit map): GFX(2,3), GPP(4,5,6,7)
+#Define gfx_dev2_dev3, 0: a link will never be established on Dev2 or Dev3,
+#			1: the system allows a PCIE link to be established on Dev2 or Dev3.
+#Define gfx_dual_slot, 0: single slot, 1: dual slot
+#Define gfx_lane_reversal, 0: disable lane reversal, 1: enable
+#Define gfx_tmds, 0: didn't support TMDS, 1: support
+#Define gfx_compliance, 0: didn't support compliance, 1: support
+#Define gfx_reconfiguration, 0: short reconfiguration, 1(default): long reconfiguration
+#Define gfx_link_width, 0: x16, 1: x1, 2: x2, 3: x4, 4: x8, 5: x12 (not supported), 6: x16
 chip northbridge/amd/amdk8/root_complex
 	device apic_cluster 0 on
 		chip cpu/amd/socket_S1G1