| Submitter | Nils |
|---|---|
| Date | 2010-11-02 21:33:22 |
| Message ID | <201011022233.22980.njacobs8@hetnet.nl> |
| Download | mbox | patch |
| Permalink | /patch/2229/ |
| State | Accepted |
| Headers | show |
Comments
On Tue, Nov 02, 2010 at 10:33:22PM +0100, Nils wrote: > This patch defines the unused DIMM1 to 0xFF to make it obvious it is a bogus > value. > > Signed-off-by: Nils Jacobs <njacobs8@hetnet.nl> Thanks, r6022. I added some comments too to make it clearer why it's 0xFF, I hope the comments are correct and make sense. Uwe.
Op vrijdag 5 november 2010 01:20:03 schreef u: > On Tue, Nov 02, 2010 at 10:33:22PM +0100, Nils wrote: > > This patch defines the unused DIMM1 to 0xFF to make it obvious it is a > > bogus value. > > > > Signed-off-by: Nils Jacobs <njacobs8@hetnet.nl> > > Thanks, r6022. I added some comments too to make it clearer why it's > 0xFF, I hope the comments are correct and make sense. > > > Uwe. Thanks for the review and commit. Your comments look great. Nils.
Patch
Index: src/mainboard/wyse/s50/romstage.c =================================================================== --- src/mainboard/wyse/s50/romstage.c (revision 6011) +++ src/mainboard/wyse/s50/romstage.c (working copy) @@ -35,7 +35,7 @@ #include "southbridge/amd/cs5536/cs5536_early_setup.c" #define DIMM0 0xA0 -#define DIMM1 0xA2 +#define DIMM1 0xFF static inline int spd_read_byte(unsigned int device, unsigned int address) { Index: src/mainboard/amd/rumba/romstage.c =================================================================== --- src/mainboard/amd/rumba/romstage.c (revision 6011) +++ src/mainboard/amd/rumba/romstage.c (working copy) @@ -16,7 +16,7 @@ #include "southbridge/amd/cs5536/cs5536_early_setup.c" #define DIMM0 0xA0 -#define DIMM1 0xA2 +#define DIMM1 0xFF static inline int spd_read_byte(unsigned device, unsigned address) { Index: src/mainboard/lippert/frontrunner/romstage.c =================================================================== --- src/mainboard/lippert/frontrunner/romstage.c (revision 6011) +++ src/mainboard/lippert/frontrunner/romstage.c (working copy) @@ -18,7 +18,7 @@ #include "southbridge/amd/cs5535/cs5535_early_setup.c" #define DIMM0 0xA0 -#define DIMM1 0xA2 +#define DIMM1 0xFF static const unsigned char spdbytes[] = { /* 4x Qimonda HYB25DC512160CF-6 */ 0xFF, 0xFF, /* only values used by raminit.c are set */
This patch defines the unused DIMM1 to 0xFF to make it obvious it is a bogus value. Signed-off-by: Nils Jacobs <njacobs8@hetnet.nl> This was requested by Myles. This is Abuild and boot tested. Thanks, Nils.