Patchwork Gigabyte M57SLI - some troubles with recent corebootversion

login
register
about
Submitter Scott
Date 2010-11-04 18:28:39
Message ID <5D2EC50731B44DBE9055F98F97C7F6CA@m3a78>
Download mbox | patch
Permalink /patch/2250/
State New
Headers show

Comments

Scott - 2010-11-04 18:28:39
-----Original Message-----
From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Harald Gutmann
Sent: Thursday, November 04, 2010 12:46 PM
To: coreboot@coreboot.org
Subject: [coreboot] Gigabyte M57SLI - some troubles with recent corebootversion

]Hello readers,
]
]after some while I tried to use coreboot again on my well supported Gigabyte 
]M57SLI and I was really happy, that the first built image booted the machine.
]
]Last time I tried this, I stumbled across an error with the RAM, and had no 
]time to investigate this further.
]
]With the recent version of coreboot (r6013) I get some errors which I'd like 
]to fix. I don't know if some changes to coreboot happened in the meanwhile or, 
]if the kernel got changed so that this errors appear. My kernel version 
]running is from debian sid with the version number 2.6.32-27 for AMD64.
]
]The problems I get are the following:
][    0.000000] mtrr: your BIOS has set up an incorrect mask, fixing it up.

It looks like your project uses an AMD family 0Fh processor. Windows 7 
checked build makes a blue screen due to the variable MTRR mask. It defaults
to 36, which is incorrect for his processor. 40 is needed:



]Kind regards,
]Harald Gutmann
Harald Gutmann - 2010-11-04 19:46:44
Hello Scott,

thank you for your fast reply!

Your provided solution works fine to fix the MTRR problem on my board!
Just FYI, my CPU is the following:
model name      : AMD Athlon(tm) 64 X2 Dual Core Processor 6000+

I'm just thinking if your suggested place for changing the KConfig is the right 
one, as the other boards did that config in the socket directory.
And I guess that the model_fxx directory is used in several sockets. Therefor 
I think it would be better to add that config value in "cpu/amd/socket_AM2" so 
that other sockets don't get affected with this change.


Kind regards,
Harald



On Thursday 04 November 2010 19:28:39 Scott Duplichan wrote:
> -----Original Message-----
> From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org]
> On Behalf Of Harald Gutmann Sent: Thursday, November 04, 2010 12:46 PM
> To: coreboot@coreboot.org
> Subject: [coreboot] Gigabyte M57SLI - some troubles with recent
> corebootversion
> 
> ]Hello readers,
> ]
> ]after some while I tried to use coreboot again on my well supported
> Gigabyte ]M57SLI and I was really happy, that the first built image booted
> the machine. ]
> ]Last time I tried this, I stumbled across an error with the RAM, and had
> no ]time to investigate this further.
> ]
> ]With the recent version of coreboot (r6013) I get some errors which I'd
> like ]to fix. I don't know if some changes to coreboot happened in the
> meanwhile or, ]if the kernel got changed so that this errors appear. My
> kernel version ]running is from debian sid with the version number
> 2.6.32-27 for AMD64. ]
> ]The problems I get are the following:
> ][    0.000000] mtrr: your BIOS has set up an incorrect mask, fixing it up.
> 
> It looks like your project uses an AMD family 0Fh processor. Windows 7
> checked build makes a blue screen due to the variable MTRR mask. It
> defaults to 36, which is incorrect for his processor. 40 is needed:
> 
> Index: src/cpu/amd/model_fxx/Kconfig
> ===================================================================
> --- src/cpu/amd/model_fxx/Kconfig	(revision 6017)
> +++ src/cpu/amd/model_fxx/Kconfig	(working copy)
> @@ -4,6 +4,11 @@
>  	select SSE
>  	select SSE2
> 
> +config CPU_ADDR_BITS
> +	int
> +	default 40
> +	depends on CPU_AMD_MODEL_FXX
> +
>  config UDELAY_IO
>  	bool
>  	default n
> 
> 
> ]Kind regards,
> ]Harald Gutmann
Scott - 2010-11-04 21:51:09
-----Original Message-----
From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Harald Gutmann
Sent: Thursday, November 04, 2010 02:47 PM
To: coreboot@coreboot.org
Subject: Re: [coreboot] Gigabyte M57SLI - some troubles with recentcorebootversion

]Hello Scott,
]
]thank you for your fast reply!
]
]Your provided solution works fine to fix the MTRR problem on my board!
]Just FYI, my CPU is the following:
]model name      : AMD Athlon(tm) 64 X2 Dual Core Processor 6000+
]
]I'm just thinking if your suggested place for changing the KConfig is the right 
]one, as the other boards did that config in the socket directory.
]And I guess that the model_fxx directory is used in several sockets. Therefor 
]I think it would be better to add that config value in "cpu/amd/socket_AM2" so 
]that other sockets don't get affected with this change.

Hello Harald,

I chose model_fxx directory because all AMD family F processors use the 40-bit
mask. But any kconfig seems like the wrong place this kind of information. There
was some recent talk about making coreboot get this info from cpuid at runtime,
which is the method that lets Windows and linux report the problem. I might
submit such a patch. It should solve this problem for years to come.

Thanks,
Scott

]Kind regards,
]Harald



On Thursday 04 November 2010 19:28:39 Scott Duplichan wrote:
> -----Original Message-----
> From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org]
> On Behalf Of Harald Gutmann Sent: Thursday, November 04, 2010 12:46 PM
> To: coreboot@coreboot.org
> Subject: [coreboot] Gigabyte M57SLI - some troubles with recent
> corebootversion
> 
> ]Hello readers,
> ]
> ]after some while I tried to use coreboot again on my well supported
> Gigabyte ]M57SLI and I was really happy, that the first built image booted
> the machine. ]
> ]Last time I tried this, I stumbled across an error with the RAM, and had
> no ]time to investigate this further.
> ]
> ]With the recent version of coreboot (r6013) I get some errors which I'd
> like ]to fix. I don't know if some changes to coreboot happened in the
> meanwhile or, ]if the kernel got changed so that this errors appear. My
> kernel version ]running is from debian sid with the version number
> 2.6.32-27 for AMD64. ]
> ]The problems I get are the following:
> ][    0.000000] mtrr: your BIOS has set up an incorrect mask, fixing it up.
> 
> It looks like your project uses an AMD family 0Fh processor. Windows 7
> checked build makes a blue screen due to the variable MTRR mask. It
> defaults to 36, which is incorrect for his processor. 40 is needed:
> 
> Index: src/cpu/amd/model_fxx/Kconfig
> ===================================================================
> --- src/cpu/amd/model_fxx/Kconfig	(revision 6017)
> +++ src/cpu/amd/model_fxx/Kconfig	(working copy)
> @@ -4,6 +4,11 @@
>  	select SSE
>  	select SSE2
> 
> +config CPU_ADDR_BITS
> +	int
> +	default 40
> +	depends on CPU_AMD_MODEL_FXX
> +
>  config UDELAY_IO
>  	bool
>  	default n
> 
> 
> ]Kind regards,
> ]Harald Gutmann

Patch

Index: src/cpu/amd/model_fxx/Kconfig
===================================================================
--- src/cpu/amd/model_fxx/Kconfig	(revision 6017)
+++ src/cpu/amd/model_fxx/Kconfig	(working copy)
@@ -4,6 +4,11 @@ 
 	select SSE
 	select SSE2
 
+config CPU_ADDR_BITS
+	int
+	default 40
+	depends on CPU_AMD_MODEL_FXX
+
 config UDELAY_IO
 	bool
 	default n