Patchwork mirror fix about superio makefile

login
register
about
Submitter Jason Wang
Date 2010-11-09 09:11:22
Message ID <AANLkTi=DNkUJpuyzcoCKzKV5_=znFfam9VyjpaiX7tf0@mail.gmail.com>
Download mbox | patch
Permalink /patch/2278/
State Rejected
Headers show

Comments

Jason Wang - 2010-11-09 09:11:22
see the patch

Signed-off-by: Wang Qing Pei <wangqingpei@gmail.com>

Best wishes

Wang Qing Pei
Phone: 86+18930528086
Idwer Vollering - 2010-11-09 23:44:06
2010/11/9 Qing Pei Wang <wangqingpei@gmail.com>

> see the patch
>
> Nack. Please don't change this, or this will happen (demonstrated using
FreeBSD 8.1 + libpci 3.1.7 + gmake-3.81):

$ gmake clean && gmake
rm -f superiotool *.o
gcc -O2 -Wall -Werror -Wstrict-prototypes -Wundef -Wstrict-aliasing
-Werror-implicit-function-declaration -ansi -pedantic
-D'SUPERIOTOOL_VERSION="6024"' -I/usr/local/include -DPCI_SUPPORT   -c -o
superiotool.o superiotool.c
cc1: warnings being treated as errors
In file included from superiotool.h:41,
                 from superiotool.c:24:
/usr/local/include/pci/pci.h:238: warning: comma at end of enumerator list
gmake: *** [superiotool.o] Error 1

Signed-off-by: Wang Qing Pei <wangqingpei@gmail.com>
>
> Best wishes
>
> Wang Qing Pei
> Phone: 86+18930528086
>
> --
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
>

Patch

Index: util/superiotool/Makefile
===================================================================
--- util/superiotool/Makefile	(revision 6049)
+++ util/superiotool/Makefile	(working copy)
@@ -40,9 +40,7 @@ 
 LIBS = -framework IOKit -framework DirectIO -lpci -lz
 endif
 ifeq ($(OS_ARCH), FreeBSD)
-CFLAGS = -O2 -Wall -Werror -Wstrict-prototypes -Wundef -Wstrict-aliasing \
-         -Werror-implicit-function-declaration -ansi $(SVNDEF) \
-         -I/usr/local/include
+CFLAGS += -I/usr/local/include
 LDFLAGS += -L/usr/local/lib
 LIBS = -lz
 endif