Patchwork adjust some code/comment of sb700 sata init

login
register
about
Submitter Jason Wang
Date 2010-11-09 09:17:07
Message ID <AANLkTikWWmHun5nMT=P1w5ok+Zgzuph+7UAbD2JaAsp0@mail.gmail.com>
Download mbox | patch
Permalink /patch/2279/
State Accepted
Headers show

Comments

Jason Wang - 2010-11-09 09:17:07
the inline comment of sata_init function seems not placed correctly. rearrange
it.

Signed-off-by: Wang Qing Pei <wangqingpei@gmail.com>

Best wishes
Wang Qing Pei
Phone: 86+18930528086
Marc Jones - 2010-11-09 17:36:45
On Tue, Nov 9, 2010 at 2:17 AM, Qing Pei Wang <wangqingpei@gmail.com> wrote:
> the inline comment of sata_init function seems not placed
> correctly. rearrange it.
> Signed-off-by: Wang Qing Pei <wangqingpei@gmail.com>

Acked-by: Marc Jones <marcj303@gmail.com>

Patch

Index: src/southbridge/amd/sb700/sb700_sata.c
===================================================================
--- src/southbridge/amd/sb700/sb700_sata.c	(revision 6049)
+++ src/southbridge/amd/sb700/sb700_sata.c	(working copy)
@@ -91,14 +91,13 @@ 
 
 	device_t sm_dev;
 	/* SATA SMBus Disable */
-	/* sm_dev = pci_locate_device(PCI_ID(0x1002, 0x4385), 0); */
 	sm_dev = dev_find_slot(0, PCI_DEVFN(0x14, 0));
-	/* Disable SATA SMBUS */
+
 	byte = pci_read_config8(sm_dev, 0xad);
-	byte |= (1 << 1);
-	/* Enable SATA and power saving */
-	byte = pci_read_config8(sm_dev, 0xad);
+	/* Disable SATA SMBUS */
 	byte |= (1 << 0);
+	/* Enable SATA and power saving */
+	byte |= (1 << 1);
 	byte |= (1 << 5);
 	pci_write_config8(sm_dev, 0xad, byte);