| Submitter | Patrick Georgi |
|---|---|
| Date | 2010-11-22 14:20:20 |
| Message ID | <4CEA7C24.2080508@georgi-clan.de> |
| Download | mbox | patch |
| Permalink | /patch/2346/ |
| State | Accepted |
| Commit | r6118 |
| Headers | show |
Comments
On Mon, Nov 22, 2010 at 03:20:20PM +0100, Patrick Georgi wrote: > Hi, > > with r6114, no board in trunk uses smp_write_bus directly anymore. > Instead, mptable_write_buses looks up all buses in the device tree and > adds them to the table accordingly. Awesome! > I propose to hide smp_write_bus, so no new board can reintroduce such code. > > == > Make smp_write_bus static (local scope), to prevent new boards from > using it directly again. > > Signed-off-by: Patrick Georgi <patrick@georgi-clan.de Acked-by: Uwe Hermann <uwe@hermann-uwe.de> Uwe.
Patch
Index: src/arch/i386/boot/mpspec.c =================================================================== --- src/arch/i386/boot/mpspec.c (Revision 6113) +++ src/arch/i386/boot/mpspec.c (Arbeitskopie) @@ -157,7 +157,7 @@ } } -void smp_write_bus(struct mp_config_table *mc, +static void smp_write_bus(struct mp_config_table *mc, unsigned char id, const char *bustype) { struct mpc_config_bus *mpc; Index: src/arch/i386/include/arch/smp/mpspec.h =================================================================== --- src/arch/i386/include/arch/smp/mpspec.h (Revision 6113) +++ src/arch/i386/include/arch/smp/mpspec.h (Arbeitskopie) @@ -243,8 +243,6 @@ unsigned char cpuflag, unsigned int cpufeature, unsigned int featureflag); void smp_write_processors(struct mp_config_table *mc); -void smp_write_bus(struct mp_config_table *mc, - unsigned char id, const char *bustype); void smp_write_ioapic(struct mp_config_table *mc, unsigned char id, unsigned char ver, unsigned long apicaddr);
Hi, with r6114, no board in trunk uses smp_write_bus directly anymore. Instead, mptable_write_buses looks up all buses in the device tree and adds them to the table accordingly. I propose to hide smp_write_bus, so no new board can reintroduce such code. == Make smp_write_bus static (local scope), to prevent new boards from using it directly again. Signed-off-by: Patrick Georgi <patrick@georgi-clan.de