Submitter | Uwe Hermann |
---|---|
Date | 2010-12-06 22:45:52 |
Message ID | <20101206224552.GQ21636@greenwood> |
Download | mbox | patch |
Permalink | /patch/2404/ |
State | Accepted |
Headers | show |
Comments
Am 06.12.2010 23:45, schrieb Uwe Hermann:
> See patch.
src/cpu/Kconfig defines CACHE_AS_RAM to "!ROMCC", so I think these can
be dropped completely. Right?
We basically assume it's CAR unless romcc is used.
Patrick
Hi Uwe, good approach! * Uwe Hermann <uwe@hermann-uwe.de> [101206 23:45]: > Move "select CACHE_AS_RAM" lines from boards into CPU socket. I generally like this idea, but that is not the only thing the patch does. If it did, it were Acked-by: Stefan Reinauer <stepan@coreboot.org> > All K8/Fam10h boards use CAR, so move the "select CACHE_AS_RAM" > into model_fxx/Kconfig and model_10xxx/Kconfig, and remove it from the > individual boards and the individual sockets using model_fxx/model_10xxx. I think CAR should be selected in the socket, not in the model. In case of the AMD K8 CPUs it is not a big difference, but in general, a socket should be the entity to decide whether a given setup can run CAR or not. The rationale is that the socket is what enforces which CPU models can run on a board. And if there is only one model for that socket that does not support CAR, we can't do CAR for that socket (or would need to define a new socket for that) Unfortunately we can not well model the above logic in model_* Kconfig files very nicely, so it will have keep living in the socket. In short, please drop the following part of the patch, add select CACHE_AS_RAM to the K8/Fam10 sockets if it's missing there instead, and it's all fine. > Index: src/cpu/amd/socket_940/Kconfig > =================================================================== > --- src/cpu/amd/socket_940/Kconfig (Revision 6145) > +++ src/cpu/amd/socket_940/Kconfig (Arbeitskopie) > @@ -7,7 +7,6 @@ > def_bool y > select K8_HT_FREQ_1G_SUPPORT > select CPU_AMD_MODEL_FXX > - select CACHE_AS_RAM > > config CPU_ADDR_BITS > int > Index: src/cpu/amd/model_fxx/Kconfig > =================================================================== > --- src/cpu/amd/model_fxx/Kconfig (Revision 6145) > +++ src/cpu/amd/model_fxx/Kconfig (Arbeitskopie) > @@ -3,6 +3,7 @@ > select MMX > select SSE > select SSE2 > + select CACHE_AS_RAM > > if CPU_AMD_MODEL_FXX > config UDELAY_IO > Index: src/cpu/amd/socket_754/Kconfig > =================================================================== > --- src/cpu/amd/socket_754/Kconfig (Revision 6145) > +++ src/cpu/amd/socket_754/Kconfig (Arbeitskopie) > @@ -6,7 +6,6 @@ > config SOCKET_SPECIFIC_OPTIONS > def_bool y > select CPU_AMD_MODEL_FXX > - select CACHE_AS_RAM > > config CPU_ADDR_BITS > int In addition, this is ugly because the actual code selection for CAR still happens in the socket_*** Makefile.inc, so if there is a good reason for moving from socket to model (except we wouldn't have to add a line to each socket rather than just two models, i think this is no sufficient reason to start becoming inconsistent across CPUs), the Makefile.inc portion should be moved, too, and live where the Kconfig portion lives. Best case would be to remove CACHE_AS_RAM/ROMCC from Kconfig all together, and plug it into the Makefiles, so we have less files to look at for this one piece of logic. (By forgetting the Makefile.inc change you proved this point ;) Stefan
* Patrick Georgi <patrick@georgi-clan.de> [101207 16:35]: > Am 06.12.2010 23:45, schrieb Uwe Hermann: > > See patch. > src/cpu/Kconfig defines CACHE_AS_RAM to "!ROMCC", so I think these can > be dropped completely. Right? > > We basically assume it's CAR unless romcc is used. This seems to make a lot of sense. Do we need this stuff in Kconfig at all? Stefan
* Stefan Reinauer <stepan@coreboot.org> [101207 23:06]: > * Patrick Georgi <patrick@georgi-clan.de> [101207 16:35]: > > Am 06.12.2010 23:45, schrieb Uwe Hermann: > > > See patch. > > src/cpu/Kconfig defines CACHE_AS_RAM to "!ROMCC", so I think these can > > be dropped completely. Right? > > > > We basically assume it's CAR unless romcc is used. > > This seems to make a lot of sense. > > Do we need this stuff in Kconfig at all? There are only very few places in the Makefile that need the distinction: ./src/arch/i386/Makefile.inc:ifeq ($(CONFIG_ROMCC),y) ./src/arch/i386/Makefile.inc:ifeq ($(CONFIG_ROMCC),y) ./src/pc80/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += serial.c ./src/console/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += console.c ./src/lib/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += ramtest.c And some in the .c files, but I think it would be safe to replace those #if CONFIG_CACHE_AS_RAM with #ifndef __ROMCC__ Stefan
On Tue, Dec 07, 2010 at 11:11:23PM +0100, Stefan Reinauer wrote: > * Stefan Reinauer <stepan@coreboot.org> [101207 23:06]: > > * Patrick Georgi <patrick@georgi-clan.de> [101207 16:35]: > > > Am 06.12.2010 23:45, schrieb Uwe Hermann: > > > > See patch. > > > src/cpu/Kconfig defines CACHE_AS_RAM to "!ROMCC", so I think these can > > > be dropped completely. Right? > > > > > > We basically assume it's CAR unless romcc is used. > > > > This seems to make a lot of sense. > > > > Do we need this stuff in Kconfig at all? > > There are only very few places in the Makefile that need the > distinction: > > ./src/arch/i386/Makefile.inc:ifeq ($(CONFIG_ROMCC),y) > ./src/arch/i386/Makefile.inc:ifeq ($(CONFIG_ROMCC),y) > ./src/pc80/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += serial.c > ./src/console/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += console.c > ./src/lib/Makefile.inc:romstage-$(CONFIG_CACHE_AS_RAM) += ramtest.c > > And some in the .c files, but I think it would be safe to replace those > #if CONFIG_CACHE_AS_RAM with #ifndef __ROMCC__ That would be pretty confusing IMHO, as sometimes "#ifndef __ROMCC__" is used even in CAR boards (where the bootblock is compiled with romcc AFAIK) in some header files (to "disable" function prototypes which romcc doesn't support). The __ROMCC__ #define would then serve two different purposes, kind of like before we splitted away __PRE_RAM__ from __ROMCC__. Uwe.
On Tue, Dec 07, 2010 at 11:05:19PM +0100, Stefan Reinauer wrote: > Hi Uwe, > > good approach! > > * Uwe Hermann <uwe@hermann-uwe.de> [101206 23:45]: > > Move "select CACHE_AS_RAM" lines from boards into CPU socket. > > I generally like this idea, but that is not the only thing the patch > does. If it did, it were Acked-by: Stefan Reinauer <stepan@coreboot.org> > > > All K8/Fam10h boards use CAR, so move the "select CACHE_AS_RAM" > > into model_fxx/Kconfig and model_10xxx/Kconfig, and remove it from the > > individual boards and the individual sockets using model_fxx/model_10xxx. > > I think CAR should be selected in the socket, not in the model. In case > of the AMD K8 CPUs it is not a big difference, but in general, a socket > should be the entity to decide whether a given setup can run CAR or not. Yep, I agree, comitted as r6151 resuing your ack. I moved all those selects to the socket, and changed the model_10xxx to do the same (it already had the select in model_10xxx, not in the sockets). > In addition, this is ugly because the actual code selection for CAR > still happens in the socket_*** Makefile.inc, so if there is a good > reason for moving from socket to model (except we wouldn't have to add > a line to each socket rather than just two models, Nope, no other reason, I just wanted to save a few lines. I agree consistency across all sockets/CPUs is much more important here, though. Uwe.
Patch
Move "select CACHE_AS_RAM" lines from boards into CPU socket. All K8/Fam10h boards use CAR, so move the "select CACHE_AS_RAM" into model_fxx/Kconfig and model_10xxx/Kconfig, and remove it from the individual boards and the individual sockets using model_fxx/model_10xxx. Do the same for Intel CPUs/sockets where all boards use CAR. This is abuild-tested. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Index: src/cpu/amd/socket_940/Kconfig =================================================================== --- src/cpu/amd/socket_940/Kconfig (Revision 6145) +++ src/cpu/amd/socket_940/Kconfig (Arbeitskopie) @@ -7,7 +7,6 @@ def_bool y select K8_HT_FREQ_1G_SUPPORT select CPU_AMD_MODEL_FXX - select CACHE_AS_RAM config CPU_ADDR_BITS int Index: src/cpu/amd/model_fxx/Kconfig =================================================================== --- src/cpu/amd/model_fxx/Kconfig (Revision 6145) +++ src/cpu/amd/model_fxx/Kconfig (Arbeitskopie) @@ -3,6 +3,7 @@ select MMX select SSE select SSE2 + select CACHE_AS_RAM if CPU_AMD_MODEL_FXX config UDELAY_IO Index: src/cpu/amd/socket_754/Kconfig =================================================================== --- src/cpu/amd/socket_754/Kconfig (Revision 6145) +++ src/cpu/amd/socket_754/Kconfig (Arbeitskopie) @@ -6,7 +6,6 @@ config SOCKET_SPECIFIC_OPTIONS def_bool y select CPU_AMD_MODEL_FXX - select CACHE_AS_RAM config CPU_ADDR_BITS int Index: src/cpu/intel/socket_mFCBGA479/Kconfig =================================================================== --- src/cpu/intel/socket_mFCBGA479/Kconfig (Revision 6145) +++ src/cpu/intel/socket_mFCBGA479/Kconfig (Arbeitskopie) @@ -3,3 +3,4 @@ select CPU_INTEL_MODEL_6BX select MMX select SSE + select CACHE_AS_RAM Index: src/cpu/intel/socket_mFCPGA478/Kconfig =================================================================== --- src/cpu/intel/socket_mFCPGA478/Kconfig (Revision 6145) +++ src/cpu/intel/socket_mFCPGA478/Kconfig (Arbeitskopie) @@ -1,2 +1,3 @@ config CPU_INTEL_SOCKET_MFCPGA478 bool + select CACHE_AS_RAM Index: src/cpu/intel/socket_mPGA479M/Kconfig =================================================================== --- src/cpu/intel/socket_mPGA479M/Kconfig (Revision 6145) +++ src/cpu/intel/socket_mPGA479M/Kconfig (Arbeitskopie) @@ -6,3 +6,4 @@ select CPU_INTEL_MODEL_F2X select MMX select SSE + select CACHE_AS_RAM Index: src/mainboard/asrock/939a785gmh/Kconfig =================================================================== --- src/mainboard/asrock/939a785gmh/Kconfig (Revision 6145) +++ src/mainboard/asrock/939a785gmh/Kconfig (Arbeitskopie) @@ -18,7 +18,6 @@ select HAVE_OPTION_TABLE select HAVE_BUS_CONFIG select LIFT_BSP_APIC_ID - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select BOARD_ROMSIZE_KB_1024 Index: src/mainboard/getac/p470/Kconfig =================================================================== --- src/mainboard/getac/p470/Kconfig (Revision 6145) +++ src/mainboard/getac/p470/Kconfig (Arbeitskopie) @@ -40,7 +40,6 @@ select UDELAY_LAPIC select HAVE_SMI_HANDLER select BOARD_ROMSIZE_KB_1024 - select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK select CHANNEL_XOR_RANDOMIZATION Index: src/mainboard/thomson/ip1000/Kconfig =================================================================== --- src/mainboard/thomson/ip1000/Kconfig (Revision 6145) +++ src/mainboard/thomson/ip1000/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_MAINBOARD_RESOURCES select HAVE_SMI_HANDLER select GFXUMA - select CACHE_AS_RAM select TINY_BOOTBLOCK config MAINBOARD_DIR Index: src/mainboard/supermicro/h8dmr/Kconfig =================================================================== --- src/mainboard/supermicro/h8dmr/Kconfig (Revision 6145) +++ src/mainboard/supermicro/h8dmr/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_BUS_CONFIG select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select BOARD_ROMSIZE_KB_1024 Index: src/mainboard/supermicro/h8dme/Kconfig =================================================================== --- src/mainboard/supermicro/h8dme/Kconfig (Revision 6145) +++ src/mainboard/supermicro/h8dme/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_BUS_CONFIG select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET #select AP_CODE_IN_CAR select LIFT_BSP_APIC_ID Index: src/mainboard/supermicro/h8dmr_fam10/Kconfig =================================================================== --- src/mainboard/supermicro/h8dmr_fam10/Kconfig (Revision 6145) +++ src/mainboard/supermicro/h8dmr_fam10/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select AMDMCT Index: src/mainboard/supermicro/h8qme_fam10/Kconfig =================================================================== --- src/mainboard/supermicro/h8qme_fam10/Kconfig (Revision 6145) +++ src/mainboard/supermicro/h8qme_fam10/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select AMDMCT Index: src/mainboard/kontron/986lcd-m/Kconfig =================================================================== --- src/mainboard/kontron/986lcd-m/Kconfig (Revision 6145) +++ src/mainboard/kontron/986lcd-m/Kconfig (Arbeitskopie) @@ -17,7 +17,6 @@ select MMCONF_SUPPORT select HAVE_SMI_HANDLER select BOARD_ROMSIZE_KB_1024 - select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK select CHANNEL_XOR_RANDOMIZATION Index: src/mainboard/kontron/kt690/Kconfig =================================================================== --- src/mainboard/kontron/kt690/Kconfig (Revision 6145) +++ src/mainboard/kontron/kt690/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES select GFXUMA - select CACHE_AS_RAM select HAVE_HARD_RESET select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 Index: src/mainboard/gigabyte/m57sli/Kconfig =================================================================== --- src/mainboard/gigabyte/m57sli/Kconfig (Revision 6145) +++ src/mainboard/gigabyte/m57sli/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select HAVE_ACPI_TABLES Index: src/mainboard/gigabyte/ma78gm/Kconfig =================================================================== --- src/mainboard/gigabyte/ma78gm/Kconfig (Revision 6145) +++ src/mainboard/gigabyte/ma78gm/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/gigabyte/ga_2761gxdk/Kconfig =================================================================== --- src/mainboard/gigabyte/ga_2761gxdk/Kconfig (Revision 6145) +++ src/mainboard/gigabyte/ga_2761gxdk/Kconfig (Arbeitskopie) @@ -13,7 +13,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select K8_REV_F_SUPPORT Index: src/mainboard/gigabyte/ma785gmt/Kconfig =================================================================== --- src/mainboard/gigabyte/ma785gmt/Kconfig (Revision 6145) +++ src/mainboard/gigabyte/ma785gmt/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/digitallogic/adl855pc/Kconfig =================================================================== --- src/mainboard/digitallogic/adl855pc/Kconfig (Revision 6145) +++ src/mainboard/digitallogic/adl855pc/Kconfig (Arbeitskopie) @@ -11,7 +11,6 @@ select HAVE_PIRQ_TABLE select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_1024 - select CACHE_AS_RAM select TINY_BOOTBLOCK config MAINBOARD_DIR Index: src/mainboard/amd/mahogany/Kconfig =================================================================== --- src/mainboard/amd/mahogany/Kconfig (Revision 6145) +++ src/mainboard/amd/mahogany/Kconfig (Arbeitskopie) @@ -18,7 +18,6 @@ select HAVE_MAINBOARD_RESOURCES select HAVE_BUS_CONFIG select LIFT_BSP_APIC_ID - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select BOARD_ROMSIZE_KB_1024 Index: src/mainboard/amd/pistachio/Kconfig =================================================================== --- src/mainboard/amd/pistachio/Kconfig (Revision 6145) +++ src/mainboard/amd/pistachio/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select WAIT_BEFORE_CPUS_INIT Index: src/mainboard/amd/dbm690t/Kconfig =================================================================== --- src/mainboard/amd/dbm690t/Kconfig (Revision 6145) +++ src/mainboard/amd/dbm690t/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_OPTION_TABLE select HAVE_MAINBOARD_RESOURCES select HAVE_BUS_CONFIG - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select BOARD_ROMSIZE_KB_1024 Index: src/mainboard/amd/serengeti_cheetah/Kconfig =================================================================== --- src/mainboard/amd/serengeti_cheetah/Kconfig (Revision 6145) +++ src/mainboard/amd/serengeti_cheetah/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID #select AP_CODE_IN_CAR Index: src/mainboard/amd/mahogany_fam10/Kconfig =================================================================== --- src/mainboard/amd/mahogany_fam10/Kconfig (Revision 6145) +++ src/mainboard/amd/mahogany_fam10/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/amd/tilapia_fam10/Kconfig =================================================================== --- src/mainboard/amd/tilapia_fam10/Kconfig (Revision 6145) +++ src/mainboard/amd/tilapia_fam10/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/amd/serengeti_cheetah_fam10/Kconfig =================================================================== --- src/mainboard/amd/serengeti_cheetah_fam10/Kconfig (Revision 6145) +++ src/mainboard/amd/serengeti_cheetah_fam10/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select SERIAL_CPU_INIT Index: src/mainboard/rca/rm4100/Kconfig =================================================================== --- src/mainboard/rca/rm4100/Kconfig (Revision 6145) +++ src/mainboard/rca/rm4100/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_MAINBOARD_RESOURCES select HAVE_SMI_HANDLER select GFXUMA - select CACHE_AS_RAM select TINY_BOOTBLOCK config MAINBOARD_DIR Index: src/mainboard/iei/kino-780am2-fam10/Kconfig =================================================================== --- src/mainboard/iei/kino-780am2-fam10/Kconfig (Revision 6145) +++ src/mainboard/iei/kino-780am2-fam10/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/hp/dl145_g3/Kconfig =================================================================== --- src/mainboard/hp/dl145_g3/Kconfig (Revision 6145) +++ src/mainboard/hp/dl145_g3/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select BOARD_ROMSIZE_KB_512 Index: src/mainboard/hp/dl165_g6_fam10/Kconfig =================================================================== --- src/mainboard/hp/dl165_g6_fam10/Kconfig (Revision 6145) +++ src/mainboard/hp/dl165_g6_fam10/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_BUS_CONFIG select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select BOARD_ROMSIZE_KB_1024 Index: src/mainboard/tyan/s2912/Kconfig =================================================================== --- src/mainboard/tyan/s2912/Kconfig (Revision 6145) +++ src/mainboard/tyan/s2912/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select K8_REV_F_SUPPORT Index: src/mainboard/tyan/s2912_fam10/Kconfig =================================================================== --- src/mainboard/tyan/s2912_fam10/Kconfig (Revision 6145) +++ src/mainboard/tyan/s2912_fam10/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select BOARD_ROMSIZE_KB_1024 Index: src/mainboard/lanner/em8510/Kconfig =================================================================== --- src/mainboard/lanner/em8510/Kconfig (Revision 6145) +++ src/mainboard/lanner/em8510/Kconfig (Arbeitskopie) @@ -11,7 +11,6 @@ select HAVE_PIRQ_TABLE select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_512 - select CACHE_AS_RAM select TINY_BOOTBLOCK config MAINBOARD_DIR Index: src/mainboard/ibase/mb899/Kconfig =================================================================== --- src/mainboard/ibase/mb899/Kconfig (Revision 6145) +++ src/mainboard/ibase/mb899/Kconfig (Arbeitskopie) @@ -17,7 +17,6 @@ select MMCONF_SUPPORT select HAVE_SMI_HANDLER select BOARD_ROMSIZE_KB_512 - select CACHE_AS_RAM select GFXUMA select TINY_BOOTBLOCK select CHANNEL_XOR_RANDOMIZATION Index: src/mainboard/msi/ms9282/Kconfig =================================================================== --- src/mainboard/msi/ms9282/Kconfig (Revision 6145) +++ src/mainboard/msi/ms9282/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select K8_REV_F_SUPPORT select BOARD_ROMSIZE_KB_512 Index: src/mainboard/msi/ms9185/Kconfig =================================================================== --- src/mainboard/msi/ms9185/Kconfig (Revision 6145) +++ src/mainboard/msi/ms9185/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select BOARD_ROMSIZE_KB_512 Index: src/mainboard/msi/ms9652_fam10/Kconfig =================================================================== --- src/mainboard/msi/ms9652_fam10/Kconfig (Revision 6145) +++ src/mainboard/msi/ms9652_fam10/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select HAVE_ACPI_TABLES - select CACHE_AS_RAM select HAVE_OPTION_TABLE select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_512 Index: src/mainboard/msi/ms7260/Kconfig =================================================================== --- src/mainboard/msi/ms7260/Kconfig (Revision 6145) +++ src/mainboard/msi/ms7260/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select K8_REV_F_SUPPORT Index: src/mainboard/jetway/pa78vm5/Kconfig =================================================================== --- src/mainboard/jetway/pa78vm5/Kconfig (Revision 6145) +++ src/mainboard/jetway/pa78vm5/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_PIRQ_TABLE select HAVE_MP_TABLE select HAVE_MAINBOARD_RESOURCES - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/technexion/tim8690/Kconfig =================================================================== --- src/mainboard/technexion/tim8690/Kconfig (Revision 6145) +++ src/mainboard/technexion/tim8690/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select WAIT_BEFORE_CPUS_INIT Index: src/mainboard/technexion/tim5690/Kconfig =================================================================== --- src/mainboard/technexion/tim5690/Kconfig (Revision 6145) +++ src/mainboard/technexion/tim5690/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select HAVE_ACPI_TABLES Index: src/mainboard/nvidia/l1_2pvv/Kconfig =================================================================== --- src/mainboard/nvidia/l1_2pvv/Kconfig (Revision 6145) +++ src/mainboard/nvidia/l1_2pvv/Kconfig (Arbeitskopie) @@ -16,7 +16,6 @@ select HAVE_BUS_CONFIG select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select LIFT_BSP_APIC_ID select K8_REV_F_SUPPORT Index: src/mainboard/intel/mtarvon/Kconfig =================================================================== --- src/mainboard/intel/mtarvon/Kconfig (Revision 6145) +++ src/mainboard/intel/mtarvon/Kconfig (Arbeitskopie) @@ -7,7 +7,6 @@ select NORTHBRIDGE_INTEL_I3100 select SOUTHBRIDGE_INTEL_I3100 select SUPERIO_INTEL_I3100 - select CACHE_AS_RAM select HAVE_HARD_RESET select HAVE_PIRQ_TABLE select HAVE_MP_TABLE Index: src/mainboard/asus/m4a785-m/Kconfig =================================================================== --- src/mainboard/asus/m4a785-m/Kconfig (Revision 6145) +++ src/mainboard/asus/m4a785-m/Kconfig (Arbeitskopie) @@ -15,7 +15,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/asus/a8v-e_deluxe/Kconfig =================================================================== --- src/mainboard/asus/a8v-e_deluxe/Kconfig (Revision 6145) +++ src/mainboard/asus/a8v-e_deluxe/Kconfig (Arbeitskopie) @@ -10,7 +10,6 @@ select SOUTHBRIDGE_VIA_VT8237R select SOUTHBRIDGE_VIA_K8T890 select SUPERIO_WINBOND_W83627EHG - select CACHE_AS_RAM select HAVE_OPTION_TABLE select HAVE_ACPI_TABLES select HAVE_MP_TABLE Index: src/mainboard/asus/a8n_e/Kconfig =================================================================== --- src/mainboard/asus/a8n_e/Kconfig (Revision 6145) +++ src/mainboard/asus/a8n_e/Kconfig (Arbeitskopie) @@ -12,7 +12,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select BOARD_ROMSIZE_KB_512 select CK804_USE_NIC Index: src/mainboard/asus/m4a78-em/Kconfig =================================================================== --- src/mainboard/asus/m4a78-em/Kconfig (Revision 6145) +++ src/mainboard/asus/m4a78-em/Kconfig (Arbeitskopie) @@ -14,7 +14,6 @@ select HAVE_OPTION_TABLE select HAVE_PIRQ_TABLE select HAVE_MP_TABLE - select CACHE_AS_RAM select HAVE_HARD_RESET select SB_HT_CHAIN_UNITID_OFFSET_ONLY select LIFT_BSP_APIC_ID Index: src/mainboard/asus/m2v/Kconfig =================================================================== --- src/mainboard/asus/m2v/Kconfig (Revision 6145) +++ src/mainboard/asus/m2v/Kconfig (Arbeitskopie) @@ -13,7 +13,6 @@ select SOUTHBRIDGE_VIA_VT8237R select SOUTHBRIDGE_VIA_K8T890 select SUPERIO_ITE_IT8712F - select CACHE_AS_RAM select BOARD_ROMSIZE_KB_512 select RAMINIT_SYSINFO select TINY_BOOTBLOCK Index: src/mainboard/asus/a8v-e_se/Kconfig =================================================================== --- src/mainboard/asus/a8v-e_se/Kconfig (Revision 6145) +++ src/mainboard/asus/a8v-e_se/Kconfig (Arbeitskopie) @@ -10,7 +10,6 @@ select SOUTHBRIDGE_VIA_VT8237R select SOUTHBRIDGE_VIA_K8T890 select SUPERIO_WINBOND_W83627EHG - select CACHE_AS_RAM select HAVE_OPTION_TABLE select HAVE_ACPI_TABLES select HAVE_MP_TABLE Index: src/mainboard/asus/m2v-mx_se/Kconfig =================================================================== --- src/mainboard/asus/m2v-mx_se/Kconfig (Revision 6145) +++ src/mainboard/asus/m2v-mx_se/Kconfig (Arbeitskopie) @@ -28,7 +28,6 @@ select SOUTHBRIDGE_VIA_VT8237R select SOUTHBRIDGE_VIA_K8M890 select SUPERIO_ITE_IT8712F - select CACHE_AS_RAM select HAVE_OPTION_TABLE select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_512