Patchwork Cleanup up HD audio codec / hda_verb.h files

login
register
about
Submitter Uwe Hermann
Date 2010-12-11 11:49:05
Message ID <20101211114904.GV21636@greenwood>
Download mbox | patch
Permalink /patch/2416/
State Accepted
Headers show

Comments

Uwe Hermann - 2010-12-11 11:49:05
See patch.

Most of the hda_verb.h files can be safely dropped as they're unused
(and/or incorrect).

I own the MSI MS-7260 and will provide a working hda_verb.h file for
that at some later point, and also for my upcoming ASUS M2N-E port.


Uwe.
Peter Stuge - 2010-12-11 20:57:19
Uwe Hermann wrote:
> Cleanup up HD audio codec / hda_verb.h files.
..
> Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Acked-by: Peter Stuge <peter@stuge.se>
Stefan Reinauer - 2010-12-11 21:29:09
On 12/11/10 12:57 PM, Peter Stuge wrote:
> Uwe Hermann wrote:
>> Cleanup up HD audio codec / hda_verb.h files.
> ..
>> Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
> Acked-by: Peter Stuge <peter@stuge.se>
>
However, please refrain from removing the verb adding code from those
boards that actually have sound jacks. It makes no sense to remove the
codecs and add the same code later on. Instead it should just be fixed
as soon as the right information is known for those boards.

Stefan
Stefan Reinauer - 2010-12-11 21:30:01
Ooops that was intended for the list.

On 12/11/10 12:21 PM, Stefan Reinauer wrote:
> On 12/11/10 3:49 AM, Uwe Hermann wrote:
>> The following files can be safely dropped as they don't match the ID
>> of the audio codec and thus will never get actually used (you'll see
>> "HDA: no verb!" or similar in the coreboot logs). Even if the ID matched,
>> the rest of the table would be incorrect anyway because the values are
>> highly board-specific.
>>
>> ./src/mainboard/gigabyte/m57sli/hda_verb.h
>> ./src/mainboard/msi/ms7260/hda_verb.h
>> ./src/mainboard/msi/ms9652_fam10/hda_verb.h
>> ./src/mainboard/msi/ms9282/hda_verb.h
> Please leave those in until we can find the correct ones. A FIXME
> message would be appropriate though.
>
>> The following files can be safely dropped as these are server boards and
>> don't have HD audio (or other audio) at all:
>>
>> ./src/mainboard/supermicro/h8dmr/hda_verb.h
>> ./src/mainboard/supermicro/h8qme_fam10/hda_verb.h
>> ./src/mainboard/supermicro/h8dme/hda_verb.h
>> ./src/mainboard/supermicro/h8dmr_fam10/hda_verb.h
>> ./src/mainboard/tyan/s2912/hda_verb.h
>> ./src/mainboard/tyan/s2912_fam10/hda_verb.h
> That part is Acked-by: Stefan Reinauer <stepan@coreboot.org>
>
>> The following two are correct and can stay:
>>
>> ./src/mainboard/nvidia/l1_2pvv/hda_verb.h
>> ./src/mainboard/getac/p470/hda_verb.h
> Thanks for taking the time of finding this out.
>
Uwe Hermann - 2010-12-15 09:05:03
On Sat, Dec 11, 2010 at 01:29:09PM -0800, Stefan Reinauer wrote:
> On 12/11/10 12:57 PM, Peter Stuge wrote:
> > Uwe Hermann wrote:
> >> Cleanup up HD audio codec / hda_verb.h files.
> > ..
> >> Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
> > Acked-by: Peter Stuge <peter@stuge.se>

Thanks, r6180.


> However, please refrain from removing the verb adding code from those
> boards that actually have sound jacks. It makes no sense to remove the
> codecs and add the same code later on. Instead it should just be fixed
> as soon as the right information is known for those boards.

OK, I kept the files for now, though we should probably only keep the code
in mainboard.c (commented out) and kill the definately useless hda_verb.h
files, IMHO.


Uwe.
Stefan Reinauer - 2010-12-16 05:02:16
On 12/15/10 1:05 AM, Uwe Hermann wrote:
>> However, please refrain from removing the verb adding code from those
>> boards that actually have sound jacks. It makes no sense to remove the
>> codecs and add the same code later on. Instead it should just be fixed
>> as soon as the right information is known for those boards.
> OK, I kept the files for now, though we should probably only keep the code
> in mainboard.c (commented out) and kill the definately useless hda_verb.h
> files, IMHO.
Alright, go ahead...
Uwe Hermann - 2010-12-17 18:08:05
On Wed, Dec 15, 2010 at 09:02:16PM -0800, Stefan Reinauer wrote:
> On 12/15/10 1:05 AM, Uwe Hermann wrote:
> >>However, please refrain from removing the verb adding code from those
> >>boards that actually have sound jacks. It makes no sense to remove the
> >>codecs and add the same code later on. Instead it should just be fixed
> >>as soon as the right information is known for those boards.
> >OK, I kept the files for now, though we should probably only keep the code
> >in mainboard.c (commented out) and kill the definately useless hda_verb.h
> >files, IMHO.
> Alright, go ahead...

OK, thanks, committed in r6196.

 
Uwe.

Patch

Cleanup up HD audio codec / hda_verb.h files.

Most of the current hda_verb.h files are identical (same MD5 sum) and are
intended for a specific MCP55 board with the Realtek ALC880 audio codec,
which has the vendor/device ID of 0x10ec0880. They were splitted out from the
MCP55 southbridge code and put into board dirs a long time ago (which is
correct, as those settings are indeed board-specific), but they were never
adapted to those boards.

However, almost all of them can be safely dropped from svn until somone
with the respective board can create a correct file for the board.

Here's the table of which codec is soldered onto which board, based on
checking the vendor website board spec pages, and the board manuals:

 - GIGABYTE GA-M57SLI-S4: Realtek ALC883
 - MSI MS-7260: Realtek ALC883
 - MSI MS-9652: Realtek ALC888
 - MSI MS-9282: Server board, doesn't have audio at all
 - Tyan S2912: Server board, doesn't have audio at all
 - All Supermicro boards: Server boards, don't have audio at all
 - NVIDIA l1_2pvv: No public info to be found, but I assume this was the
   original MCP55 eval board for the port and it's probably has the Realtek
   ALC880 codec used in the original hda_verb.h.

These are the codec vendor device/IDs involved:
Realtek ALC880: 0x10ec0880
Realtek ALC883: 0x10ec0883
Realtek ALC888: 0x10ec0888

The following files can be safely dropped as they don't match the ID
of the audio codec and thus will never get actually used (you'll see
"HDA: no verb!" or similar in the coreboot logs). Even if the ID matched,
the rest of the table would be incorrect anyway because the values are
highly board-specific.

./src/mainboard/gigabyte/m57sli/hda_verb.h
./src/mainboard/msi/ms7260/hda_verb.h
./src/mainboard/msi/ms9652_fam10/hda_verb.h
./src/mainboard/msi/ms9282/hda_verb.h

The following files can be safely dropped as these are server boards and
don't have HD audio (or other audio) at all:

./src/mainboard/supermicro/h8dmr/hda_verb.h
./src/mainboard/supermicro/h8qme_fam10/hda_verb.h
./src/mainboard/supermicro/h8dme/hda_verb.h
./src/mainboard/supermicro/h8dmr_fam10/hda_verb.h
./src/mainboard/tyan/s2912/hda_verb.h
./src/mainboard/tyan/s2912_fam10/hda_verb.h

The following two are correct and can stay:

./src/mainboard/nvidia/l1_2pvv/hda_verb.h
./src/mainboard/getac/p470/hda_verb.h

Abuild-tested.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Index: src/mainboard/supermicro/h8dmr/hda_verb.h
===================================================================
--- src/mainboard/supermicro/h8dmr/hda_verb.h	(Revision 6160)
+++ src/mainboard/supermicro/h8dmr/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/supermicro/h8dmr/mainboard.c
===================================================================
--- src/mainboard/supermicro/h8dmr/mainboard.c	(Revision 6160)
+++ src/mainboard/supermicro/h8dmr/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("Supermicro H8DMR Mainboard")
-	.enable_dev = mainboard_enable,
 };
Index: src/mainboard/supermicro/h8dme/hda_verb.h
===================================================================
--- src/mainboard/supermicro/h8dme/hda_verb.h	(Revision 6160)
+++ src/mainboard/supermicro/h8dme/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/supermicro/h8dme/mainboard.c
===================================================================
--- src/mainboard/supermicro/h8dme/mainboard.c	(Revision 6160)
+++ src/mainboard/supermicro/h8dme/mainboard.c	(Arbeitskopie)
@@ -19,22 +19,8 @@ 
  */
 
 #include <device/device.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("Supermicro H8DME Mainboard")
-	.enable_dev = mainboard_enable,
 };
-
Index: src/mainboard/supermicro/h8dmr_fam10/hda_verb.h
===================================================================
--- src/mainboard/supermicro/h8dmr_fam10/hda_verb.h	(Revision 6160)
+++ src/mainboard/supermicro/h8dmr_fam10/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/supermicro/h8dmr_fam10/mainboard.c
===================================================================
--- src/mainboard/supermicro/h8dmr_fam10/mainboard.c	(Revision 6160)
+++ src/mainboard/supermicro/h8dmr_fam10/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("Supermicro H8DMR Mainboard (Family 10)")
-	.enable_dev = mainboard_enable,
 };
Index: src/mainboard/supermicro/h8qme_fam10/hda_verb.h
===================================================================
--- src/mainboard/supermicro/h8qme_fam10/hda_verb.h	(Revision 6160)
+++ src/mainboard/supermicro/h8qme_fam10/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/supermicro/h8qme_fam10/mainboard.c
===================================================================
--- src/mainboard/supermicro/h8qme_fam10/mainboard.c	(Revision 6160)
+++ src/mainboard/supermicro/h8qme_fam10/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("Supermicro H8QME-2+ Mainboard (Family 10)")
-	.enable_dev = mainboard_enable,
 };
Index: src/mainboard/gigabyte/m57sli/hda_verb.h
===================================================================
--- src/mainboard/gigabyte/m57sli/hda_verb.h	(Revision 6160)
+++ src/mainboard/gigabyte/m57sli/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/gigabyte/m57sli/mainboard.c
===================================================================
--- src/mainboard/gigabyte/m57sli/mainboard.c	(Revision 6160)
+++ src/mainboard/gigabyte/m57sli/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
-	CHIP_NAME("GIGABYTE GA-M57SLI Mainboard")
-	.enable_dev = mainboard_enable,
+	CHIP_NAME("GIGABYTE GA-M57SLI-S4 Mainboard")
 };
Index: src/mainboard/tyan/s2912/hda_verb.h
===================================================================
--- src/mainboard/tyan/s2912/hda_verb.h	(Revision 6160)
+++ src/mainboard/tyan/s2912/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/tyan/s2912/mainboard.c
===================================================================
--- src/mainboard/tyan/s2912/mainboard.c	(Revision 6160)
+++ src/mainboard/tyan/s2912/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("Tyan S2912 Mainboard")
-	.enable_dev = mainboard_enable,
 };
Index: src/mainboard/tyan/s2912_fam10/hda_verb.h
===================================================================
--- src/mainboard/tyan/s2912_fam10/hda_verb.h	(Revision 6160)
+++ src/mainboard/tyan/s2912_fam10/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/tyan/s2912_fam10/mainboard.c
===================================================================
--- src/mainboard/tyan/s2912_fam10/mainboard.c	(Revision 6160)
+++ src/mainboard/tyan/s2912_fam10/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("Tyan S2912 Mainboard (Family 10)")
-	.enable_dev = mainboard_enable,
 };
Index: src/mainboard/msi/ms9282/hda_verb.h
===================================================================
--- src/mainboard/msi/ms9282/hda_verb.h	(Revision 6160)
+++ src/mainboard/msi/ms9282/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/msi/ms9282/mainboard.c
===================================================================
--- src/mainboard/msi/ms9282/mainboard.c	(Revision 6160)
+++ src/mainboard/msi/ms9282/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
        CHIP_NAME("MSI MS-9282 Mainboard")
-       .enable_dev = mainboard_enable,
 };
Index: src/mainboard/msi/ms9652_fam10/hda_verb.h
===================================================================
--- src/mainboard/msi/ms9652_fam10/hda_verb.h	(Revision 6160)
+++ src/mainboard/msi/ms9652_fam10/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/msi/ms9652_fam10/mainboard.c
===================================================================
--- src/mainboard/msi/ms9652_fam10/mainboard.c	(Revision 6160)
+++ src/mainboard/msi/ms9652_fam10/mainboard.c	(Arbeitskopie)
@@ -19,26 +19,9 @@ 
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <console/console.h>
 #include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <device/pci_ops.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("MSI MS-9652 Mainboard (Family 10)")
-	.enable_dev = mainboard_enable,
 };
Index: src/mainboard/msi/ms7260/hda_verb.h
===================================================================
--- src/mainboard/msi/ms7260/hda_verb.h	(Revision 6160)
+++ src/mainboard/msi/ms7260/hda_verb.h	(Arbeitskopie)
@@ -1,99 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- * 
- * Copyright (C) 2004 Tyan Computer
- * Copyright (C) 2006-2007 AMD
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
- * MA 02110-1301 USA
- */
-
-static u32 mainboard_cim_verb_data[] = {
-	/* coreboot specific header */
-	0x10ec0880,	// Codec Vendor ID / Device ID
-	0x00000000,	// Subsystem ID
-	0x0000000d,	// Number of jacks
-
-	/* HDA Codec Subsystem ID Verb Table: 0x0000e601 */
-	0x00172001,
-	0x001721e6,
-	0x00172200,
-	0x00172300,
-
-	0x01471c10,
-	0x01471d44,
-	0x01471e01,
-	0x01471f01,
-	// 1
-	0x01571c12,
-	0x01571d14,
-	0x01571e01,
-	0x01571f01,
-	// 2
-	0x01671c11,
-	0x01671d60,
-	0x01671e01,
-	0x01671f01,
-	// 3
-	0x01771c14,
-	0x01771d20,
-	0x01771e01,
-	0x01771f01,
-	// 4
-	0x01871c30,
-	0x01871d9c,
-	0x01871ea1,
-	0x01871f01,
-	// 5
-	0x01971c40,
-	0x01971d9c,
-	0x01971ea1,
-	0x01971f02,
-	// 6
-	0x01a71c31,
-	0x01a71d34,
-	0x01a71e81,
-	0x01a71f01,
-	// 7
-	0x01b71c1f,
-	0x01b71d44,
-	0x01b71e21,
-	0x01b71f02,
-	// 8
-	0x01c71cf0,
-	0x01c71d11,
-	0x01c71e11,
-	0x01c71f41,
-	// 9
-	0x01d71c3e,
-	0x01d71d01,
-	0x01d71e83,
-	0x01d71f99,
-	// 10
-	0x01e71c20,
-	0x01e71d41,
-	0x01e71e45,
-	0x01e71f01,
-	// 11
-	0x01f71c50,
-	0x01f71d91,
-	0x01f71ec5,
-	0x01f71f01,
-};
-
-extern u32 * cim_verb_data;
-extern u32 cim_verb_data_size;
-
Index: src/mainboard/msi/ms7260/mainboard.c
===================================================================
--- src/mainboard/msi/ms7260/mainboard.c	(Revision 6160)
+++ src/mainboard/msi/ms7260/mainboard.c	(Arbeitskopie)
@@ -19,22 +19,8 @@ 
  */
 
 #include <device/device.h>
-#include "hda_verb.h"
 #include "chip.h"
 
-static void verb_setup(void)
-{
-	cim_verb_data = mainboard_cim_verb_data;
-	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
-}
-
-static void mainboard_enable(device_t dev) 
-{
-	verb_setup();
-}
-
-
 struct chip_operations mainboard_ops = {
 	CHIP_NAME("MSI K9N Neo (MS-7260) Mainboard")
-	.enable_dev = mainboard_enable,
 };