| Submitter | Uwe Hermann |
|---|---|
| Date | 2009-09-04 11:19:41 |
| Message ID | <20090904111940.GS7448@greenwood> |
| Download | mbox | patch |
| Permalink | /patch/245/ |
| State | Accepted |
| Headers | show |
Comments
> Subject: [coreboot] [PATCH] Use driver-y instead of obj-y > formodel_6xx_init.o Good find. Have you looked at the other CPUs to see if they need this? Is it documented? Acked-by: Myles Watson <mylesgw@gmail.com> Thanks, Myles
On Fri, Sep 04, 2009 at 07:03:06AM -0600, Myles Watson wrote: > > Subject: [coreboot] [PATCH] Use driver-y instead of obj-y > > formodel_6xx_init.o > Good find. Have you looked at the other CPUs to see if they need this? Is > it documented? Not sure. All other model_*.o files are driver-y already, _but_ there are other *.o files in src/cpu/ that are obj-y (not driver-y), dunno if that is intentional. > Acked-by: Myles Watson <mylesgw@gmail.com> Thanks, r4626. Uwe.
In the case of files I converted, the use of driver or obj *should* have just followed the Config.lb. This sort of thing is best done with scripts ... ron
Patch
Use driver-y instead of obj-y for model_6xx_init.o. Otherwise booting (but not building) fails: Initializing CPU #0 CPU: vendor Intel device 665 CPU: family 06, model 06, stepping 05 Unknown cpu This patch was tested to fix the issue on MSI MS-6178. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Index: src/cpu/intel/model_6xx/Makefile.inc =================================================================== --- src/cpu/intel/model_6xx/Makefile.inc (Revision 4625) +++ src/cpu/intel/model_6xx/Makefile.inc (Arbeitskopie) @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -obj-y += model_6xx_init.o +driver-y += model_6xx_init.o