Patchwork Serial port 2 fix for Epia-Mii

login
register
about
Submitter Snoke
Date 2011-01-09 19:07:57
Message ID <4D2A078D.3070906@iki.fi>
Download mbox | patch
Permalink /patch/2497/
State New
Headers show

Comments

Snoke - 2011-01-09 19:07:57
Serial port 2 won't work on Epia-Mii.
Following patch I get it work.

Found solution at Linuxbios archive : [LinuxBIOS] EPIA M COM2 problem + 
possible solution? 
<http://www.coreboot.org/pipermail/coreboot/2006-February/013603.html>
Stefan Reinauer - 2011-01-19 07:10:07
* Snoke <snoke@iki.fi> [110109 20:07]:
> Serial port 2 won't work on Epia-Mii.
> Following patch I get it work.
> 
> Found solution at Linuxbios archive : [LinuxBIOS] EPIA M COM2 problem +
> possible solution?

> --- coreboot/src/superio/via/vt1211/vt1211.c	2011-01-09 16:05:47.000000000 +0200
> +++ coreboot_epia/src/superio/via/vt1211/vt1211.c	2011-01-09 19:49:53.000000000 +0200
> @@ -63,7 +63,7 @@
>  	case VT1211_PP:
>  	case VT1211_SP1:
>  	case VT1211_SP2:
> -		pnp_write_config(dev, index + 0, (iobase >> 2) & 0xff);
Are you sure this line should be deleted?

> +		pnp_write_config(dev, 0x27, 0x00); 

I think the case VT1211_SP2: should go extra:

case VT1211_SP1:
        pnp_write_config(dev, index + 0, (iobase >> 2) & 0xff);
        break;
case VT1211_SP2:
        pnp_write_config(dev, index + 0, (iobase >> 2) & 0xff);
        pnp_write_config(dev, 0x27, 0x00); // Serial Port 2 Multi Function Pin Select
        break;

Can you please try and see if this does the job?

Signed-off-by: Stefan Reinauer <stepan@coreboot.org>

>  		break;
>  	case VT1211_ROM:
>  		/* TODO: Error. VT1211_ROM doesn't have an I/O base. */

> -- 
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot

Patch

--- coreboot/src/superio/via/vt1211/vt1211.c	2011-01-09 16:05:47.000000000 +0200
+++ coreboot_epia/src/superio/via/vt1211/vt1211.c	2011-01-09 19:49:53.000000000 +0200
@@ -63,7 +63,7 @@ 
 	case VT1211_PP:
 	case VT1211_SP1:
 	case VT1211_SP2:
-		pnp_write_config(dev, index + 0, (iobase >> 2) & 0xff);
+		pnp_write_config(dev, 0x27, 0x00);
 		break;
 	case VT1211_ROM:
 		/* TODO: Error. VT1211_ROM doesn't have an I/O base. */