From patchwork Tue Jan 18 20:41:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Geode GX2 Kconfig framebuffer choice Date: Tue, 18 Jan 2011 20:41:08 -0000 From: Nils X-Patchwork-Id: 2533 Message-Id: <201101182141.08484.njacobs8@hetnet.nl> To: peter@stuge.se, coreboot@coreboot.org Add a GX2 Kconfig option to choose the framebuffer size. Signed-off-by: Nils Jacobs This patch is buid and boot tested. Hi Peter, You wrote: >> >> +config VIDEO_MB >> + int >> + default 8 >> + depends on NORTHBRIDGE_AMD_GX2 >> + > >Acked-by: Peter Stuge > >r6211 > >But only on the condition that you send a followup patch to change >this option into a choice in the user interface. Please see e.g. how >src/southbridge/via/k8t890/Kconfig implements this. Thanks! Is the attached patch what you had in mind? Thanks, Nils. Index: src/northbridge/amd/gx2/Kconfig =================================================================== --- src/northbridge/amd/gx2/Kconfig (revision 6270) +++ src/northbridge/amd/gx2/Kconfig (working copy) @@ -21,9 +21,40 @@ bool select GEODE_VSA +choice + prompt "Framebuffer size" + default GX2_VIDEO_MB_8MB + depends on NORTHBRIDGE_AMD_GX2 && VGA_BRIDGE_SETUP + +config GX2_VIDEO_MB_4MB + bool "4MB" +config GX2_VIDEO_MB_8MB + bool "8MB" +config GX2_VIDEO_MB_16MB + bool "16MB" +config GX2_VIDEO_MB_32MB + bool "32MB" +config GX2_VIDEO_MB_64MB + bool "64MB" +config GX2_VIDEO_MB_128MB + bool "128MB" +config GX2_VIDEO_MB_256MB + bool "256MB" +config GX2_VIDEO_MB_CMOS + bool "Use CMOS option" + +endchoice + config VIDEO_MB int - default 8 + default 4 if GX2_VIDEO_MB_4MB + default 8 if GX2_VIDEO_MB_8MB + default 16 if GX2_VIDEO_MB_16MB + default 32 if GX2_VIDEO_MB_32MB + default 64 if GX2_VIDEO_MB_64MB + default 128 if GX2_VIDEO_MB_128MB + default 256 if GX2_VIDEO_MB_256MB + default -1 if GX2_VIDEO_MB_CMOS depends on NORTHBRIDGE_AMD_GX2 # The GX2_PROCESSOR_MHZ options let you chose the correct GX2 processor