Patchwork nvramtool: Look at another place for the CMOS checksum specification

login
register
about
Submitter Patrick Georgi
Date 2011-01-20 13:31:38
Message ID <1295530298.10580.20.camel@linux-0a8x.site>
Download mbox | patch
Permalink /patch/2539/
State Accepted
Commit r6282
Headers show

Comments

Patrick Georgi - 2011-01-20 13:31:38
Hi,

This patch tells nvramtool about another place where it can find
information about the CMOS checksum location and range before it reverts
to its own default values.

Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
Stefan Reinauer - 2011-01-20 20:50:42
* Georgi, Patrick <Patrick.Georgi@secunet.com> [110120 14:31]:
> Hi,
> 
> This patch tells nvramtool about another place where it can find
> information about the CMOS checksum location and range before it reverts
> to its own default values.
> 
> Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>

Please add a comment that this is needed for parsing the cmos_layout.bin
file in cbfs.

Acked-by: Stefan Reinauer <stepan@coreboot.org>

Patch

Index: coreboot/util/nvramtool/lbtable.c

===================================================================
--- coreboot.orig/util/nvramtool/lbtable.c

+++ coreboot/util/nvramtool/lbtable.c

@@ -632,6 +632,10 @@  static void get_cmos_checksum_info(void)

 
 	checksum = (struct cmos_checksum *)find_lbrec(LB_TAG_OPTION_CHECKSUM);
 
+	if (checksum == NULL) {

+		checksum = (struct cmos_checksum *)next_cmos_rec((const struct lb_record *)first_cmos_table_enum(), LB_TAG_OPTION_CHECKSUM);

+	}

+

 	if (checksum != NULL) {	/* We are lucky.  The coreboot table hints us to the checksum.
 				 * We might have to check the type field here though.
 				 */