Patchwork Patch for coreboot_table.c

login
register
about
Submitter Joseph Kellermann
Date 2011-01-24 17:33:57
Message ID <ADF72474DB94FA47B566A9574D0ECA26038ABC9E@MX1.heitec.net>
Download mbox | patch
Permalink /patch/2552/
State Accepted
Headers show

Comments

Joseph Kellermann - 2011-01-24 17:33:57
This patch fixes an 'write_tables: coreboot table didn't fit (f0221)' issue.

Signed-off-by: Josef Kellermann <Joseph.Kellermann@heitec.de><mailto:Joseph.Kellermann@heitec.de>


**********************************************************************************************
IMPORTANT NOTICE / WICHTIGER HINWEIS
This communication contains information which is confidential and may also be privileged. It is for the 
exclusive use of the intended recipient(s). If you are not the intended recipient(s) please note that any 
distribution, copying or use of this communication or the information in it is strictly prohibited. If you have 
received this communication in error please notify us immediately by email or by telephone and then delete 
this email and any copies of it.
Diese E-Mail koennte vertrauliche und/oder rechtlich geschuetzte Informationen enthalten. Wenn Sie nicht 
der richtige Adressat sind oder diese E-Mail irrtuemlich erhalten haben, informieren Sie bitte sofort den 
Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser 
Mail sind nicht gestattet.

HEITEC AG, Werner-von-Siemens-Str. 61, 91052 Erlangen, HRB 7754, RG Fuerth, Vorstandsvorsitzender: 
Richard Heindl, Vorstand: Harald Preiml, Finanzvorstand: Rene-Oliver Rosner, Aufsichtsratsvorsitzender: Dr. 
Lorenz M. Raith, WWW: http://www.heitec.de
**********************************************************************************************
Stefan Reinauer - 2011-01-24 21:09:10
* Joseph Kellermann <Joseph.Kellermann@heitec.de> [110124 18:33]:
> This patch fixes an 'write_tables: coreboot table didn't fit (f0221)' issue.
> 
> Signed-off-by: Josef Kellermann <Joseph.Kellermann@heitec.de>

Thanks for spotting this error. Your fix went into the repository as
r6295.

Best regards,
Stefan Reinauer

Patch

Index: src/arch/x86/boot/coreboot_table.c
===================================================================
--- src/arch/x86/boot/coreboot_table.c	(Revision 6293)
+++ src/arch/x86/boot/coreboot_table.c	(Arbeitskopie)
@@ -547,7 +547,7 @@ 
 		if (option_table) {
 			struct lb_record *rec_dest = lb_new_record(head);
 			/* Copy the option config table, it's already a lb_record... */
-			memcpy(rec_dest,  &option_table, option_table->size);
+			memcpy(rec_dest, option_table, option_table->size);
 			/* Create cmos checksum entry in coreboot table */
 			lb_cmos_checksum(head);
 		} else {