| Submitter | Kevin O'Connor |
|---|---|
| Date | 2011-01-29 14:34:27 |
| Message ID | <20110129143427.GA19806@morn.localdomain> |
| Download | mbox | patch |
| Permalink | /patch/2582/ |
| State | Superseded |
| Headers | show |
Comments
Kevin O'Connor wrote: > SeaBIOS is moving to Kconfig. This will make it easier to configure > coreboot and seabios going forward. However, it will also break the > coreboot build in the short term. This patch, freezes the "master" > branch of coreboot's seabios checkout so users don't see build > failures. Can't we just quickly fix the build after Kconfig? //Peter
On Sat, Jan 29, 2011 at 03:38:25PM +0100, Peter Stuge wrote: > Kevin O'Connor wrote: > > SeaBIOS is moving to Kconfig. This will make it easier to configure > > coreboot and seabios going forward. However, it will also break the > > coreboot build in the short term. This patch, freezes the "master" > > branch of coreboot's seabios checkout so users don't see build > > failures. > > Can't we just quickly fix the build after Kconfig? Only if you're really, really quick. :-) I'm not really sure what the best way to interface to the new SeaBIOS build is. I suppose a .config could be copied in and "make oldconfig run". Freezing the master tag gives time to review an alternative system, but I'll leave it up to others if that is necessary or not. -Kevin
Kevin O'Connor wrote: > > > freezes the "master" branch of coreboot's seabios checkout > > > > Can't we just quickly fix the build after Kconfig? > > Only if you're really, really quick. :-) We could sync seabios push and coreboot commit. > I'm not really sure what the best way to interface to the new SeaBIOS > build is. I suppose a .config could be copied in and "make oldconfig > run". Maybe make defconfig + sed would be better? That way there will also be a complete config if SeaBIOS adds more Kconfig options. > Freezing the master tag gives time to review an alternative system, > but I'll leave it up to others if that is necessary or not. Let's fix it swiftly in parallell. IRC? //Peter
On 29.01.2011, at 06:34, Kevin O'Connor <kevin@koconnor.net> wrote: > SeaBIOS is moving to Kconfig. This will make it easier to configure > coreboot and seabios going forward. However, it will also break the > coreboot build in the short term. This patch, freezes the "master" > branch of coreboot's seabios checkout so users don't see build > failures. > > Signed-off-by: Kevin O'Connor <kevin@koconnor.net> > > -Kevin Hi Kevin Much appreciated! However I don't think this is needed at this point. Per default coreboot uses the stable checkout and well, the bleeding edge sometime bleeds :) Stefan > > > --- a/payloads/external/SeaBIOS/Makefile.inc > +++ b/payloads/external/SeaBIOS/Makefile.inc > @@ -1,6 +1,6 @@ > > > -TAG-$(CONFIG_SEABIOS_MASTER)=origin/master > +TAG-$(CONFIG_SEABIOS_MASTER)=4d0c592b138f394f96a99b6311a8ef48c24fb1c6 > TAG-$(CONFIG_SEABIOS_STABLE)=rel-0.6.1.3 > > all: seabios > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot >
Patch
--- a/payloads/external/SeaBIOS/Makefile.inc +++ b/payloads/external/SeaBIOS/Makefile.inc @@ -1,6 +1,6 @@ -TAG-$(CONFIG_SEABIOS_MASTER)=origin/master +TAG-$(CONFIG_SEABIOS_MASTER)=4d0c592b138f394f96a99b6311a8ef48c24fb1c6 TAG-$(CONFIG_SEABIOS_STABLE)=rel-0.6.1.3 all: seabios
SeaBIOS is moving to Kconfig. This will make it easier to configure coreboot and seabios going forward. However, it will also break the coreboot build in the short term. This patch, freezes the "master" branch of coreboot's seabios checkout so users don't see build failures. Signed-off-by: Kevin O'Connor <kevin@koconnor.net> -Kevin