Patchwork A couple of lost [PATCH]es

login
register
about
Submitter Alexandru Gagniuc
Date 2011-01-31 09:03:54
Message ID <AANLkTingKohG-Ghpk4aU6AnudQsAFjvLod0AzaMyhxM7@mail.gmail.com>
Download mbox | patch
Permalink /patch/2586/
State Accepted
Headers show

Comments

Alexandru Gagniuc - 2011-01-31 09:03:54
Hi,

There were a couple of patches flying around the last days, (which, I
have to admit, are of specific interest to me), which seem to have
died-off. I've never seen such an (IPDS) Instant Patch Death Syndrome
in other projects I contributed to, so perhaps my email was not being
delivered.

See patches for message/sign-off.

Alex
Add PCI ID's for VIA K8T800 and K8M800 northbridges.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Marc Jones - 2011-01-31 21:17:14
On Mon, Jan 31, 2011 at 2:03 AM, Alex G. <mr.nuke.me@gmail.com> wrote:
> Hi,
>
> There were a couple of patches flying around the last days, (which, I
> have to admit, are of specific interest to me), which seem to have
> died-off. I've never seen such an (IPDS) Instant Patch Death Syndrome
> in other projects I contributed to, so perhaps my email was not being
> delivered.
>
> See patches for message/sign-off.
>
> Alex

Acked-by: Marc Jones <marcj303@gmail.com>

Committed:
r6322
r6323

Patch

Fix an infinite loop in pnp_get_ioresource(), which freezes coreboot if
a rare condition arises.

Based on findings by Alexandru Gagniuc <mr.nuke.me@gmail.com>

Signed-off-by: Stefan Reinauer <reinauer@google.com>

Acked-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

diff --git a/src/devices/pnp_device.c b/src/devices/pnp_device.c
index b2bca03..4a6d266 100644
--- a/src/devices/pnp_device.c
+++ b/src/devices/pnp_device.c
@@ -170,6 +170,12 @@  static void pnp_get_ioresource(device_t dev, u8 index, struct io_info *info)
 	struct resource *resource;
 	unsigned moving, gran, step;
 
+	if (!info->mask) {
+		printk(BIOS_ERR, "ERROR: device %s index %d has no mask.\n",
+				dev_path(dev), index);
+		return;
+	}
+
 	resource = new_resource(dev, index);
 
 	/* Initilize the resource. */