Patchwork Fix abuild's config argument

login
register
about
Submitter Mathias Krause
Date 2011-02-01 10:18:36
Message ID <4D47DDFC.1000705@secunet.com>
Download mbox | patch
Permalink /patch/2590/
State Accepted
Commit r6324
Headers show

Comments

Mathias Krause - 2011-02-01 10:18:36
The undocumented config argument for the -t option implicitly assumes
the config file is within the mainboard directory but fails to honor
this assumption when it comes to copying the file.

Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Patrick Georgi - 2011-02-01 10:47:02
Am Dienstag, den 01.02.2011, 11:18 +0100 schrieb Mathias Krause:
> The undocumented config argument for the -t option implicitly assumes
> the config file is within the mainboard directory but fails to honor
> this assumption when it comes to copying the file.
Good catch. Thank you!

> Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Acked-by: Patrick Georgi <patrick.georgi@secunet.com>
and committed as r6324


Patrick

Patch

Index: util/abuild/abuild
===================================================================
--- util/abuild/abuild	(Revision 6323)
+++ util/abuild/abuild	(Arbeitskopie)
@@ -161,7 +161,7 @@ 
 	if [ "$CONFIG" != "" ]; then
 		printf "  Using existing configuration $CONFIG ... "
 		xml "  <config>$CONFIG</config>"
-		cp $CONFIG ${build_dir}/config.build
+		cp src/mainboard/$VENDOR/$MAINBOARD/$CONFIG ${build_dir}/config.build
 	else
 		printf "  Creating config file... "
 		xml "  <config>autogenerated</config>"