| Submitter | Sven Schnelle |
|---|---|
| Date | 2011-02-01 10:58:04 |
| Message ID | <87ei7snhs3.fsf@begreifnix.stackframe.org> |
| Download | mbox | patch |
| Permalink | /patch/2591/ |
| State | Superseded |
| Headers | show |
Comments
On 02/01/2011 12:58 PM, Sven Schnelle wrote: > Hi List, > > this patch adds the NSC PC87382 to superiotool. It is a rather small > 'superio' device, containing one Serial Port, one Infrared Port, GPIO > and a Docking LPC switch. It is used in various Thinkpads. > > It adds 0x164e/0x16ef to the list of probed port for NSC chipsets, as > Thinkpads are using this address pair. > > Signed-off-by: Sven Schnelle <svens@stackframe.org> > Acked-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Hi, On Tue, Feb 01, 2011 at 11:58:04AM +0100, Sven Schnelle wrote: > this patch adds the NSC PC87382 to superiotool. It is a rather small > 'superio' device, containing one Serial Port, one Infrared Port, GPIO > and a Docking LPC switch. It is used in various Thinkpads. > > It adds 0x164e/0x16ef to the list of probed port for NSC chipsets, as > Thinkpads are using this address pair. > > Signed-off-by: Sven Schnelle <svens@stackframe.org> Thanks, committed as r6327 with minor whitespace and consistency changes. > + {0xf4, "PC87382", { > + { NOLDN, NULL, > + { 0x20, 0x21, 0x22, 0x26, 0x27, 0x29, EOT }, > + { 0xf2, 0x11, 0x63, 0x00, 0x00, 0x00, EOT }}, I also changed the 0xf2 value for register 0x20 (chip ID) to 0xf4, that was probably a typo. Uwe.
Uwe Hermann <uwe@hermann-uwe.de> writes: > Thanks, committed as r6327 with minor whitespace and consistency > changes. > > >> + {0xf4, "PC87382", { >> + { NOLDN, NULL, >> + { 0x20, 0x21, 0x22, 0x26, 0x27, 0x29, EOT }, >> + { 0xf2, 0x11, 0x63, 0x00, 0x00, 0x00, EOT }}, > > I also changed the 0xf2 value for register 0x20 (chip ID) to 0xf4, that > was probably a typo. Yes, indeed a typo. Sorry. Thanks, Sven
Patch
diff --git a/util/superiotool/nsc.c b/util/superiotool/nsc.c index 982a01d..5909844 100644 --- a/util/superiotool/nsc.c +++ b/util/superiotool/nsc.c @@ -306,6 +306,23 @@ static const struct superio_registers reg_table[] = { {0x00,0x00,0x00,0x00,0x03,0x04,0x04,EOT}}, {EOT}}}, + {0xf4, "PC87382", { + { NOLDN, NULL, + { 0x20, 0x21, 0x22, 0x26, 0x27, 0x29, EOT }, + { 0xf2, 0x11, 0x63, 0x00, 0x00, 0x00, EOT }}, + { 0x02, "IR", + { 0x30, 0x60, 0x61, 0x70, 0x71, 0x74, 0x75, 0xf0, EOT}, + { 0x00, 0x02, 0xf8, 0x03, 0x03, 0x04, 0x04, 0x02, EOT}}, + { 0x03, "Serial Port SP1", + { 0x30, 0x60, 0x61, 0x70, 0x71, 0x74, 0x75, 0xf0, EOT}, + { 0x00, 0x03, 0xf8, 0x04, 0x03, 0x04, 0x04, 0x02, EOT}}, + { 0x07, "GPIO", + { 0x30, 0x60, 0x61, 0x70, 0x71, 0x74, 0x75, 0xf0, 0xf1, 0xf2, EOT}, + { 0x00, 0x00, 0x00, 0x00, 0x03, 0x04, 0x04, 0x00, 0x04, 0x01, EOT}}, + { 0X19, "Docking LPC Switch", + { 0x30, 0x60, 0x61, 0x70, 0x71, 0x74, 0x75, EOT}, + { 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x04, EOT}}, + {EOT}}}, /* SID[7..0]: family, SRID[7..5]: ID, SRID[4..0]: rev. */ {0xea, "PC8739x", { {NOLDN, NULL, diff --git a/util/superiotool/superiotool.h b/util/superiotool/superiotool.h index 479dba0..63dfebd 100644 --- a/util/superiotool/superiotool.h +++ b/util/superiotool/superiotool.h @@ -223,7 +223,7 @@ static const struct { {probe_idregs_fintek_alternative, {0x2e, 0x4e, EOT}}, /* Only use 0x370 for ITE, but 0x3f0 or 0x3bd would also be valid. */ {probe_idregs_ite, {0x25e, 0x2e, 0x4e, 0x370, EOT}}, - {probe_idregs_nsc, {0x2e, 0x4e, 0x15c, EOT}}, + {probe_idregs_nsc, {0x2e, 0x4e, 0x15c, 0x164e, EOT}}, /* I/O pairs on Nuvoton EC chips can be configured by firmware in * addition to the following hardware strapping options. */ {probe_idregs_nuvoton, {0x164e, 0x2e, EOT}},
Hi List, this patch adds the NSC PC87382 to superiotool. It is a rather small 'superio' device, containing one Serial Port, one Infrared Port, GPIO and a Docking LPC switch. It is used in various Thinkpads. It adds 0x164e/0x16ef to the list of probed port for NSC chipsets, as Thinkpads are using this address pair. Signed-off-by: Sven Schnelle <svens@stackframe.org>