Patchwork Add license headers for AMD family Fh

login
register
about
Submitter Alexandru Gagniuc
Date 2011-02-02 19:23:46
Message ID <4D49AF42.6060503@gmail.com>
Download mbox | patch
Permalink /patch/2602/
State Rejected
Headers show

Comments

Alexandru Gagniuc - 2011-02-02 19:23:46
See patch.

Alex
Stefan Reinauer - 2011-02-02 19:36:03
* Alex G. <mr.nuke.me@gmail.com> [110202 20:23]:
> Add GPL license headers to all files in src/cpu/amd/model_fxx
> (except microcode).
 
> Signed-off-by Alexandru Gagniuc <mr.nuke.me@gmail.com>
> Acked-by Alexandru Gagniuc <mr.nuke.me@gmail.com> Trivial

Not trivial at all, but legally kind of troublesome. Got to NACK this,
sorry.

> +# Copyright (C) The coreboot project

We can not accept generic copyright to the coreboot project, as it is
not a legal entity.

> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.

coreboot is GPLv2, not GPLv2+

Stefan
Alexandru Gagniuc - 2011-02-02 19:39:27
> Not trivial at all, but legally kind of troublesome. Got to NACK this,
> sorry.
> 
No problem


> coreboot is GPLv2, not GPLv2+
> 

http://www.coreboot.org/Development_Guidelines says GPLv2+.
So which is the correct license?

Alex
Patrick Georgi - 2011-02-02 19:50:47
Am 02.02.2011 20:39, schrieb Alex G.:
>> coreboot is GPLv2, not GPLv2+
> http://www.coreboot.org/Development_Guidelines says GPLv2+.
> So which is the correct license?
We have some GPLv2 and some GPLv2+ files, so the combined work is GPLv2.
As for the files that you added licensing information to, the licensing
is really a matter of the authors.
The only license we can safely apply is the GPLv2.


Patrick
Alexandru Gagniuc - 2011-02-02 19:51:52
On 02/02/2011 09:50 PM, Patrick Georgi wrote:
> Am 02.02.2011 20:39, schrieb Alex G.:
>>> coreboot is GPLv2, not GPLv2+
>> http://www.coreboot.org/Development_Guidelines says GPLv2+.
>> So which is the correct license?
> We have some GPLv2 and some GPLv2+ files, so the combined work is GPLv2.
> As for the files that you added licensing information to, the licensing
> is really a matter of the authors.
> The only license we can safely apply is the GPLv2.
> 
Thanks! That sheds some light on the matter. :)

Alex

Patch

Add GPL license headers to all files in src/cpu/amd/model_fxx
(except microcode).

Signed-off-by Alexandru Gagniuc <mr.nuke.me@gmail.com>
Acked-by Alexandru Gagniuc <mr.nuke.me@gmail.com> Trivial

Index: src/cpu/amd/model_fxx/Kconfig
===================================================================
--- src/cpu/amd/model_fxx/Kconfig	(revision 6323)
+++ src/cpu/amd/model_fxx/Kconfig	(working copy)
@@ -1,3 +1,23 @@ 
+#
+# This file is part of the coreboot project.
+#
+# Copyright (C) The coreboot project
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+#
+
 config CPU_AMD_MODEL_FXX
 	bool
 	select MMX
Index: src/cpu/amd/model_fxx/Makefile.inc
===================================================================
--- src/cpu/amd/model_fxx/Makefile.inc	(revision 6323)
+++ src/cpu/amd/model_fxx/Makefile.inc	(working copy)
@@ -1,3 +1,23 @@ 
+#
+# This file is part of the coreboot project.
+#
+# Copyright (C) The coreboot project
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+#
+
 # no conditionals here. If you include this file from a socket, then you get all the binaries.
 driver-y += model_fxx_init.c
 ramstage-y += apic_timer.c
Index: src/cpu/amd/model_fxx/fidvid.c
===================================================================
--- src/cpu/amd/model_fxx/fidvid.c	(revision 6323)
+++ src/cpu/amd/model_fxx/fidvid.c	(working copy)
@@ -1,3 +1,22 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) The coreboot project
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
 #if CONFIG_SET_FIDVID
 
 #ifndef SB_VFSMAF
Index: src/cpu/amd/model_fxx/model_fxx_init.c
===================================================================
--- src/cpu/amd/model_fxx/model_fxx_init.c	(revision 6323)
+++ src/cpu/amd/model_fxx/model_fxx_init.c	(working copy)
@@ -1,3 +1,23 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2005 Advanced Micro Devices, Inc.
+ *     Written by yhlu for Advanced Micro Devices, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
 /* Needed so the AMD K8 runs correctly.  */
 /* this should be done by Eric
  * 2004.11 yhlu add d0 e0 support
Index: src/cpu/amd/model_fxx/apic_timer.c
===================================================================
--- src/cpu/amd/model_fxx/apic_timer.c	(revision 6323)
+++ src/cpu/amd/model_fxx/apic_timer.c	(working copy)
@@ -1,3 +1,22 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) The coreboot project
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
 #include <stdint.h>
 #include <delay.h>
 #include <cpu/x86/msr.h>
Index: src/cpu/amd/model_fxx/init_cpus.c
===================================================================
--- src/cpu/amd/model_fxx/init_cpus.c	(revision 6323)
+++ src/cpu/amd/model_fxx/init_cpus.c	(working copy)
@@ -1,3 +1,22 @@ 
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) The coreboot project
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
 #if CONFIG_HAVE_OPTION_TABLE
 #include "option_table.h"
 #endif