Patchwork Fix issue with Winbond W83627EHG MIDI driver

login
register
about
Submitter Alexandru Gagniuc
Date 2011-02-08 01:48:44
Message ID <4D50A0FC.3090108@gmail.com>
Download mbox | patch
Permalink /patch/2617/
State Accepted
Commit r6336
Headers show

Comments

Alexandru Gagniuc - 2011-02-08 01:48:44
>> Index: src/superio/winbond/w83627ehg/superio.c
>> ===================================================================
>> --- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
>> +++ src/superio/winbond/w83627ehg/superio.c	(working copy)
>> @@ -189,7 +189,7 @@
>>  	{ &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
>>  
>>  	{ &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
>> -	{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
>> +	{ &ops, W83627EHG_MIDI, PNP_IO0 | PNP_IRQ0, {0x07fe, 4}, },
>>  	{ &ops, W83627EHG_GPIO1, },
>>  	{ &ops, W83627EHG_GPIO2, },
>>  	{ &ops, W83627EHG_GPIO3, },
> 
> I don't think this is the right fix.
> The datasheet says the MIDI BAR is at 62h, 63h.
> Hence the mask needs to be in the second position, not the first.
> 
> Maybe try something like: 
> { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }
> 
> 	Jonathan Kollasch

Thanks. Find attached the updated micropatch.

Alex
Jonathan A. Kollasch - 2011-02-08 02:29:47
On Tue, Feb 08, 2011 at 03:48:44AM +0200, Alex G. wrote:
> > Maybe try something like: 
> > { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }
> > 
> > 	Jonathan Kollasch
> 
> Thanks. Find attached the updated micropatch.
> 
> Alex

> Fixes a problem with the W8327EHG driver, where the midi device
> could get initialised with no mask.
> 
> Based on input from Jonathan Kollasch <jakllsch@kollasch.net>
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> 
> 
> Index: src/superio/winbond/w83627ehg/superio.c
> ===================================================================
> --- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
> +++ src/superio/winbond/w83627ehg/superio.c	(working copy)
> @@ -189,7 +189,7 @@
>  	{ &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
>  
>  	{ &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
> -	{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
> +	{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, },
>  	{ &ops, W83627EHG_GPIO1, },
>  	{ &ops, W83627EHG_GPIO2, },
>  	{ &ops, W83627EHG_GPIO3, },

Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
Jonathan A. Kollasch - 2011-02-08 02:37:41
On Tue, Feb 08, 2011 at 02:29:47AM +0000, Jonathan A. Kollasch wrote:
> On Tue, Feb 08, 2011 at 03:48:44AM +0200, Alex G. wrote:
> > > Maybe try something like: 
> > > { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }
> > > 
> > > 	Jonathan Kollasch
> > 
> > Thanks. Find attached the updated micropatch.
> > 
> > Alex
> 
> > Fixes a problem with the W8327EHG driver, where the midi device
> > could get initialised with no mask.
> > 
> > Based on input from Jonathan Kollasch <jakllsch@kollasch.net>
> > 
> > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> > 
> > 
> > Index: src/superio/winbond/w83627ehg/superio.c
> > ===================================================================
> > --- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
> > +++ src/superio/winbond/w83627ehg/superio.c	(working copy)
> > @@ -189,7 +189,7 @@
> >  	{ &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
> >  
> >  	{ &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
> > -	{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
> > +	{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, },
> >  	{ &ops, W83627EHG_GPIO1, },
> >  	{ &ops, W83627EHG_GPIO2, },
> >  	{ &ops, W83627EHG_GPIO3, },
> 
> Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
 
Committed in r6336.

Patch

Fixes a problem with the W8327EHG driver, where the midi device
could get initialised with no mask.

Based on input from Jonathan Kollasch <jakllsch@kollasch.net>

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>


Index: src/superio/winbond/w83627ehg/superio.c
===================================================================
--- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
+++ src/superio/winbond/w83627ehg/superio.c	(working copy)
@@ -189,7 +189,7 @@ 
 	{ &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
 
 	{ &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
-	{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
+	{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, },
 	{ &ops, W83627EHG_GPIO1, },
 	{ &ops, W83627EHG_GPIO2, },
 	{ &ops, W83627EHG_GPIO3, },