Patchwork Move VGA BIOS settings from payload menu into a menu of it's own

login
register
about
Submitter Peter Stuge
Date 2009-09-17 08:02:12
Message ID <20090917080212.12049.qmail@stuge.se>
Download mbox | patch
Permalink /patch/264/
State Accepted
Headers show

Comments

Peter Stuge - 2009-09-17 08:02:12
Peter Stuge wrote:
> Patch attached.

Revised patch attached. This time actually remove the dependency on
PAYLOAD_ELF. Oops.


//Peter
Move VGA BIOS settings from payload menu into it's own menu

Remove dependency on PAYLOAD_ELF to actually show these config items.
Build tested. With this, coreboot.rom has a VGA BIOS optionrom added.

Signed-off-by: Peter Stuge <peter@stuge.se>
Patrick Georgi - 2009-09-17 14:54:10
Am Donnerstag, den 17.09.2009, 10:02 +0200 schrieb Peter Stuge:
> Peter Stuge wrote:
> > Patch attached.
> 
> Revised patch attached. This time actually remove the dependency on
> PAYLOAD_ELF. Oops.
Thanks,

Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>


Patrick
Peter Stuge - 2009-09-17 16:21:44
Patrick Georgi wrote:
> > Revised patch attached. This time actually remove the dependency on
> > PAYLOAD_ELF. Oops.
> 
> Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>

Thanks, r4642.


//Peter
Stefan Reinauer - 2009-09-17 19:51:10
Peter Stuge wrote:
> Peter Stuge wrote:
>   
>> Patch attached.
>>     
>
> Revised patch attached. This time actually remove the dependency on
> PAYLOAD_ELF. Oops.
>
>
> //Peter
>   
Should the menu maybe be called "Option ROMs" or some such?

Acked-by: Stefan Reinauer <stepan@coresystems.de>

Patch

Index: src/Kconfig
===================================================================
--- src/Kconfig	(revision 4640)
+++ src/Kconfig	(working copy)
@@ -238,17 +238,6 @@ 
 
 	  You will be able to specify the location and file name of the
 	  payload image later.
-
-config VGA_BIOS
-	bool "Add a VGA BIOS image"
-	depends on PAYLOAD_ELF
-	help
-	  Select this option if you have a VGA BIOS image that you would
-	  like to add to your ROM.
-
-	  You will be able to specify the location and file name of the
-	  image later.
-
 config PAYLOAD_NONE
 	bool "No payload"
 	help
@@ -268,6 +257,19 @@ 
 	help
 	  The path and filename of the ELF executable file to use as payload.
 
+endmenu
+
+menu "VGA BIOS"
+
+config VGA_BIOS
+	bool "Add a VGA BIOS image"
+	help
+	  Select this option if you have a VGA BIOS image that you would
+	  like to add to your ROM.
+
+	  You will be able to specify the location and file name of the
+	  image later.
+
 config FALLBACK_VGA_BIOS_FILE
 	string "VGA BIOS path and filename"
 	depends on VGA_BIOS