Patchwork Fam10 FIDVID in SVI 05/25

login
register
about
Submitter xdrudis
Date 2011-02-17 06:37:53
Message ID <20110217063753.GI8966@ideafix.casa.ct>
Download mbox | patch
Permalink /patch/2652/
State Accepted
Headers show

Comments

xdrudis - 2011-02-17 06:37:53
see patch
Marc Jones - 2011-02-27 23:53:46
On Wed, Feb 16, 2011 at 11:37 PM, xdrudis <xdrudis@tinet.cat> wrote:
> see patch
>
Acked-by: Marc Jones <marcj303@gmail.com>

r6391

Patch

Prepare for next patches (Improving BKDG implementation of P-states,
CPU and northbridge frequency and voltage
handling for Fam 10 in SVI mode). 

No change of behaviour intended.

Refactor FAM10 fidvid . prep_fid_change was already long and it'd 
get longer with forthcoming patches. We now take apart F3x[84:80],
ACPI Power State Control Registers, to its own function. 

Signed-off-by: Xavi Drudis Ferran <xdrudis@tinet.cat>

--- src/cpu/amd/model_10xxx/fidvid.c	2011-02-16 20:51:55.000000000 +0100
+++ src/cpu/amd/model_10xxx/fidvid.c	2011-02-16 20:51:55.000000000 +0100
@@ -257,7 +257,6 @@  static void config_power_ctrl_misc_reg(d
 		pci_write_config32(dev, 0xD8, dword);
 	}
 }
-
             
 static void config_nb_syn_ptr_adj(device_t dev) {
 	/* Note the following settings are additional from the ported
@@ -269,6 +268,14 @@  static void config_nb_syn_ptr_adj(device
 
 }
 
+static void config_acpi_pwr_state_ctrl_regs(device_t dev) {
+	/* Rev B settings - FIXME: support other revs. */
+	u32 dword = 0xA0E641E6;
+	pci_write_config32(dev, 0x84, dword);
+	dword = 0xE600A681;
+	pci_write_config32(dev, 0x80, dword);
+}
+
 static void prep_fid_change(void)
 {
         u32 dword;
@@ -295,12 +302,7 @@  static void prep_fid_change(void)
 
  		config_nb_syn_ptr_adj(dev);
 
-		/* Rev B settings - FIXME: support other revs. */
-		dword = 0xA0E641E6;
-		pci_write_config32(dev, 0x84, dword);
-
-		dword = 0xE600A681;
-		pci_write_config32(dev, 0x80, dword);
+                config_acpi_pwr_state_ctrl_regs(dev);
 
 		dword = pci_read_config32(dev, 0x80);
 		printk(BIOS_DEBUG, "  F3x80: %08x \n", dword);