Patchwork Fam10 FIDVID in SVI 22/25

login
register
about
Submitter xdrudis
Date 2011-02-17 06:45:35
Message ID <20110217064535.GZ8966@ideafix.casa.ct>
Download mbox | patch
Permalink /patch/2669/
State Accepted
Commit r6409
Headers show

Comments

xdrudis - 2011-02-17 06:45:35
see patch
Marc Jones - 2011-02-28 03:54:01
On Wed, Feb 16, 2011 at 11:45 PM, xdrudis <xdrudis@tinet.cat> wrote:
> see patch
>

Acked-by: Marc Jones <marcj303@gmail.com>

r6409

Patch

Improving BKDG implementation of P-states,
CPU and northbridge frequency and voltage
handling for Fam 10 in SVI mode. 

I don't understand what this was doing nor find docs for these regs
Maybe it was left over from some copy & paste ? 

Signed-off-by: Xavi Drudis Ferran <xdrudis@tinet.cat>

--- src/cpu/amd/model_10xxx/fidvid.c	2011-02-16 00:51:36.000000000 +0100
+++ src/cpu/amd/model_10xxx/fidvid.c	2011-02-16 01:08:16.000000000 +0100
@@ -394,19 +394,6 @@ 
 	} else {	/* SVI */
 		/* set slamVidMode to 1 for SVI */
 		dword |= VID_SLAM_ON;
-
-		u32 dtemp = dword;
-
-		/* Program F3xD8[PwrPlanes] according F3xA0[DulaVdd]  */
-		dword = pci_read_config32(dev, 0xD8);
-
-		if (dtemp & DUAL_VDD_BIT)
-			dword |= PWR_PLN_ON;
-		else
-			dword &= PWR_PLN_OFF;
-		pci_write_config32(dev, 0xD8, dword);
-
-                dword = dtemp;
         }
         /* set the rest of A0 since we're at it... */