Patchwork [2/5] libpayload: Some more standard types and defines

login
register
about
Submitter Patrick Georgi
Date 2011-02-25 12:02:22
Message ID <1298640300.2470.14.camel@linux-0a8x.site>
Download mbox | patch
Permalink /patch/2698/
State Accepted
Commit r6414
Headers show

Comments

Patrick Georgi - 2011-02-25 12:02:22
Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
---
 payloads/libpayload/include/limits.h |    2 ++
 payloads/libpayload/include/stdint.h |    5 +++++
 2 files changed, 7 insertions(+), 0 deletions(-)
Stefan Reinauer - 2011-02-25 20:36:30
* Patrick Georgi <Patrick.Georgi@secunet.com> [110225 13:02]:
> Signed-off-by: Patrick Georgi <patrick.georgi@secunet.com>
> ---
>  payloads/libpayload/include/limits.h |    2 ++
>  payloads/libpayload/include/stdint.h |    5 +++++
>  2 files changed, 7 insertions(+), 0 deletions(-)

Acked-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Peter Stuge - 2011-02-25 20:45:46
Patrick Georgi wrote:
> +++ b/payloads/libpayload/include/stdint.h
> @@ -27,4 +27,9 @@
>   * SUCH DAMAGE.
>   */
>  
> +#ifndef __STDINT_H
> +#define __STDINT_H
>  #include <arch/types.h>
> +
> +typedef unsigned long uintptr_t;
> +#endif

What about 64 bit? Or libpayload simply doesn't support it? In that
case

Acked-by: Peter Stuge <peter@stuge.se>
Stefan Reinauer - 2011-02-25 21:12:06
* Peter Stuge <peter@stuge.se> [110225 21:45]:
> Patrick Georgi wrote:
> > +++ b/payloads/libpayload/include/stdint.h
> > @@ -27,4 +27,9 @@
> >   * SUCH DAMAGE.
> >   */
> >  
> > +#ifndef __STDINT_H
> > +#define __STDINT_H
> >  #include <arch/types.h>
> > +
> > +typedef unsigned long uintptr_t;
> > +#endif
> 
> What about 64 bit? Or libpayload simply doesn't support it? In that
> case
> 
> Acked-by: Peter Stuge <peter@stuge.se>
 
unsigned long is 64bit on 64bit gccs

Patch

diff --git a/payloads/libpayload/include/limits.h b/payloads/libpayload/include/limits.h
index ae71dfd..be7dde0 100644
--- a/payloads/libpayload/include/limits.h
+++ b/payloads/libpayload/include/limits.h
@@ -40,4 +40,6 @@ 
 # endif
 #endif
 
+#define UINT_MAX (unsigned int)0xffffffff
+
 #endif
diff --git a/payloads/libpayload/include/stdint.h b/payloads/libpayload/include/stdint.h
index ae143d7..8e5083e 100644
--- a/payloads/libpayload/include/stdint.h
+++ b/payloads/libpayload/include/stdint.h
@@ -27,4 +27,9 @@ 
  * SUCH DAMAGE.
  */
 
+#ifndef __STDINT_H
+#define __STDINT_H
 #include <arch/types.h>
+
+typedef unsigned long uintptr_t;
+#endif