Patchwork Kino serial was being disabled in PNP init.

login
register
about
Submitter Marc Jones
Date 2011-02-27 23:19:51
Message ID <AANLkTikf8ds2j863_RdsX6yVD-j1BGcQyNFWDcvd7LCR@mail.gmail.com>
Download mbox | patch
Permalink /patch/2711/
State Accepted
Commit r6400
Headers show

Comments

Marc Jones - 2011-02-27 23:19:51
Kino devicetree.cb SIO PNP  devices were not matched up with the
actual SIO. This fixes the serial device  being disabled during PNP
init.

Signed-off-by: Marc Jones <marcj303@gmail.com>
Scott - 2011-02-28 01:26:12
Marc Jones wrote:

]Kino devicetree.cb SIO PNP  devices were not matched up with the
]actual SIO. This fixes the serial device  being disabled during PNP
]init.
]
]Signed-off-by: Marc Jones <marcj303@gmail.com>
]
]-- 
]http://se-eng.com


Acked-by: Scott Duplichan <scott@notabs.org>

Thanks,
Scott
Marc Jones - 2011-02-28 02:36:42
On Sun, Feb 27, 2011 at 6:26 PM, Scott Duplichan <scott@notabs.org> wrote:
> Marc Jones wrote:
>
> ]Kino devicetree.cb SIO PNP  devices were not matched up with the
> ]actual SIO. This fixes the serial device  being disabled during PNP
> ]init.
> ]
> ]Signed-off-by: Marc Jones <marcj303@gmail.com>
> ]
> ]--
> ]http://se-eng.com
>
>
> Acked-by: Scott Duplichan <scott@notabs.org>

Thanks!

r6400

Patch

Kino devicetree.cb SIO PNP  devices were not matched up with the actual SIO. This fixes the serial device  being disabled during PNP init. 

Signed-off-by: Marc Jones <marcj303@gmail.com>


Index: coreboot/src/mainboard/iei/kino-780am2-fam10/devicetree.cb
===================================================================
--- coreboot.orig/src/mainboard/iei/kino-780am2-fam10/devicetree.cb	2011-02-27 15:58:57.261550993 -0700
+++ coreboot/src/mainboard/iei/kino-780am2-fam10/devicetree.cb	2011-02-27 16:08:12.901550993 -0700
@@ -51,32 +51,10 @@ 
 					device pci 14.2 on end # HDA    0x4383
 					device pci 14.3 on # LPC	0x439d
 						chip superio/fintek/f71859
-							device pnp 2e.0 off #  Floppy
-								io 0x60 = 0x3f0
-								irq 0x70 = 6
-								drq 0x74 = 2
-							end
-							device pnp 2e.1 on #  Com1
+							device pnp 2e.3 on #  Com1
 								io 0x60 = 0x3f8
 								irq 0x70 = 4
 							end
-							device pnp 2e.2 off #  Com2
-								io 0x60 = 0x2f8
-								irq 0x70 = 3
-							end
-							device pnp 2e.3 off #  Parallel Port
-								io 0x60 = 0x378
-								irq 0x70 = 7
-							end
-							device pnp 2e.4 off end #  EC
-							device pnp 2e.5 on #  Keyboard
-								io 0x60 = 0x60
-								io 0x62 = 0x64
-								irq 0x70 = 1
-							end
-							device pnp 2e.6 on #  Mouse
-								irq 0x70 = 12
-							end
 						end		#SIO
 					end		#LPC
 					device pci 14.4 on end # PCI 0x4384