Patchwork Add mainboards to print.c and mark writing as tested on Winbond W25x80

login
register
about
Submitter Yul Rottmann
Date 2011-02-28 18:28:56
Message ID <1298917736.19811.14.camel@yul.local>
Download mbox | patch
Permalink /patch/2713/
State Accepted
Commit r1264
Headers show

Comments

Yul Rottmann - 2011-02-28 18:28:56
Hello List, 
I successfully tested flashrom on my MSI MS-7596 (785GM-E51). Here is
the patch to add it to the list of supported mainboards. Also I marked
writing as tested on the flashchip that belongs to it.

Earlier I reported the success of flashing my GIGABYTE GA-MA78G-DS3H.
This patch makes clear that it is about the revision 1.0.

I also tested flashing an ASRock 890GX Extreme3, which worked. I also
added it to print.c.

If you have questions, please contact me on my private e-mail adress
since I haven't subscribed to the mailinglist. 
Thanks!

Signed-off-by: Yul Rottmann <yulrottmann@bitel.net>
Carl-Daniel Hailfinger - 2011-03-05 16:33:17
Hi Yul,

thanks for your patch!

Auf 28.02.2011 19:28, Yul Rottmann schrieb:
> I successfully tested flashrom on my MSI MS-7596 (785GM-E51). Here is
> the patch to add it to the list of supported mainboards. Also I marked
> writing as tested on the flashchip that belongs to it.
>
> Earlier I reported the success of flashing my GIGABYTE GA-MA78G-DS3H.
> This patch makes clear that it is about the revision 1.0.
>
> I also tested flashing an ASRock 890GX Extreme3, which worked. I also
> added it to print.c.
>
> If you have questions, please contact me on my private e-mail adress
> since I haven't subscribed to the mailinglist. 
> Thanks!
>
> Signed-off-by: Yul Rottmann <yulrottmann@bitel.net>
>   

I'm sorry I didn't get around to applying your patch earlier.
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
and committed in r1264.

Regards,
Carl-Daniel

Patch

Index: flashchips.c
===================================================================
--- flashchips.c	(Revision 1262)
+++ flashchips.c	(Arbeitskopie)
@@ -7597,7 +7597,7 @@ 
 		.total_size	= 1024,
 		.page_size	= 256,
 		.feature_bits	= FEATURE_WRSR_WREN,
-		.tested		= TEST_OK_PRE,
+		.tested		= TEST_OK_PREW,
 		.probe		= probe_spi_rdid,
 		.probe_timing	= TIMING_ZERO,
 		.block_erasers	=
Index: print.c
===================================================================
--- print.c	(Revision 1262)
+++ print.c	(Arbeitskopie)
@@ -358,6 +358,7 @@ 
 	B("Artec Group","DBE62",		1, "http://wiki.thincan.org/DBE62", NULL),
 	B("ASI",	"MB-5BLMP",		1, "http://www.hojerteknik.com/winnet.htm", "Used in the IGEL WinNET III thin client."),
 	B("ASRock",	"775i65G",		1, "http://www.asrock.com/mb/overview.asp?Model=775i65G", NULL),
+	B("ASRock",	"890GX Extreme3",	1, "http://www.asrock.com/mb/overview.asp?Model=890GX%20Extreme3", NULL),
 	B("ASRock",	"939A785GMH/128M",	1, "http://www.asrock.com/mb/overview.asp?Model=939A785GMH/128M&s=939", NULL),
 	B("ASRock",	"A330GC",		1, "http://www.asrock.com/mb/overview.asp?Model=A330GC", NULL),
 	B("ASRock",	"A770CrossFire",	1, "http://www.asrock.com/mb/overview.asp?Model=A770CrossFire&s=AM2%%2b", NULL),
@@ -487,7 +488,7 @@ 
 	B("GIGABYTE",	"GA-MA69VM-S2",		1, "http://www.gigabyte.com/products/product-page.aspx?pid=2500", NULL),
 	B("GIGABYTE",	"GA-MA74GM-S2H (rev. 3.0)", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=3152", NULL),
 	B("GIGABYTE",	"GA-MA770T-UD3P",	1, "http://www.gigabyte.com/products/product-page.aspx?pid=3096", NULL),
-	B("GIGABYTE",	"GA-MA78G-DS3H",	1, "http://www.gigabyte.com/products/product-page.aspx?pid=2800", NULL), /* TODO: Rev 1.x or 2.x? */
+	B("GIGABYTE",	"GA-MA78G-DS3H (rev. 1.0)", 1, "http://www.gigabyte.com/products/product-page.aspx?pid=2800", NULL),
 	B("GIGABYTE",	"GA-MA78GM-S2H",	1, "http://www.gigabyte.com/products/product-page.aspx?pid=2758", NULL), /* TODO: Rev. 1.0, 1.1, or 2.x? */
 	B("GIGABYTE",	"GA-MA78GPM-DS2H",	1, "http://www.gigabyte.com/products/product-page.aspx?pid=2859", NULL),
 	B("GIGABYTE",	"GA-MA790FX-DQ6",	1, "http://www.gigabyte.com/products/product-page.aspx?pid=2690", NULL),
@@ -541,6 +542,7 @@ 
 	B("MSI",	"MS-7345 (P35 Neo2-FIR)", 1, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=1261", NULL),
 	B("MSI",	"MS-7368 (K9AG Neo2-Digital)", 1, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=1241", NULL),
 	B("MSI",	"MS-7376 (K9A2 Platinum)", 1, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=1332", NULL),
+	B("MSI",	"MS-7596 (785GM-E51)",  1, "http://eu.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=1866", NULL),
 	B("MSI",	"MS-7642 (890GXM-G65)",	1, "http://www.msi.com/index.php?func=proddesc&maincat_no=1&prod_no=2012", NULL),
 	B("NEC",	"PowerMate 2000",	1, "http://support.necam.com/mobilesolutions/hardware/Desktops/pm2000/celeron/", NULL),
 	B("Nokia",	"IP530",		1, NULL, NULL),