Patchwork buildrom/filo build fix

login
register
about
Submitter Daniel Mack
Date 2009-09-23 01:54:13
Message ID <20090923015413.GC9361@buzzloop.caiaq.de>
Download mbox | patch
Permalink /patch/279/
State Not Applicable
Headers show

Comments

Daniel Mack - 2009-09-23 01:54:13
buildrom does not currently build filo due to a missing include path.
This fixes it.

---
Myles Watson - 2009-09-23 03:09:32
> buildrom does not currently build filo due to a missing include path.

> --- Makefile	(revision 94)
I just bumped the revision in buildrom to 105.  I'd been using 104
successfully, and 105 still builds, so I bumped it to 105.  Hopefully you
can build and use filo without changing it now.

Thanks,
Myles
Stefan Reinauer - 2009-09-23 09:43:02
Daniel Mack wrote:
> buildrom does not currently build filo due to a missing include path.
> This fixes it.
>
> ---
>
> Index: Makefile
> ===================================================================
> --- Makefile	(revision 94)
> +++ Makefile	(working copy)
> @@ -76,7 +76,7 @@
>  LIBGCC = $(shell $(CC) $(CFLAGS) -print-libgcc-file-name)
>  
>  OBJS     := $(patsubst %,$(obj)/%,$(TARGETS-y))
> -INCLUDES := -I$(INCPAYLOAD) -Iinclude -I$(ARCHDIR-y)/include -Ibuild
> +INCLUDES := -I$(INCPAYLOAD) -I$(INCPAYLOAD)/$(ARCHDIR-y) -Iinclude -I$(ARCHDIR-y)/include -Ibuild
>  INCLUDES += -I$(GCCINCDIR)
>  
>  try-run= $(shell set -e; \
>
>   
What's your error without this? Is that a patch against FILO?

Stefan
Daniel Mack - 2009-09-23 09:54:32
On Wed, Sep 23, 2009 at 11:43:02AM +0200, Stefan Reinauer wrote:
> Daniel Mack wrote:
> > buildrom does not currently build filo due to a missing include path.
> > This fixes it.
> >
> > ---
> >
> > Index: Makefile
> > ===================================================================
> > --- Makefile	(revision 94)
> > +++ Makefile	(working copy)
> > @@ -76,7 +76,7 @@
> >  LIBGCC = $(shell $(CC) $(CFLAGS) -print-libgcc-file-name)
> >  
> >  OBJS     := $(patsubst %,$(obj)/%,$(TARGETS-y))
> > -INCLUDES := -I$(INCPAYLOAD) -Iinclude -I$(ARCHDIR-y)/include -Ibuild
> > +INCLUDES := -I$(INCPAYLOAD) -I$(INCPAYLOAD)/$(ARCHDIR-y) -Iinclude -I$(ARCHDIR-y)/include -Ibuild
> >  INCLUDES += -I$(GCCINCDIR)
> >  
> >  try-run= $(shell set -e; \
> >
> >   
> What's your error without this? Is that a patch against FILO?

It couldn't find arch specific includes. But it was all due to an old
version of filo - the fix went in upstream with r98.
Buildrom uses r104 now, so it's all fine.

Sorry for the noise.

Daniel

Patch

Index: Makefile
===================================================================
--- Makefile	(revision 94)
+++ Makefile	(working copy)
@@ -76,7 +76,7 @@ 
 LIBGCC = $(shell $(CC) $(CFLAGS) -print-libgcc-file-name)
 
 OBJS     := $(patsubst %,$(obj)/%,$(TARGETS-y))
-INCLUDES := -I$(INCPAYLOAD) -Iinclude -I$(ARCHDIR-y)/include -Ibuild
+INCLUDES := -I$(INCPAYLOAD) -I$(INCPAYLOAD)/$(ARCHDIR-y) -Iinclude -I$(ARCHDIR-y)/include -Ibuild
 INCLUDES += -I$(GCCINCDIR)
 
 try-run= $(shell set -e; \