| Submitter | Karl-Heinz Nirschl |
|---|---|
| Date | 2011-03-16 19:44:06 |
| Message ID | <AANLkTik6U6SfEdoARSk2QNDULoO52YGjRqUOj-fJYZ2N@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/2796/ |
| State | New |
| Headers | show |
Comments
This solves the problem, thanks Karl! Anish On 03/16/11 15:44, Karl-Heinz Nirschl wrote: > Hi, > i think the following patch should do the trick: > > > --- > Index: src/southbridge/intel/sch/Makefile.inc > =================================================================== > --- src/southbridge/intel/sch/Makefile.inc (Revision 6439) > +++ src/southbridge/intel/sch/Makefile.inc (Arbeitskopie) > @@ -37,6 +37,6 @@ > > # We don't ship that, but booting without it is bound to fail > cbfs-files-$(CONFIG_HAVE_CMC) += cmc.bin > -cmc.bin-file := $(CONFIG_CMC_FILE) > +cmc.bin-file := $(call strip_quotes,$(CONFIG_CMC_FILE)) > cmc.bin-type := 0xaa > cmc.bin-position := 0xfffd0000 > --- > > > best regards, > > > > > 2011/3/15 Stefan Reinauer<stefan.reinauer@coreboot.org>: >> * Anish Patel<anish.mailing.list@gmail.com> [110314 20:42]: >>> On 03/14/11 15:19, Anish Patel wrote: >>>> Hi All, >>>> I am trying to get coreboot running on my PC/104+ atom board. >>>> I think i have everything pretty much good to go, except for one >>>> problem. >>>> When i try to build, it says it can't find my cmc.bin file, which >>>> i have extracted from the factory bios and placed in many >>>> different locations inside the coreboot build tree. As well as >>>> tell coreboot the location of the cmc.bin file, yet everytime i >>>> build i get this error. >>>> >>>> >>>> GEN bootblock/ldscript.ld >>>> LINK bootblock.elf >>>> OBJCOPY coreboot.bootblock >>>> make: *** No rule to make target `"cmc.bin"', needed by >>>> `build/coreboot.pre1'. Stop. >>>> >>>> >>>> any hints on where to place this file would be greatly >>>> appreciared. as a note, i have made a oprom directory in the >>>> coreboot root. this place hold my vgabios.bin which the coreboot >>>> build system find an links properly. >>>> >>>> >>>> thanks >>>> anish >>>> >>> i have found the problem >>> reverting back the the Makefile.inc from r6199 for the sch fixed the >>> problem. >> Which Makefile.inc. Can you please send a patch? >> >> >> -- >> coreboot mailing list: coreboot@coreboot.org >> http://www.coreboot.org/mailman/listinfo/coreboot >>
Patrick, should we run strip_quotes at the place where we actually use *-file? * Karl-Heinz Nirschl <kh.nirschl@googlemail.com> [110316 20:44]: > Hi, > i think the following patch should do the trick: > > > --- > Index: src/southbridge/intel/sch/Makefile.inc > =================================================================== > --- src/southbridge/intel/sch/Makefile.inc (Revision 6439) > +++ src/southbridge/intel/sch/Makefile.inc (Arbeitskopie) > @@ -37,6 +37,6 @@ > > # We don't ship that, but booting without it is bound to fail > cbfs-files-$(CONFIG_HAVE_CMC) += cmc.bin > -cmc.bin-file := $(CONFIG_CMC_FILE) > +cmc.bin-file := $(call strip_quotes,$(CONFIG_CMC_FILE)) > cmc.bin-type := 0xaa > cmc.bin-position := 0xfffd0000 > --- > > > best regards, > > > > > 2011/3/15 Stefan Reinauer <stefan.reinauer@coreboot.org>: > > * Anish Patel <anish.mailing.list@gmail.com> [110314 20:42]: > >> On 03/14/11 15:19, Anish Patel wrote: > >> >Hi All, > >> > I am trying to get coreboot running on my PC/104+ atom board. > >> >I think i have everything pretty much good to go, except for one > >> >problem. > >> >When i try to build, it says it can't find my cmc.bin file, which > >> >i have extracted from the factory bios and placed in many > >> >different locations inside the coreboot build tree. As well as > >> >tell coreboot the location of the cmc.bin file, yet everytime i > >> >build i get this error. > >> > > >> > > >> > GEN bootblock/ldscript.ld > >> > LINK bootblock.elf > >> > OBJCOPY coreboot.bootblock > >> >make: *** No rule to make target `"cmc.bin"', needed by > >> >`build/coreboot.pre1'. Stop. > >> > > >> > > >> >any hints on where to place this file would be greatly > >> >appreciared. as a note, i have made a oprom directory in the > >> >coreboot root. this place hold my vgabios.bin which the coreboot > >> >build system find an links properly. > >> > > >> > > >> >thanks > >> >anish > >> > > >> i have found the problem > >> reverting back the the Makefile.inc from r6199 for the sch fixed the > >> problem. > > > > Which Makefile.inc. Can you please send a patch? > > > > > > -- > > coreboot mailing list: coreboot@coreboot.org > > http://www.coreboot.org/mailman/listinfo/coreboot > > > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot >
Patch
Index: src/southbridge/intel/sch/Makefile.inc =================================================================== --- src/southbridge/intel/sch/Makefile.inc (Revision 6439) +++ src/southbridge/intel/sch/Makefile.inc (Arbeitskopie) @@ -37,6 +37,6 @@ # We don't ship that, but booting without it is bound to fail cbfs-files-$(CONFIG_HAVE_CMC) += cmc.bin -cmc.bin-file := $(CONFIG_CMC_FILE) +cmc.bin-file := $(call strip_quotes,$(CONFIG_CMC_FILE)) cmc.bin-type := 0xaa cmc.bin-position := 0xfffd0000