Patchwork Dump some more registers for Winbond W83627DHG

login
register
about
Submitter Prakash Punnoor
Date 2011-03-28 19:48:43
Message ID <201103282148.44560.prakash@punnoor.de>
Download mbox | patch
Permalink /patch/2815/
State Accepted
Headers show

Comments

Prakash Punnoor - 2011-03-28 19:48:43
Hi,

On Monday 28 March 2011 21:08:54 Prakash Punnoor wrote:
> @Marc
> 
> Please revert my patch in the meantime. Sorry for the confusion.


So, here's the patch. I did following: I checked both datasheets side by side 
and added the differences to a copy of the original values. In fact - except 
the id registers - there are no differences, only additions. But I noticed I 
missed some in my original patch...

This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT.

Signed-off-by: Prakash Punnoor <prakash@punnoor.de>
Uwe Hermann - 2011-03-29 12:03:41
On Mon, Mar 28, 2011 at 09:48:43PM +0200, Prakash Punnoor wrote:
> This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT.
> 
> Signed-off-by: Prakash Punnoor <prakash@punnoor.de>

Thanks, committed as r6468, including the revert of the last patch.

I cross-checked against the datasheets too, noticed one small change
that's needed, but that is a problem in W83627DHG too, will fix that
in a separate commit.


Uwe.
Marc Jones - 2011-03-29 14:41:37
On Tue, Mar 29, 2011 at 6:03 AM, Uwe Hermann <uwe@hermann-uwe.de> wrote:
> On Mon, Mar 28, 2011 at 09:48:43PM +0200, Prakash Punnoor wrote:
>> This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT.
>>
>> Signed-off-by: Prakash Punnoor <prakash@punnoor.de>
>
> Thanks, committed as r6468, including the revert of the last patch.
>
> I cross-checked against the datasheets too, noticed one small change
> that's needed, but that is a problem in W83627DHG too, will fix that
> in a separate commit.
>
>

Thanks Uwe.

Patch

Index: winbond.c
===================================================================
--- winbond.c	(Revision 6440)
+++ winbond.c	(Arbeitskopie)
@@ -233,6 +233,59 @@ 
 			{0x00,0x48,0x48,0x48,0x48,0x00,0x00,0x48,0x00,0x00,
 			 EOT}},
 		{EOT}}},
+	{0xb07, "W83627DHG-P/-PT", {
+		{NOLDN, NULL,
+			{0x02,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28,
+			 0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},
+			{0x00,0xb0,NANA,0xff,0x00,MISC,0x00,MISC,RSVD,0x50,
+			 0x00,0x00,RSVD,0xe2,0x21,0x00,0x00,EOT}},
+		{0x0, "Floppy",
+			{0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4,0xf5,
+			 EOT},
+			{0x01,0x03,0xf0,0x06,0x02,0x8e,0x00,0xff,0x00,0x00,
+			 EOT}},
+		{0x1, "Parallel port",
+			{0x30,0x60,0x61,0x70,0x74,0xf0,EOT},
+			{0x01,0x03,0x78,0x07,0x04,0x3f,EOT}},
+		{0x2, "COM1",
+			{0x30,0x60,0x61,0x70,0xf0,EOT},
+			{0x01,0x03,0xf8,0x04,0x00,EOT}},
+		{0x3, "COM2",
+			{0x30,0x60,0x61,0x70,0xf0,0xf1,EOT},
+			{0x01,0x02,0xf8,0x03,0x00,0x00,EOT}},
+		{0x5, "Keyboard",
+			{0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT},
+			{0x01,0x00,0x60,0x00,0x64,0x01,0x0c,0x83,EOT}},
+		{0x6, "Serial peripheral interface",
+			{0x30,0x62,0x63,EOT},
+			{0x00,0x00,0x00,EOT}},
+		{0x7, "GPIO 6",
+			{0x30,0xf4,0xf5,0xf6,0xf7,0xf8,EOT},
+			{0x00,0xff,0x00,0x00,0x00,0x00,EOT}},
+		{0x8, "WDTO#, PLED",
+			{0x30,0xf5,0xf6,0xf7,EOT},
+			{0x00,0x00,0x00,0x00,EOT}},
+		{0x9, "GPIO 2, GPIO 3, GPIO 4, GPIO 5",
+			{0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,
+			 0xe9,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,
+			 0xf9,0xfa,0xfe,EOT},
+			{0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,0x00,
+			 0x00,0xff,0x00,0x00,0x00,0xff,0x00,0x00,0x00,0x00,
+			 0x00,0x00,0x00,EOT}},
+		{0xa, "ACPI",
+			{0x30,0x70,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,
+			 0xe8,0xe9,0xf2,0xf3,0xf4,0xf6,0xf7,0xfe,EOT},
+			{0x00,0x00,0x01,0x00,0xff,0x08,0x00,RSVD,0x1c,0x00,
+			 RSVD,RSVD,0x7c,0x00,0x00,0x00,0x00,0x00,EOT}},
+		{0xb, "Hardware monitor",
+			{0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT},
+			{0x00,0x00,0x00,0x00,0x81,0x00,0x00,EOT}},
+		{0xc, "PECI, SST",
+			{0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe8,0xe9,0xea,0xec,
+			 0xee,0xef,0xf1,0xf2,0xf3,0xfe,0xff,EOT},
+			{0x00,0x48,0x48,0x48,0x48,0x00,0x00,RSVD,0x00,0x00,
+			 0x01,0x5a,0x48,0x50,0x10,0x00,0x00,EOT}},
+		{EOT}}},
 	{0xa23, "W83627UHG", {/* TODO: Not yet in sensors-detect */
 		{EOT}}},
 	{0xa51, "W83667HG", {