| Submitter | Myles Watson |
|---|---|
| Date | 2009-09-23 16:01:21 |
| Message ID | <2831fecf0909230901t6378b848h3598a05daa8372e0@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/282/ |
| State | Superseded |
| Headers | show |
Comments
Currently, because they are so simple, we don't have makefile.inc files for i2c drivers. see serengeti_cheetah: driver-y += ../../../drivers/i2c/i2cmux/i2cmux.o This is admittedly inconsistent, but it saves a lot of unnecessary makefile.inc stuff. So I don't think we need the Makefile.inc for the i2c parts. $39 for those boards is pretty attractive, do you have a link? ron
On Wed, Sep 23, 2009 at 10:56 AM, ron minnich <rminnich@gmail.com> wrote: > Currently, because they are so simple, we don't have makefile.inc > files for i2c drivers. see serengeti_cheetah: > driver-y += ../../../drivers/i2c/i2cmux/i2cmux.o > Should it be a driver? In the old config it was just an object. > This is admittedly inconsistent, but it saves a lot of unnecessary > makefile.inc stuff. > No problem. I just missed it. > $39 for those boards is pretty attractive, do you have a link? > http://www.pacificgeek.com/product.asp?id=847374 $35 if you buy 100 or more :) Thanks, Myles
On Wed, Sep 23, 2009 at 11:13:11AM -0600, Myles Watson wrote: > On Wed, Sep 23, 2009 at 10:56 AM, ron minnich <rminnich@gmail.com> wrote: > > > Currently, because they are so simple, we don't have makefile.inc > > files for i2c drivers. see serengeti_cheetah: > > driver-y += ../../../drivers/i2c/i2cmux/i2cmux.o > > > Should it be a driver? In the old config it was just an object. > > > > This is admittedly inconsistent, but it saves a lot of unnecessary > > makefile.inc stuff. > > > No problem. I just missed it. > > > > $39 for those boards is pretty attractive, do you have a link? > > > http://www.pacificgeek.com/product.asp?id=847374 Argh, can not resist. Ordered :) Good for spare parts, too - I've still got a couple of those out in the field... Thanks, Ward.
Patch
Index: svn/src/drivers/Makefile.inc =================================================================== --- svn.orig/src/drivers/Makefile.inc +++ svn/src/drivers/Makefile.inc @@ -1 +1,2 @@ subdirs-y += pci +subdirs-y += i2c Index: svn/src/drivers/i2c/Makefile.inc =================================================================== --- /dev/null +++ svn/src/drivers/i2c/Makefile.inc @@ -0,0 +1,2 @@ +subdirs-y += adm1026 +subdirs-y += adm1027 Index: svn/src/Kconfig =================================================================== --- svn.orig/src/Kconfig +++ svn/src/Kconfig @@ -31,6 +31,7 @@ source src/mainboard/Kconfig source src/arch/i386/Kconfig source src/arch/ppc/Kconfig source src/devices/Kconfig +source src/drivers/Kconfig source src/northbridge/Kconfig source src/southbridge/Kconfig source src/superio/Kconfig Index: svn/src/drivers/Kconfig =================================================================== --- /dev/null +++ svn/src/drivers/Kconfig @@ -0,0 +1 @@ +source src/drivers/i2c/Kconfig Index: svn/src/drivers/i2c/Kconfig =================================================================== --- /dev/null +++ svn/src/drivers/i2c/Kconfig @@ -0,0 +1,4 @@ +config I2C_ADM1026 + bool +config I2C_ADM1027 + bool Index: svn/src/drivers/i2c/adm1026/Makefile.inc =================================================================== --- /dev/null +++ svn/src/drivers/i2c/adm1026/Makefile.inc @@ -0,0 +1 @@ +obj-$(CONFIG_I2C_ADM1026) += adm1026.o Index: svn/src/drivers/i2c/adm1027/Makefile.inc =================================================================== --- /dev/null +++ svn/src/drivers/i2c/adm1027/Makefile.inc @@ -0,0 +1 @@ +obj-$(CONFIG_I2C_ADM1027) += adm1027.o
I realize that these boards are old. If I were new to coreboot and wanted to experiment with it, I might be looking at boards like this one. You can get them for $39 with 2 CPUs (refurbished). Build tested but not boot tested. Signed-off-by: Myles Watson <mylesgw@gmail.com> Thanks, Myles