| Submitter | Idwer Vollering |
|---|---|
| Date | 2011-04-01 18:29:39 |
| Message ID | <AANLkTikuurwp5x=_a5R2BJvGvaYneb1_g51S4hydZd6W@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/2841/ |
| State | Superseded |
| Headers | show |
Comments
* Idwer Vollering <vidwer@gmail.com> [110401 20:29]: > Signed-off-by: Idwer Vollering <vidwer@gmail.com> > > --- > > Index: src/southbridge/intel/i82371eb/Makefile.inc > =================================================================== > --- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474) > +++ src/southbridge/intel/i82371eb/Makefile.inc (working copy) > @@ -24,8 +24,10 @@ > driver-y += usb.c > driver-y += smbus.c > driver-y += reset.c > +ifeq ($(CONFIG_GENERATE_ACPI_TABLES),y) > driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c > driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c > +endif > should this just be driver-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c driver-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.c instead?
2011/4/1 Stefan Reinauer <stefan.reinauer@coreboot.org>: > * Idwer Vollering <vidwer@gmail.com> [110401 20:29]: >> Signed-off-by: Idwer Vollering <vidwer@gmail.com> >> >> --- >> >> Index: src/southbridge/intel/i82371eb/Makefile.inc >> =================================================================== >> --- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474) >> +++ src/southbridge/intel/i82371eb/Makefile.inc (working copy) >> @@ -24,8 +24,10 @@ >> driver-y += usb.c >> driver-y += smbus.c >> driver-y += reset.c >> +ifeq ($(CONFIG_GENERATE_ACPI_TABLES),y) >> driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c >> driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c >> +endif >> > > should this just be > driver-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c > driver-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.c > > instead? Ah, yes: for f in $(find -name Makefile.inc); do grep -H CONFIG_GENERATE_ACPI_TABLES $f ; done | wc -l 23 > > >
Patch
Index: src/southbridge/intel/i82371eb/Makefile.inc =================================================================== --- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474) +++ src/southbridge/intel/i82371eb/Makefile.inc (working copy) @@ -24,8 +24,10 @@ driver-y += usb.c driver-y += smbus.c driver-y += reset.c +ifeq ($(CONFIG_GENERATE_ACPI_TABLES),y) driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c +endif romstage-y += early_pm.c romstage-y += early_smbus.c
When CONFIG_GENERATE_ACPI_TABLES is not used/set, this error appears: CC southbridge/intel/i82371eb/fadt.driver.o src/southbridge/intel/i82371eb/fadt.c:35:35: error: expected ')' before '*' token make: *** [build/southbridge/intel/i82371eb/fadt.driver.o] Error 1 These boards are affected (shell command): for f in $(find src/mainboard/ -name Kconfig); do grep -Hi i82371eb $f ; done | awk -F \/ '{ print $3 "/" $4 }'| sort abit/be6-ii_v2_0 asus/p2b asus/p2b-d asus/p2b-ds asus/p2b-f asus/p2b-ls asus/p3b-f a-trend/atc-6220 a-trend/atc-6240 azza/pt-6ibd biostar/m6tba compaq/deskpro_en_sff_p600 emulation/qemu-x86 gigabyte/ga-6bxc gigabyte/ga-6bxe msi/ms6119 msi/ms6147 msi/ms6156 nokia/ip530 soyo/sy-6ba-plus-iii tyan/s1846 Signed-off-by: Idwer Vollering <vidwer@gmail.com> ---