Patchwork rs780 4GB memory issues

login
register
about
Submitter Marc Jones
Date 2011-04-01 19:37:42
Message ID <AANLkTinr6BCeNySBSk2YcwNYp8xsF=nEkdZNUWPU6sU6@mail.gmail.com>
Download mbox | patch
Permalink /patch/2842/
State Superseded
Headers show

Comments

Marc Jones - 2011-04-01 19:37:42
On Fri, Apr 1, 2011 at 12:15 PM, Marc Jones <marcj303@gmail.com> wrote:
> Use TOM2 for highest sysmem setting for northbound memory routing
> (DMA). This fixes 4GB memory issues.
>
> Signed-off-by: Marc Jones <marcj303@gmail.com>
>

Fixed the whitespace I messed up.
Stefan Reinauer - 2011-04-01 20:49:07
* Marc Jones <marcj303@gmail.com> [110401 21:37]:

> Use TOM2 for highest sysmem setting for northbound memory routing (DMA). This fixes 4GB memory issues.
> 
> Signed-off-by: Marc Jones <marcj303@gmail.com>
 
Acked-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Rudolf Marek - 2011-04-01 21:36:13
Hi,

How the patch actually works? It looks like it only prints TOM2 not using it.

Thanks,
Rudolf

Patch

Use TOM2 for highest sysmem setting for northbound memory routing (DMA). This fixes 4GB memory issues.

Signed-off-by: Marc Jones <marcj303@gmail.com>


Index: coreboot/src/southbridge/amd/rs780/gfx.c
===================================================================
--- coreboot.orig/src/southbridge/amd/rs780/gfx.c	2011-04-01 11:45:45.894571001 -0600
+++ coreboot/src/southbridge/amd/rs780/gfx.c	2011-04-01 13:33:50.706571001 -0600
@@ -661,11 +661,13 @@ 

 	printk(BIOS_DEBUG, "rs780_internal_gfx_enable dev = 0x%p, nb_dev = 0x%p.\n", dev, nb_dev);

-	sysmem = rdmsr(0xc001001a);
-	printk(BIOS_DEBUG, "sysmem = %x_%x\n", sysmem.hi, sysmem.lo);
-
 	/* The system top memory in 780. */
+	sysmem = rdmsr(0xc001001a);
+	printk(BIOS_DEBUG, "Sysmem TOM = %x_%x\n", sysmem.hi, sysmem.lo);
 	pci_write_config32(nb_dev, 0x90, sysmem.lo);
+
+	sysmem = rdmsr(0xc001001D);
+	printk(BIOS_DEBUG, "Sysmem TOM2 = %x_%x\n", sysmem.hi, sysmem.lo);
 	htiu_write_index(nb_dev, 0x30, 0);
 	htiu_write_index(nb_dev, 0x31, 0);