| Submitter | Tadas Slotkus |
|---|---|
| Date | 2011-04-03 18:49:27 |
| Message ID | <BANLkTi=YW7r4+2Ma1MiPU4zCAKviSjG6fg@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/2847/ |
| State | Rejected |
| Headers | show |
Comments
On 04/03/2011 02:49 PM, Tadas Slotkus wrote: > Hello, > > This is my first patch, so please don't throw stones to me :) > "config USB_DISK" should somehow depend on libpayload's "config USB" at > least, but I don't know how to hardcode it, so I make USB disk to be > disabled, since USB is disabled by default. It would be great if you > could suggest how to link that dependency. > Maybe instead libpayloads USB options should be enabled by default?
* Joseph Smith <joe@settoplinux.org> [110404 01:26]: > On 04/03/2011 02:49 PM, Tadas Slotkus wrote: > >Hello, > > > >This is my first patch, so please don't throw stones to me :) > >"config USB_DISK" should somehow depend on libpayload's "config USB" at > >least, but I don't know how to hardcode it, so I make USB disk to be > >disabled, since USB is disabled by default. It would be great if you > >could suggest how to link that dependency. > > > Maybe instead libpayloads USB options should be enabled by default? Yeah, that sounds like a better idea
Patch
Trivial fix. If we are using default config we don't have USB enabled in libpayload's config. Signed-off-by: Tadas Slotkus <devtadas@gmail.com> Index: Config.in =================================================================== --- Config.in (revision 143) +++ Config.in (working copy) @@ -131,9 +131,10 @@ config USB_DISK bool "USB Stack" - default y + default n help Driver for USB Storage + NOTE: USB in libpayload's config must be enabled manually config FLASH_DISK bool "NAND Flash support"