Patchwork [RFC] add EXPERIMENTAL config entry

login
register
about
Submitter Hamo
Date 2011-04-05 09:30:00
Message ID <BANLkTiknvhv8q2wXcMyMYRrzb3TdiZfs_A@mail.gmail.com>
Download mbox | patch
Permalink /patch/2852/
State Rejected
Headers show

Comments

Hamo - 2011-04-05 09:30:00
Add EXPERIMENTAL config entry so that we can make all ARM-related
entries depend on this now.
We need to make all the ARM-related code available to ALL so that we
can attract those interested in ARM to join us. During this process,
some of the code may not be usable, so we need this to ensure that
those normal users will not be upset with it.

Signed-off-by: Yang Hamo Bai <hamo.by@gmail.com>

 	bool "Expert mode"
 	help
Joseph Smith - 2011-04-05 12:18:43
On Tue, 5 Apr 2011 17:30:00 +0800, Hamo <hamo.by@gmail.com> wrote:
> Add EXPERIMENTAL config entry so that we can make all ARM-related
> entries depend on this now.
> We need to make all the ARM-related code available to ALL so that we
> can attract those interested in ARM to join us. During this process,
> some of the code may not be usable, so we need this to ensure that
> those normal users will not be upset with it.
> 
> Signed-off-by: Yang Hamo Bai <hamo.by@gmail.com>
> 
> Index: src/Kconfig
> ===================================================================
> --- src/Kconfig	(revision 6479)
> +++ src/Kconfig	(working copy)
> @@ -21,6 +21,12 @@
> 
>  menu "General setup"
> 
> +config EXPERIMENTAL
> +    bool "Prompt for developement and/or incomplete code"
> +    default n
> +    help
> +      Some of the various things that Coreboot supports can be in a
> state of development where the functionality, stability, or the level
> of testing is not yet high enough fro general use.
> +
>  config EXPERT
>  	bool "Expert mode"
>  	help
> 
> --
> coreboot mailing list: coreboot@coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot

It is nice for everyone to have access to work in progress code but I am
going to have to nak this only because config EXPERIMENTAL is way to broad
and it opens the door for everyone to submit their half backed code arm or
not. Then we end up with a tree full of unfinished code. I would consider
acking something like config WIP_ARM or EXPERIMENTAL_ARM only because I
would be really happy to see arm support. Sorry.

Patch

Index: src/Kconfig
===================================================================
--- src/Kconfig	(revision 6479)
+++ src/Kconfig	(working copy)
@@ -21,6 +21,12 @@ 

 menu "General setup"

+config EXPERIMENTAL
+    bool "Prompt for developement and/or incomplete code"
+    default n
+    help
+      Some of the various things that Coreboot supports can be in a
state of development where the functionality, stability, or the level
of testing is not yet high enough fro general use.
+
 config EXPERT