Patchwork Print what mainboard coreboot is being built for during build

login
register
about
Submitter Nickolas Lloyd
Date 2011-04-06 00:01:15
Message ID <BANLkTikoHGe+Km_A1bsyFG=374pUNdDRog@mail.gmail.com>
Download mbox | patch
Permalink /patch/2853/
State Superseded
Headers show

Comments

Nickolas Lloyd - 2011-04-06 00:01:15
From 404e7bd11e3dadf912b45057000e053db5ed7e90 Mon Sep 17 00:00:00 2001
From: Nickolas Lloyd <ntlloyd@uncg.edu>
Date: Tue, 5 Apr 2011 19:18:07 -0400
Subject: [PATCH] Print what mainboard coreboot is being built for during build

Print a message before and after build saying what mainboard coreboot
is being built for.  Only print after build if build was successful

Signed-off-by: Nickolas Lloyd <ntlloyd@uncg.edu>
---
 Makefile     |    1 +
 Makefile.inc |    4 +++-
 2 files changed, 4 insertions(+), 1 deletions(-)

 # our phony targets
--
1.7.4.1
Paul Menzel - 2011-04-06 07:57:59
Dear Nickolas,


Am Dienstag, den 05.04.2011, 20:01 -0400 schrieb Nickolas Lloyd:
> >From 404e7bd11e3dadf912b45057000e053db5ed7e90 Mon Sep 17 00:00:00 2001
> From: Nickolas Lloyd <ntlloyd@uncg.edu>
> Date: Tue, 5 Apr 2011 19:18:07 -0400
> Subject: [PATCH] Print what mainboard coreboot is being built for during build
> 
> Print a message before and after build saying what mainboard coreboot
> is being built for.  Only print after build if build was successful
> 
> Signed-off-by: Nickolas Lloyd <ntlloyd@uncg.edu>
> ---
>  Makefile     |    1 +
>  Makefile.inc |    4 +++-
>  2 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 06847b6..ddc12a6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -145,6 +145,7 @@ real-all:
>  else
>  real-all: real-target
>  endif
> +       @echo "Built coreboot for $(CONFIG_MAINBOARD_VENDOR)
> $(CONFIG_MAINBOARD_PART_NUMBER)"

it looks like, your mailer mangled the patch. Please resend
(»[PATCH][RESEND]«) with line breaks turned of in sections with code.

>  # must come rather early
>  .SECONDEXPANSION:
> diff --git a/Makefile.inc b/Makefile.inc
> index 3f553c6..74b4455 100644
> --- a/Makefile.inc
> +++ b/Makefile.inc
> @@ -31,7 +31,9 @@ export MAINBOARDDIR
>  #######################################################################
>  # root rule to resolve if in build mode (ie. configuration exists)
>  real-target: $(obj)/config.h coreboot
> -coreboot: $(obj)/coreboot.rom
> +coreboot: building-msg $(obj)/coreboot.rom
> +building-msg:
> +       @echo "Building coreboot for $(CONFIG_MAINBOARD_VENDOR)
> $(CONFIG_MAINBOARD_PART_NUMBER)"
> 
>  #######################################################################
>  # our phony targets
> --
> 1.7.4.1


Thanks,

Paul

Patch

diff --git a/Makefile b/Makefile
index 06847b6..ddc12a6 100644
--- a/Makefile
+++ b/Makefile
@@ -145,6 +145,7 @@  real-all:
 else
 real-all: real-target
 endif
+       @echo "Built coreboot for $(CONFIG_MAINBOARD_VENDOR)
$(CONFIG_MAINBOARD_PART_NUMBER)"

 # must come rather early
 .SECONDEXPANSION:
diff --git a/Makefile.inc b/Makefile.inc
index 3f553c6..74b4455 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -31,7 +31,9 @@  export MAINBOARDDIR
 #######################################################################
 # root rule to resolve if in build mode (ie. configuration exists)
 real-target: $(obj)/config.h coreboot
-coreboot: $(obj)/coreboot.rom
+coreboot: building-msg $(obj)/coreboot.rom
+building-msg:
+       @echo "Building coreboot for $(CONFIG_MAINBOARD_VENDOR)
$(CONFIG_MAINBOARD_PART_NUMBER)"

 #######################################################################