| Submitter | Hamo |
|---|---|
| Date | 2011-04-06 12:20:27 |
| Message ID | <BANLkTimTt5t816j7uxSuW=C1+L4UgRDfGw@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/2854/ |
| State | Superseded |
| Headers | show |
Comments
> P.S. Can I use git diff to generate the patch?
Why not? It isn't _that_ difficult to patch -p1 instead of -p0. :)
I've seen a few git diff patches flying around, and no one complained.
Alex
Am Mittwoch, den 06.04.2011, 20:20 +0800 schrieb Hamo: > Add WIP_ARM config entry so that we can make all ARM-related > entries depend on this now. > We need to make all the ARM-related code available to ALL so that we > can attract those interested in ARM to join us. During this process, > some of the code may not be usable, so we need this to ensure that > those normal users will not be upset with it. Would a separate branch – named for example arm-support – not be more beneficial and when everything is working merge it into trunk/master? […] Thanks, Paul > P.S. Can I use git diff to generate the patch? I guess you can even use `git format-patch`. PPS: Is this a good time to move to Git altogether? A mirror already exists. ;-) Since I am not doing any development, I am not the one to make that call.
On Wed, Apr 6, 2011 at 10:25 PM, Paul Menzel <paulepanter@users.sourceforge.net> wrote: > Am Mittwoch, den 06.04.2011, 20:20 +0800 schrieb Hamo: >> Add WIP_ARM config entry so that we can make all ARM-related >> entries depend on this now. >> We need to make all the ARM-related code available to ALL so that we >> can attract those interested in ARM to join us. During this process, >> some of the code may not be usable, so we need this to ensure that >> those normal users will not be upset with it. > > Would a separate branch – named for example arm-support – not be more > beneficial and when everything is working merge it into trunk/master? If we just create a new branch, only a few fellows can know that we are porting coreboot to ARM, but if we add a new option, all the people who try to build coreboot will know it. Through this way, we can attract more people working on or testing this. > > […] > > > Thanks, > > Paul > > >> P.S. Can I use git diff to generate the patch? > > I guess you can even use `git format-patch`. > > PPS: Is this a good time to move to Git altogether? A mirror already > exists. ;-) Since I am not doing any development, I am not the one to > make that call. +1 for move to GIT. > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot >
On 04/06/2011 05:25 PM, Paul Menzel wrote: > PPS: Is this a good time to move to Git altogether? A mirror already > exists. ;-) Since I am not doing any development, I am not the one to > make that call. > It's nice to have a git mirror, but contributors shouldn't be forced to use git, especially since subversion has been used for aeons with coreboot. Personally, I would be very unhappy to be forced to use git. -1 to gitification
On 04/06/2011 10:46 AM, Alex G. wrote: > On 04/06/2011 05:25 PM, Paul Menzel wrote: >> PPS: Is this a good time to move to Git altogether? A mirror already >> exists. ;-) Since I am not doing any development, I am not the one to >> make that call. >> > It's nice to have a git mirror, but contributors shouldn't be forced to > use git, especially since subversion has been used for aeons with > coreboot. Personally, I would be very unhappy to be forced to use git. > -1 to gitification > > Yes Alex, I prefer svn over git 10 to 1.
On Wed, Apr 6, 2011 at 6:20 AM, Hamo <hamo.by@gmail.com> wrote: > Add WIP_ARM config entry so that we can make all ARM-related > entries depend on this now. > We need to make all the ARM-related code available to ALL so that we > can attract those interested in ARM to join us. During this process, > some of the code may not be usable, so we need this to ensure that > those normal users will not be upset with it. > > Signed-off-by: Yang Bai <hamo.by@gmail.com> > > P.S. Can I use git diff to generate the patch? > > Index: src/Kconfig > =================================================================== > --- src/Kconfig (revision 6481) > +++ src/Kconfig (working copy) > @@ -21,6 +21,16 @@ > > menu "General setup" > > +config WIP_ARM > + bool "Prompt for unfinished ARM options" > + default n > + help > + This will show you the configuration options about Coreboot ARM > + support. > + > + Warning: Since ARM porting is now working in process, the code > + for ARM may be not usable. > + > config EXPERT > bool "Expert mode" > help Hi Hamo, Thank you for the patch, but I think that it is a little early to add this to the tree. You should be able to generate a patch with git diff. You can also share your git development tree if you want to share your development prior to submitting a patch. Marc
On Wed, Apr 6, 2011 at 12:14 PM, Joseph Smith <joe@settoplinux.org> wrote: > On 04/06/2011 10:46 AM, Alex G. wrote: >> >> On 04/06/2011 05:25 PM, Paul Menzel wrote: >>> >>> PPS: Is this a good time to move to Git altogether? A mirror already >>> exists. ;-) Since I am not doing any development, I am not the one to >>> make that call. >>> >> It's nice to have a git mirror, but contributors shouldn't be forced to >> use git, especially since subversion has been used for aeons with >> coreboot. Personally, I would be very unhappy to be forced to use git. >> -1 to gitification >> >> > Yes Alex, I prefer svn over git 10 to 1. > > > -- > Thanks, > Joseph Smith > Set-Top-Linux > www.settoplinux.org > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot > Hello! Even though for some silly reason SVN, and the related #svn update command isn't working (# for prompt of hosting Linux system) on my hosting Linux system, I also prefer it over git. Every time I need to clone someones repository I practically indulge a certain deity with a thought that nothing goes wrong on its behalf. ----- Gregg C Levine gregg.drwho8@gmail.com "This signature fought the Time Wars, time and again."
* Paul Menzel <paulepanter@users.sourceforge.net> [110406 16:25]: > Am Mittwoch, den 06.04.2011, 20:20 +0800 schrieb Hamo: > > Add WIP_ARM config entry so that we can make all ARM-related > > entries depend on this now. > > We need to make all the ARM-related code available to ALL so that we > > can attract those interested in ARM to join us. During this process, > > some of the code may not be usable, so we need this to ensure that > > those normal users will not be upset with it. > > Would a separate branch – named for example arm-support – not be more > beneficial and when everything is working merge it into trunk/master? Yes! Also, Hamo, please don't start an ARM port by just adding WIP_ARM. It would be nice to see something more substantial than an unused config option. ;)
* Hamo <hamo.by@gmail.com> [110406 16:33]: > On Wed, Apr 6, 2011 at 10:25 PM, Paul Menzel > <paulepanter@users.sourceforge.net> wrote: > > Am Mittwoch, den 06.04.2011, 20:20 +0800 schrieb Hamo: > >> Add WIP_ARM config entry so that we can make all ARM-related > >> entries depend on this now. > >> We need to make all the ARM-related code available to ALL so that we > >> can attract those interested in ARM to join us. During this process, > >> some of the code may not be usable, so we need this to ensure that > >> those normal users will not be upset with it. > > > > Would a separate branch – named for example arm-support – not be more > > beneficial and when everything is working merge it into trunk/master? > > If we just create a new branch, only a few fellows can know that we > are porting coreboot to ARM, > but if we add a new option, all the people who try to build coreboot > will know it. Through this way, > we can attract more people working on or testing this. We have the mailing list for letting people know.
* Gregg Levine <gregg.drwho8@gmail.com> [110406 18:17]: > On Wed, Apr 6, 2011 at 12:14 PM, Joseph Smith <joe@settoplinux.org> wrote: > > On 04/06/2011 10:46 AM, Alex G. wrote: > >> > >> On 04/06/2011 05:25 PM, Paul Menzel wrote: > >>> > >>> PPS: Is this a good time to move to Git altogether? A mirror already > >>> exists. ;-) Since I am not doing any development, I am not the one to > >>> make that call. > >>> > >> It's nice to have a git mirror, but contributors shouldn't be forced to > >> use git, especially since subversion has been used for aeons with > >> coreboot. Personally, I would be very unhappy to be forced to use git. > >> -1 to gitification > >> > >> > > Yes Alex, I prefer svn over git 10 to 1. > > > > > > -- > > Thanks, > > Joseph Smith > > Set-Top-Linux > > www.settoplinux.org > > > > -- > > coreboot mailing list: coreboot@coreboot.org > > http://www.coreboot.org/mailman/listinfo/coreboot > > > > Hello! > Even though for some silly reason SVN, and the related #svn update > command isn't working (# for prompt of hosting Linux system) on my > hosting Linux system, I also prefer it over git. > Gregg, are you behind some kind of corporate firewall? Any error messages? Stefan
On Wed, Apr 6, 2011 at 12:34 PM, Stefan Reinauer <stefan.reinauer@coreboot.org> wrote: > * Gregg Levine <gregg.drwho8@gmail.com> [110406 18:17]: >> On Wed, Apr 6, 2011 at 12:14 PM, Joseph Smith <joe@settoplinux.org> wrote: >> > On 04/06/2011 10:46 AM, Alex G. wrote: >> >> >> >> On 04/06/2011 05:25 PM, Paul Menzel wrote: >> >>> >> >>> PPS: Is this a good time to move to Git altogether? A mirror already >> >>> exists. ;-) Since I am not doing any development, I am not the one to >> >>> make that call. >> >>> >> >> It's nice to have a git mirror, but contributors shouldn't be forced to >> >> use git, especially since subversion has been used for aeons with >> >> coreboot. Personally, I would be very unhappy to be forced to use git. >> >> -1 to gitification >> >> >> >> >> > Yes Alex, I prefer svn over git 10 to 1. >> > >> > >> > -- >> > Thanks, >> > Joseph Smith >> > Set-Top-Linux >> > www.settoplinux.org >> > >> > -- >> > coreboot mailing list: coreboot@coreboot.org >> > http://www.coreboot.org/mailman/listinfo/coreboot >> > >> >> Hello! >> Even though for some silly reason SVN, and the related #svn update >> command isn't working (# for prompt of hosting Linux system) on my >> hosting Linux system, I also prefer it over git. >> > > > Gregg, are you behind some kind of corporate firewall? Any error > messages? > > Stefan > Hello! Not that I know of. Covad tells me they don't block anything except for port 25, unless the user has a good reason for wanting it unblocked. About the only error message I did see was a time out one. It seemed to spend a lot of time waiting, and waiting, and waiting, and then eventually the program would be on its back with all 32 legs in the air dead as a dodo, from timing out. ----- Gregg C Levine gregg.drwho8@gmail.com "This signature fought the Time Wars, time and again."
Thanks to all of you. Maybe I need to fork the official tree and public my tree here. I am studying the structure of Coreboot now and maybe in the next a few days, I can finish it and begin my porting. On Thu, Apr 7, 2011 at 12:43 AM, Gregg Levine <gregg.drwho8@gmail.com> wrote: > On Wed, Apr 6, 2011 at 12:34 PM, Stefan Reinauer > <stefan.reinauer@coreboot.org> wrote: >> * Gregg Levine <gregg.drwho8@gmail.com> [110406 18:17]: >>> On Wed, Apr 6, 2011 at 12:14 PM, Joseph Smith <joe@settoplinux.org> wrote: >>> > On 04/06/2011 10:46 AM, Alex G. wrote: >>> >> >>> >> On 04/06/2011 05:25 PM, Paul Menzel wrote: >>> >>> >>> >>> PPS: Is this a good time to move to Git altogether? A mirror already >>> >>> exists. ;-) Since I am not doing any development, I am not the one to >>> >>> make that call. >>> >>> >>> >> It's nice to have a git mirror, but contributors shouldn't be forced to >>> >> use git, especially since subversion has been used for aeons with >>> >> coreboot. Personally, I would be very unhappy to be forced to use git. >>> >> -1 to gitification >>> >> >>> >> >>> > Yes Alex, I prefer svn over git 10 to 1. >>> > >>> > >>> > -- >>> > Thanks, >>> > Joseph Smith >>> > Set-Top-Linux >>> > www.settoplinux.org >>> > >>> > -- >>> > coreboot mailing list: coreboot@coreboot.org >>> > http://www.coreboot.org/mailman/listinfo/coreboot >>> > >>> >>> Hello! >>> Even though for some silly reason SVN, and the related #svn update >>> command isn't working (# for prompt of hosting Linux system) on my >>> hosting Linux system, I also prefer it over git. >>> >> >> >> Gregg, are you behind some kind of corporate firewall? Any error >> messages? >> >> Stefan >> > > Hello! > Not that I know of. Covad tells me they don't block anything except > for port 25, unless the user has a good reason for wanting it > unblocked. > > About the only error message I did see was a time out one. It seemed > to spend a lot of time waiting, and waiting, and waiting, and then > eventually the program would be on its back with all 32 legs in the > air dead as a dodo, from timing out. > ----- > Gregg C Levine gregg.drwho8@gmail.com > "This signature fought the Time Wars, time and again." > > -- > coreboot mailing list: coreboot@coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot >
Patch
Index: src/Kconfig =================================================================== --- src/Kconfig (revision 6481) +++ src/Kconfig (working copy) @@ -21,6 +21,16 @@ menu "General setup" +config WIP_ARM + bool "Prompt for unfinished ARM options" + default n + help + This will show you the configuration options about Coreboot ARM + support. + + Warning: Since ARM porting is now working in process, the code + for ARM may be not usable. + config EXPERT bool "Expert mode" help
Add WIP_ARM config entry so that we can make all ARM-related entries depend on this now. We need to make all the ARM-related code available to ALL so that we can attract those interested in ARM to join us. During this process, some of the code may not be usable, so we need this to ensure that those normal users will not be upset with it. Signed-off-by: Yang Bai <hamo.by@gmail.com> P.S. Can I use git diff to generate the patch?