Patchwork [3/4] pci1x2x: use pci_ops set_subsystem instead of custom code

login
register
about
Submitter Sven Schnelle
Date 2011-04-19 19:47:17
Message ID <1303242438-13852-4-git-send-email-svens@stackframe.org>
Download mbox | patch
Permalink /patch/2891/
State Accepted
Headers show

Comments

Sven Schnelle - 2011-04-19 19:47:17
Signed-off-by: Sven Schnelle <svens@stackframe.org>
---
 src/southbridge/ti/pci1x2x/pci1x2x.c |   25 ++++++++++++++++++-------
 1 files changed, 18 insertions(+), 7 deletions(-)
Stefan Reinauer - 2011-04-20 01:35:01
* Sven Schnelle <svens@stackframe.org> [110419 21:47]:
> Signed-off-by: Sven Schnelle <svens@stackframe.org>

Will that also need a change in the nokia IP530 board's devicetree.cb?


Acked-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Sven Schnelle - 2011-04-20 09:28:24
Hi Stefan,
Stefan Reinauer <stefan.reinauer@coreboot.org> writes:

> * Sven Schnelle <svens@stackframe.org> [110419 21:47]:
>> Signed-off-by: Sven Schnelle <svens@stackframe.org>
>
> Will that also need a change in the nokia IP530 board's devicetree.cb?

Of course. Added the neccessary subsystemid statement to devicetree.cb.

Sven.

Patch

diff --git a/src/southbridge/ti/pci1x2x/pci1x2x.c b/src/southbridge/ti/pci1x2x/pci1x2x.c
index 0628f1f..a3ec35c 100644
--- a/src/southbridge/ti/pci1x2x/pci1x2x.c
+++ b/src/southbridge/ti/pci1x2x/pci1x2x.c
@@ -23,6 +23,7 @@ 
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
 #include <console/console.h>
+#include <arch/io.h>
 #include "chip.h"
 
 static void ti_pci1x2y_init(struct device *dev)
@@ -37,13 +38,6 @@  static void ti_pci1x2y_init(struct device *dev)
 	pci_write_config8(dev, 0x1B, conf->cltr);
 	/* Bridge control (offset 0x3E) */
 	pci_write_config16(dev, 0x3E, conf->bcr);
-	/*
-	 * Enable change sub-vendor ID. Clear the bit 5 to enable to write
-	 * to the sub-vendor/device ids at 40 and 42.
-	 */
-	pci_write_config32(dev, 0x80, 0x10);
-	pci_write_config32(dev, 0x40, PCI_VENDOR_ID_NOKIA);
-	/* Now write the correct value for SCR. */
 	/* System control (offset 0x80) */
 	pci_write_config32(dev, 0x80, conf->scr);
 	/* Multifunction routing */
@@ -52,12 +46,29 @@  static void ti_pci1x2y_init(struct device *dev)
 	pci_write_config8(dev, 0x92, pci_read_config8(dev, 0x92) | 0x02);
 }
 
+static void ti_pci1x2y_set_subsystem(device_t dev, unsigned vendor, unsigned device)
+{
+	/*
+	 * Enable change sub-vendor ID. Clear the bit 5 to enable to write
+	 * to the sub-vendor/device ids at 40 and 42.
+	 */
+	pci_write_config32(dev, 0x80, pci_read_config32(dev, 0x080) & ~0x10);
+	pci_write_config16(dev, 0x40, vendor);
+	pci_write_config16(dev, 0x42, device);
+	pci_write_config32(dev, 0x80, pci_read_config32(dev, 0x80) | 0x10);
+}
+
+static struct pci_operations ti_pci1x2y_pci_ops = {
+	.set_subsystem = ti_pci1x2y_set_subsystem,
+};
+
 struct device_operations southbridge_ti_pci1x2x_pciops = {
 	.read_resources   = NULL, //pci_dev_read_resources,
 	.set_resources    = pci_dev_set_resources,
 	.enable_resources = pci_dev_enable_resources,
 	.init             = ti_pci1x2y_init,
 	.scan_bus         = 0,
+	.ops_pci          = &ti_pci1x2y_pci_ops,
 };
 
 static const struct pci_driver ti_pci1225_driver __pci_driver = {