Patchwork Initialize i8259 in i82371eb southbridge code

login
register
about
Submitter Stefan Reinauer
Date 2011-04-25 20:06:40
Message ID <20110425200640.GA6337@coreboot.org>
Download mbox | patch
Permalink /patch/2915/
State Rejected
Headers show

Comments

Stefan Reinauer - 2011-04-25 20:06:40
This should allow to get rid of a hack when running u-boot as a coreboot
payload.

Stefan
Peter Stuge - 2011-04-25 22:49:53
Stefan Reinauer wrote:
> Initialize i8259 in the i82371eb southbridge (isa/lpc) code. 
> 
> All southbridges should do this, yet almost none do.
> 
> Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>

Acked-by: Peter Stuge <peter@stuge.se>

Patch

Initialize i8259 in the i82371eb southbridge (isa/lpc) code. 

All southbridges should do this, yet almost none do.

Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>


diff --git a/src/southbridge/intel/i82371eb/isa.c b/src/southbridge/intel/i82371eb/isa.c
index d025bf2..df25d25 100644
--- a/src/southbridge/intel/i82371eb/isa.c
+++ b/src/southbridge/intel/i82371eb/isa.c
@@ -23,6 +23,7 @@ 
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
+#include <pc80/i8259.h>
 #include <pc80/isa-dma.h>
 #include <pc80/mc146818rtc.h>
 #include <arch/ioapic.h>
@@ -84,6 +85,9 @@  static void isa_init(struct device *dev)
 	/* Initialize ISA DMA. */
 	isa_dma_init();
 
+	/* Initialize i8259 */
+	init_i8259();
+
 #if CONFIG_IOAPIC
 	/*
 	 * Unlike most other southbridges the 82371EB doesn't have a built-in