From patchwork Sat May 7 19:04:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Replace the values of APIC timer init with macros Date: Sat, 07 May 2011 19:04:16 -0000 From: Vikram Narayanan X-Patchwork-Id: 2954 Message-Id: <4DC597B0.4050204@gmail.com> To: coreboot@coreboot.org This replaces the fixed shift values in the apic timer init with macros. Signed-off by: Vikram Narayanan --- Thanks, Vikram --- a/src/cpu/x86/lapic/apic_timer.c Sun May 8 00:18:12 2011 +++ b/src/cpu/x86/lapic/apic_timer.c Sun May 8 00:08:54 2011 @@ -36,7 +36,7 @@ msr_t fsb_clock_sts; /* Set the apic timer to no interrupts and periodic mode */ - lapic_write(LAPIC_LVTT, (1 << 17) | (1<< 16) | (0 << 12) | (0 << 0)); + lapic_write(LAPIC_LVTT, (LAPIC_LVT_TIMER_PERIODIC | LAPIC_LVT_MASKED)); /* Set the divider to 1, no divider */ lapic_write(LAPIC_TDCR, LAPIC_TDR_DIV_1);