Patchwork Kconfig HT

login
register
about
Submitter Patrick Georgi
Date 2009-09-24 14:32:45
Message ID <1253802765.16015.7.camel@tetris>
Download mbox | patch
Permalink /patch/296/
State Accepted
Headers show

Comments

Patrick Georgi - 2009-09-24 14:32:45
Am Donnerstag, den 24.09.2009, 08:19 -0600 schrieb mylesgw:
> There's no reason for a board without HyperTransport to compile it in.
> This patch removes it (saving 1K after compression.)
> 
> I would have liked to set HYPERTRANSPORT_PLUGIN_SUPPORT the same way,
which way?
would adding "select HYPERTRANSPORT_PLUGIN_SUPPORT" to all HT aware
northbridges work for you?

or rather use HYPERTRANSPORT_PLUGIN_SUPPORT, once it's defined, but the
pattern still applies..?

> Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
Myles Watson - 2009-09-24 15:11:36
On Thu, Sep 24, 2009 at 8:32 AM, Patrick Georgi <patrick@georgi-clan.de>wrote:

> would adding "select HYPERTRANSPORT_PLUGIN_SUPPORT" to all HT aware
> northbridges work for you?
>
It did after I switched the order of the Kconfig files in src/Kconfig.  If
devices came before northbridge I couldn't get it to work.


> +ifdef CONFIG_HT_CHAIN_UNITID_BASE
> +       obj-y += hypertransport.o
> +endif
>
> maybe replace that with
> obj-$(CONFIG_HT_CHAIN_UNITID_BASE) += hypertransport.o?
> or rather use HYPERTRANSPORT_PLUGIN_SUPPORT, once it's defined, but the
> pattern still applies..?
>
Yes.  I couldn't do it with HT_CHAIN_UNITID_BASE since it wasn't boolean.


> > Signed-off-by: Myles Watson <mylesgw@gmail.com>
> Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
>
Rev. 4670.

Thanks,
Myles

Patch

--- svn.orig/src/devices/Makefile.inc
+++ svn/src/devices/Makefile.inc
@@ -2,7 +2,9 @@  obj-y += device.o
 obj-y += root_device.o
 obj-y += device_util.o
 obj-y += pci_device.o
-obj-y += hypertransport.o
+ifdef CONFIG_HT_CHAIN_UNITID_BASE
+       obj-y += hypertransport.o
+endif

maybe replace that with
obj-$(CONFIG_HT_CHAIN_UNITID_BASE) += hypertransport.o?