Patchwork Serial console driver

login
register
about
Submitter Myles Watson
Date 2009-09-25 17:08:25
Message ID <2831fecf0909251008i33f6f240o36c16df6e2189246@mail.gmail.com>
Download mbox | patch
Permalink /patch/298/
State Accepted
Headers show

Comments

Myles Watson - 2009-09-25 17:08:25
This patch changes CONFIG_SERIAL_CONSOLE to CONFIG_CONSOLE_SERIAL8250 to
match newconfig.  That makes it so that the #ifdefs in code still work.  I
think we should avoid changing names until the conversion is complete.  The
other way to do it is to change all the occurrences in all the board's
Options.lb files and in the code.

I get serial either way...

Signed-off-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles
ron minnich - 2009-09-25 17:19:08
On Fri, Sep 25, 2009 at 10:08 AM, Myles Watson <mylesgw@gmail.com> wrote:
> This patch changes CONFIG_SERIAL_CONSOLE to CONFIG_CONSOLE_SERIAL8250 to
> match newconfig.  That makes it so that the #ifdefs in code still work.  I
> think we should avoid changing names until the conversion is complete.  The
> other way to do it is to change all the occurrences in all the board's
> Options.lb files and in the code.
>
> I get serial either way...
>
> Signed-off-by: Myles Watson <mylesgw@gmail.com>

Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Myles Watson - 2009-09-25 17:24:36
On Fri, Sep 25, 2009 at 11:19 AM, ron minnich <rminnich@gmail.com> wrote:

> On Fri, Sep 25, 2009 at 10:08 AM, Myles Watson <mylesgw@gmail.com> wrote:
> > This patch changes CONFIG_SERIAL_CONSOLE to CONFIG_CONSOLE_SERIAL8250 to
> > match newconfig.  That makes it so that the #ifdefs in code still work.
> I
> > think we should avoid changing names until the conversion is complete.
> The
> > other way to do it is to change all the occurrences in all the board's
> > Options.lb files and in the code.
> >
> > I get serial either way...
> >
> > Signed-off-by: Myles Watson <mylesgw@gmail.com>
>
> Acked-by: Ronald G. Minnich <rminnich@gmail.com>
>
Rev 4672.

Thanks,
Myles

Patch

Index: svn/src/console/Makefile.inc
===================================================================
--- svn.orig/src/console/Makefile.inc
+++ svn/src/console/Makefile.inc
@@ -6,7 +6,7 @@  obj-y += vsprintf.o
 initobj-y += vtxprintf.o
 initobj-y += vsprintf.o
 
-driver-$(CONFIG_SERIAL_CONSOLE) += uart8250_console.o
+driver-$(CONFIG_CONSOLE_SERIAL8250) += uart8250_console.o
 driver-$(CONFIG_USBDEBUG_DIRECT) += usbdebug_direct_console.o
 driver-$(CONFIG_CONSOLE_VGA) += vga_console.o
 driver-$(CONFIG_CONSOLE_BTEXT) += btext_console.o
Index: svn/src/console/Kconfig
===================================================================
--- svn.orig/src/console/Kconfig
+++ svn/src/console/Kconfig
@@ -1,6 +1,7 @@ 
 menu "Console options"
 
-config SERIAL_CONSOLE
+config CONSOLE_SERIAL8250
+	#TODO Rename to SERIAL_CONSOLE once Kconfig transition is complete.
 	bool "See output on the serial port console"
 	default y
 
@@ -10,13 +11,13 @@  config SERIAL_POST
 
 config TTYS0_BASE
 	hex "I/O base for the serial port"
-	depends on SERIAL_CONSOLE
+	depends on CONSOLE_SERIAL8250
 	default 0x3f8
 
 config SERIAL_SET_SPEED
 	bool "Override the serial console BAUD rate"
 	default y
-	depends on SERIAL_CONSOLE
+	depends on CONSOLE_SERIAL8250
 
 config TTYS0_BAUD
 	int "Serial console BAUD rate"