| Submitter | Marc Jones |
|---|---|
| Date | 2011-06-03 18:44:22 |
| Message ID | <BANLkTinvLpgBJBvhnoJkziSP9qt-CTeFDw@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/3020/ |
| State | New, archived |
| Headers | show |
Comments
On Fri, Jun 03, 2011 at 12:44:22PM -0600, Marc Jones wrote: > Revert changes to set the sb800 to AHCI mode. Seabios doesn't have > this support included yet, which causes the generic Persimmon and > other CIMx sb800 platforms to not boot. > > Signed-off-by: Marc Jones <marcj303@gmail.com> Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
On Sat, Jun 4, 2011 at 7:59 AM, Jonathan A. Kollasch <jakllsch@kollasch.net> wrote: > On Fri, Jun 03, 2011 at 12:44:22PM -0600, Marc Jones wrote: >> Revert changes to set the sb800 to AHCI mode. Seabios doesn't have >> this support included yet, which causes the generic Persimmon and >> other CIMx sb800 platforms to not boot. >> >> Signed-off-by: Marc Jones <marcj303@gmail.com> > > Acked-by: Jonathan Kollasch <jakllsch@kollasch.net> > i didn't get this in before the switch to git/gerrit. Please review this patch here: http://review.coreboot.org/#change,14 Marc
Patch
Revert changes to set the sb800 to AHCI mode. Seabios doesn't have this support included yet, which causes the generic Persimmon and other CIMx sb800 platforms to not boot. Signed-off-by: Marc Jones <marcj303@gmail.com> Index: src/southbridge/amd/cimx_wrapper/sb800/cfg.c =================================================================== --- src/southbridge/amd/cimx_wrapper/sb800/cfg.c.orig 2011-06-03 11:55:38.804230868 -0600 +++ src/southbridge/amd/cimx_wrapper/sb800/cfg.c 2011-06-03 11:57:18.674230872 -0600 @@ -83,7 +83,7 @@ sb_config->SATAMODE.SataMode.SataController = SATA_CONTROLLER; sb_config->SATAMODE.SataMode.SataIdeCombMdPriSecOpt = 0; //0 -IDE as primary, 1 -IDE as secondary. //TODO: set to secondary not take effect. - sb_config->SATAMODE.SataMode.SataIdeCombinedMode = 1; //IDE controllor is hidden + sb_config->SATAMODE.SataMode.SataIdeCombinedMode = 0; //IDE controlor exposed and combined mode enabled sb_config->SATAMODE.SataMode.SATARefClkSel = SATA_CLOCK_SOURCE; /* Azalia HDA */ Index: src/southbridge/amd/cimx_wrapper/sb800/cfg.h =================================================================== --- src/southbridge/amd/cimx_wrapper/sb800/cfg.h.orig 2011-06-03 11:55:38.804230868 -0600 +++ src/southbridge/amd/cimx_wrapper/sb800/cfg.h 2011-06-03 11:59:17.014230868 -0600 @@ -109,7 +109,7 @@ * NOTE: DO NOT ALLOW SATA & IDE use same mode */ #ifndef SATA_MODE - #define SATA_MODE AHCI_MODE + #define SATA_MODE NATIVE_IDE_MODE #endif /**
Revert changes to set the sb800 to AHCI mode. Seabios doesn't have this support included yet, which causes the generic Persimmon and other CIMx sb800 platforms to not boot. Signed-off-by: Marc Jones <marcj303@gmail.com>