Patchwork New patch to review: a17084b T60: fix touchpad option

login
register
about
Submitter gerrit@coreboot.org
Date 2011-06-06 16:58:53
Message ID <E1QTd8f-0007dO-Hi@ra.coresystems.de>
Download mbox | patch
Permalink /patch/3061/
State New, archived
Headers show

Comments

gerrit@coreboot.org - 2011-06-06 16:58:53
Dear list,

Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at
http://review.coreboot.org/5.

You will also find it attached for your convenience.

Regards,
gerrit

Patch

commit a17084ba43ba15d624f689b264c3e06054b5e017
Author: Sven Schnelle <svens@stackframe.org>
Date:   Sun Jun 5 20:43:04 2011 +0200

    T60: fix touchpad option
    
    Code used 'int' as return type, but the cmos option is only one
    bit. get_option returned with the value in bit 0-7, but all remaining
    bits were left unitialized by get_option(). fix this by using char
    as type.
    
    Change-Id: I60e609164277380f936f66c99ef9508fa6a6b67c
    Signed-off-by: Sven Schnelle <svens@stackframe.org>

diff --git a/src/mainboard/lenovo/t60/mainboard.c b/src/mainboard/lenovo/t60/mainboard.c
index d6321d2..6e394bd 100644
--- a/src/mainboard/lenovo/t60/mainboard.c
+++ b/src/mainboard/lenovo/t60/mainboard.c
@@ -39,7 +39,7 @@ 
 static void mainboard_enable(device_t dev)
 {
 	device_t dev0, idedev;
-	int touchpad;
+	char touchpad;
 
 	/* enable Audio */
 	h8_set_audio_mute(0);