Patchwork New patch to review: 49493f5 T60: add volume CMOS setting

login
register
about
Submitter gerrit@coreboot.org
Date 2011-06-08 08:54:29
Message ID <E1QUEWz-0005eg-7x@ra.coresystems.de>
Download mbox | patch
Permalink /patch/3087/
State New, archived
Headers show

Comments

gerrit@coreboot.org - 2011-06-08 08:54:29
Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at
http://review.coreboot.org/12

-gerrit
Paul Menzel - 2011-06-08 11:05:04
Dear coreboot folks,


Am Mittwoch, den 08.06.2011, 10:54 +0200 schrieb gerrit@coreboot.org:
> Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at
> http://review.coreboot.org/12

opening that URL I see that Sven uploaded a second iteration. How can I
see what changed regarding to the first iteration?


Thanks,

Paul
Pat Erley - 2011-06-08 14:18:40

Paul Menzel - 2011-06-08 14:45:13
Am Mittwoch, den 08.06.2011, 10:18 -0400 schrieb pat-lkml:
> On 6/8/2011 7:05 AM, Paul Menzel wrote: 

> > Am Mittwoch, den 08.06.2011, 10:54 +0200 schrieb gerrit@coreboot.org:
> > > Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at
> > > http://review.coreboot.org/12
> > opening that URL I see that Sven uploaded a second iteration. How can I
> > see what changed regarding to the first iteration?

> Change "Old Version History" to "Patch Set 1"

Thanks, but I do not want to compare them manually but see the
differences between v1 and v2.


Thanks,

Paul
Pat Erley - 2011-06-08 14:46:42

Paul Menzel - 2011-06-08 15:10:39
Am Mittwoch, den 08.06.2011, 10:46 -0400 schrieb pat-lkml:
> On 6/8/2011 10:45 AM, Paul Menzel wrote: 
> > Am Mittwoch, den 08.06.2011, 10:18 -0400 schrieb pat-lkml:
> > > On 6/8/2011 7:05 AM, Paul Menzel wrote: 
> > > > Am Mittwoch, den 08.06.2011, 10:54 +0200 schrieb gerrit@coreboot.org:
> > > > > Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to gerrit, which you can find at
> > > > > http://review.coreboot.org/12
> > > > opening that URL I see that Sven uploaded a second iteration. How can I
> > > > see what changed regarding to the first iteration?
> > > Change "Old Version History" to "Patch Set 1"
> > Thanks, but I do not want to compare them manually but see the
> > differences between v1 and v2.

> Changing this setting changes the diffs to be incremental between
> patchsets (at least for me, changing that makes there only be 1 file
> difference, the changelog).

Thank you, I did not notice this one.


Thanks,

Paul
David Hendricks - 2011-06-09 00:04:44
On Wed, Jun 8, 2011 at 4:05 AM, Paul Menzel <
paulepanter@users.sourceforge.net> wrote:

> Dear coreboot folks,
>
>
> Am Mittwoch, den 08.06.2011, 10:54 +0200 schrieb gerrit@coreboot.org:
> > Sven Schnelle (svens@stackframe.org) just uploaded a new patch set to
> gerrit, which you can find at
> > http://review.coreboot.org/12
>
> opening that URL I see that Sven uploaded a second iteration. How can I
> see what changed regarding to the first iteration?
>

There are a couple ways, here's one:
1. Click on a file to diff (or click on "diff all" to open each file up in a
new browser tab)
2. Click the arrow next to "Patch history" in the upper left corner
3. Choose two patch sets to diff.
4. Hit the "update" button.
Peter Stuge - 2011-06-09 00:16:25
Paul Menzel wrote:
> > http://review.coreboot.org/12
> 
> opening that URL I see that Sven uploaded a second iteration.

I think I would like to get later iterations in follow-up emails..


> How can I see what changed regarding to the first iteration?

..probably incremental, as opposed to the full patch again.


//Peter
David Hendricks - 2011-06-09 02:24:39
On Wed, Jun 8, 2011 at 5:16 PM, Peter Stuge <peter@stuge.se> wrote:

> Paul Menzel wrote:
> > > http://review.coreboot.org/12
> >
> > opening that URL I see that Sven uploaded a second iteration.
>
> I think I would like to get later iterations in follow-up emails..
>

If you add yourself as a reviewer, you should get e-mails for comments and
iterations.

(Note: I haven't verified this with Coreboot's gerrit setup)
Patrick Georgi - 2011-06-09 13:16:35
On Thu, 9 Jun 2011 02:16:25 +0200, Peter Stuge wrote:
>> opening that URL I see that Sven uploaded a second iteration.
> I think I would like to get later iterations in follow-up emails..
I just disabled it yesterday because it spams the list.
As David says, if you're interested in individual topics, register as 
reviewer and you'll get updates.

>> How can I see what changed regarding to the first iteration?
> ..probably incremental, as opposed to the full patch again.
I fear that's a matter of taste.


Patrick
Uwe Hermann - 2011-06-09 16:39:36
On Wed, Jun 08, 2011 at 07:24:39PM -0700, David Hendricks wrote:
> On Wed, Jun 8, 2011 at 5:16 PM, Peter Stuge <peter@stuge.se> wrote:
> 
> > Paul Menzel wrote:
> > > > http://review.coreboot.org/12
> > >
> > > opening that URL I see that Sven uploaded a second iteration.
> >
> > I think I would like to get later iterations in follow-up emails..

Yep, me too.


> If you add yourself as a reviewer, you should get e-mails for comments and
> iterations.
> 
> (Note: I haven't verified this with Coreboot's gerrit setup)

I'd prefer to see all changes for all issues on the mailing list, I don't
think I want to go to the web interface for every new patch submission
someone does and add myself there just in order to get the notifications.


Uwe.
David Hendricks - 2011-06-09 19:51:38
On Thu, Jun 9, 2011 at 9:39 AM, Uwe Hermann <uwe@hermann-uwe.de> wrote:

> On Wed, Jun 08, 2011 at 07:24:39PM -0700, David Hendricks wrote:
> > On Wed, Jun 8, 2011 at 5:16 PM, Peter Stuge <peter@stuge.se> wrote:
> >
> > > Paul Menzel wrote:
> > > > > http://review.coreboot.org/12
> > > >
> > > > opening that URL I see that Sven uploaded a second iteration.
> > >
> > > I think I would like to get later iterations in follow-up emails..
>
> Yep, me too.
>

Maybe I was over-reacting to what seemed like a lot of "Patch set updated"
e-mails drowning out ML discussion.

Perhaps it would be wise to create another e-mail list for verbose gerrit
messages? That could satisfy the needs of the more involved developers,
without creating too much traffic on the main discussion mailing list.

I don't think I want to go to the web interface for every new patch
> submission
> someone does and add myself there just in order to get the notifications.
>

FWIW, the sender can add people to the reviewer list from the CLI when
sending the patch. For example, if you and Patrick are discussing an issue
and you whip out a patch, then it's perfectly kosher for you to upload the
patch with Patrick listed as a reviewer so he automatically gets further
updates and comments.

The gerrit FAQ linked from the coreboot page uses this as an example:
Specific reviewers can be requested and/or additional `carbon copies'' of
the notification message may be sent by including these as arguments to `git
receive-pack:
git push --receive-pack='git receive-pack --reviewer=a@a.com --cc=b@o.com'
tr:kernel/common HEAD:refs/for/experimental
Patrick Georgi - 2011-06-15 12:38:22
Am Donnerstag, den 09.06.2011, 18:39 +0200 schrieb Uwe Hermann:
> I'd prefer to see all changes for all issues on the mailing list, I don't
> think I want to go to the web interface for every new patch submission
> someone does and add myself there just in order to get the notifications.
Back again.


Patrick
David Hendricks - 2011-06-15 18:25:01
On Wed, Jun 15, 2011 at 5:38 AM, Patrick Georgi <patrick@georgi-clan.de>wrote:

> Am Donnerstag, den 09.06.2011, 18:39 +0200 schrieb Uwe Hermann:
> > I'd prefer to see all changes for all issues on the mailing list, I don't
> > think I want to go to the web interface for every new patch submission
> > someone does and add myself there just in order to get the notifications.
> Back again.
>

Is there an option to keep all these related updates and merges in a single
thread, ie do not display the patch's hash in the subject: line? Shortly
after patch update notifications to the list were re-enabled, three updates
to "i945 GMA: restore tft brightness from cmos" spawned three different
threads within the span of 10 minutes. It has the same effect on my gmail
inbox as it does on the mailing list archive.

Patch

commit 49493f5ac0430f58d7666709d678d1345c6bb318
Author: Sven Schnelle <svens@stackframe.org>
Date:   Sun Jun 5 20:47:49 2011 +0200

    T60: add volume CMOS setting
    
    Change-Id: I5332c8fa52556db34dfb5e772bf544f0323e823d
    Signed-off-by: Sven Schnelle <svens@stackframe.org>

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index e2e5f99..ef308b1 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -25,6 +25,7 @@ 
 #include <stdlib.h>
 #include "h8.h"
 #include "chip.h"
+#include <pc80/mc146818rtc.h>
 
 void h8_trackpoint_enable(int on)
 {
@@ -95,6 +96,8 @@  int h8_ultrabay_device_present(void)
 static void h8_enable(device_t dev)
 {
 	struct ec_lenovo_h8_config *conf = dev->chip_info;
+	u8 val;
+
 	h8_log_ec_version();
 
 	ec_write(H8_CONFIG0, conf->config0);
@@ -127,6 +130,8 @@  static void h8_enable(device_t dev)
 	h8_wlan_enable(conf->wlan_enable);
 	h8_trackpoint_enable(conf->trackpoint_enable);
 
+	if (!get_option(&val, "volume"))
+		ec_write(H8_VOLUME_CONTROL, val);
 }
 
 struct chip_operations ec_lenovo_h8_ops = {
diff --git a/src/ec/lenovo/h8/h8.h b/src/ec/lenovo/h8/h8.h
index b5d8f01..c87ace4 100644
--- a/src/ec/lenovo/h8/h8.h
+++ b/src/ec/lenovo/h8/h8.h
@@ -70,6 +70,9 @@  int h8_ultrabay_device_present(void);
 
 #define H8_FAN_CONTROL			0x2f
 #define H8_FAN_CONTROL_AUTO		0x80
+
+#define H8_VOLUME_CONTROL		0x30
+#define H8_VOLUME_CONTROL_MUTE		0x40
 /* Embedded controller events */
 #define H8_EVENT_FN_F1	0x10
 #define H8_EVENT_FN_F2	0x11
diff --git a/src/mainboard/lenovo/t60/cmos.layout b/src/mainboard/lenovo/t60/cmos.layout
index 3144c1e..a946b4b 100644
--- a/src/mainboard/lenovo/t60/cmos.layout
+++ b/src/mainboard/lenovo/t60/cmos.layout
@@ -108,6 +108,7 @@  entries
 1052         4       r       0        C1DRT1
 
 1060         1       e       1        touchpad
+1064         8       h       0        volume
 # -----------------------------------------------------------------
 
 enumerations
diff --git a/src/mainboard/lenovo/x60/cmos.layout b/src/mainboard/lenovo/x60/cmos.layout
index c879078..1875e59 100644
--- a/src/mainboard/lenovo/x60/cmos.layout
+++ b/src/mainboard/lenovo/x60/cmos.layout
@@ -107,6 +107,7 @@  entries
 1048         4       r       0        C0DRT1
 1052         4       r       0        C1DRT1
 
+1064         8       h       0        volume
 # -----------------------------------------------------------------
 
 enumerations