Patchwork New patch to review: 54a2294 superiotool: Cosmetics and coding style fixes.

login
register
about
Submitter gerrit@coreboot.org
Date 2011-06-09 18:58:03
Message ID <E1QUkQd-0001sC-JY@ra.coresystems.de>
Download mbox | patch
Permalink /patch/3094/
State New, archived
Headers show

Comments

gerrit@coreboot.org - 2011-06-09 18:58:03
Uwe Hermann (uwe@hermann-uwe.de) just uploaded a new patch set to gerrit, which you can find at
http://review.coreboot.org/18

-gerrit

Patch

commit 54a22948eeb309c28d5b5249c9ec96bc96bd3bea
Author: Uwe Hermann <uwe@hermann-uwe.de>
Date:   Thu Jun 9 20:56:29 2011 +0200

    superiotool: Cosmetics and coding style fixes.
    
    Change-Id: Iacda2a9e37635d5cffc5004caf588ef3e5e09b5e
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c
index 0e43614..c83d788 100644
--- a/util/superiotool/ite.c
+++ b/util/superiotool/ite.c
@@ -892,37 +892,44 @@  void probe_idregs_ite(uint16_t port)
 		enter_conf_mode_ite_legacy(port, initkey_it8661f);
 		probe_idregs_ite_helper("(init=legacy/it8661f) ", port);
 		exit_conf_mode_ite(port);
-		if (chip_found_at_port) return;
+		if (chip_found_at_port)
+			return;
 
 		enter_conf_mode_ite_legacy(port, initkey_it8671f);
 		probe_idregs_ite_helper("(init=legacy/it8671f) ", port);
 		exit_conf_mode_ite(port);
-		if (chip_found_at_port) return;
+		if (chip_found_at_port)
+			return;
 	} else {
 		enter_conf_mode_ite(port);
 		probe_idregs_ite_helper("(init=standard) ", port);
 		exit_conf_mode_ite(port);
-		if (chip_found_at_port) return;
+		if (chip_found_at_port)
+			return;
 
 		enter_conf_mode_ite_it8502e(port);
 		probe_idregs_ite_helper("(init=it8502e) ", port);
 		exit_conf_mode_ite(port);
-		if (chip_found_at_port) return;
+		if (chip_found_at_port)
+			return;
 
 		enter_conf_mode_ite_it8761e(port);
 		probe_idregs_ite_helper("(init=it8761e) ", port);
 		exit_conf_mode_ite(port);
-		if (chip_found_at_port) return;
+		if (chip_found_at_port)
+			return;
 
 		enter_conf_mode_ite_it8228e(port);
 		probe_idregs_ite_helper("(init=it8228e) ", port);
 		exit_conf_mode_ite(port);
-		if (chip_found_at_port) return;
+		if (chip_found_at_port)
+			return;
 
 		enter_conf_mode_winbond_fintek_ite_8787(port);
 		probe_idregs_ite_helper("(init=0x87,0x87) ", port);
 		exit_conf_mode_winbond_fintek_ite_8787(port);
-		if (chip_found_at_port) return;
+		if (chip_found_at_port)
+			return;
 	}
 }
 
diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c
index 260f3bb..820be08 100644
--- a/util/superiotool/smsc.c
+++ b/util/superiotool/smsc.c
@@ -396,7 +396,7 @@  static const struct superio_registers reg_table[] = {
 	{0x4d, "MEC1308", {
 		{NOLDN, NULL,
 			{0x02,0x03,0x07,0x17,0x20,0x21,0x22,0x23,0x24,0x25,
-			 0x26,0x27,0X28,0X29,0X2a,0X2b,0X2c,0X2d,0X2e,0X2f,
+			 0x26,0x27,0x28,0x29,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,
 			 EOT},
 			{0x00,RSVD,0x00,RSVD,0x4d,0x00,0x00,0x00,0x04,0x04,
 			 MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,MISC,
@@ -408,7 +408,7 @@  static const struct superio_registers reg_table[] = {
 			{0x30,0x60,0x61,0x70,EOT},
 			{0x00,0x00,0x00,0x00,EOT}},
 		{0x7, "KBD",
-			{0x30,0x70,0x72,0xF0,EOT},
+			{0x30,0x70,0x72,0xf0,EOT},
 			{0x00,0x00,0x00,0x00,EOT}},
 		{0x8, "EC/ACPI",
 			{0x30,0x60,0x61,EOT},
diff --git a/util/superiotool/winbond.c b/util/superiotool/winbond.c
index d29b87f..a3c6547 100644
--- a/util/superiotool/winbond.c
+++ b/util/superiotool/winbond.c
@@ -749,22 +749,26 @@  void probe_idregs_winbond(uint16_t port)
 	enter_conf_mode_winbond_88(port);
 	probe_idregs_winbond_helper("(init=0x88) ", port);
 	exit_conf_mode_winbond_fintek_ite_8787(port);
-	if (chip_found_at_port) return;
+	if (chip_found_at_port)
+		return;
 
 	enter_conf_mode_winbond_89(port);
 	probe_idregs_winbond_helper("(init=0x89) ", port);
 	exit_conf_mode_winbond_fintek_ite_8787(port);
-	if (chip_found_at_port) return;
+	if (chip_found_at_port)
+		return;
 
 	enter_conf_mode_winbond_86(port);
 	probe_idregs_winbond_helper("(init=0x86,0x86) ", port);
 	exit_conf_mode_winbond_fintek_ite_8787(port);
-	if (chip_found_at_port) return;
+	if (chip_found_at_port)
+		return;
 
 	enter_conf_mode_winbond_fintek_ite_8787(port);
 	probe_idregs_winbond_helper("(init=0x87,0x87) ", port);
 	exit_conf_mode_winbond_fintek_ite_8787(port);
-	if (chip_found_at_port) return;
+	if (chip_found_at_port)
+		return;
 }
 
 void print_winbond_chips(void)