Patchwork Add Olimex ARM-USB-TINY as an FT2232 SPI Programmer

login
register
about
Submitter Andrew Morgan
Date 2011-06-11 22:05:46
Message ID <4DF3E6BA.2060106@ziltro.com>
Download mbox | patch
Permalink /patch/3109/
State Superseded
Headers show

Comments

Andrew Morgan - 2011-06-11 22:05:46
On 10/06/11 23:31, Pete Batard wrote:
>
>> regarding the man page patch:
>>> -can be any of
>>> +can be one of
>> how is that better (non-native speaker here...)?
>
> Non native speaker either, but I think (feel) "any of" is better 
> applied to very short lists, whereas "one of" is better applied to 
> long ones, and our list has grown long. As the matter above, just a 
> matter of individual perception.
>

As someone who is a native English speaker I would say that "one of 
<list>" implies you can select one item from <list> (only one) and "any 
of <list>" implies you can select one or more option from <list>.
I have had a brief look in 'man flashrom' and I would suggest removing 
"any of" in all places and "one of" in one place, they don't seem needed.

Best explained in a patch, so I have attached one.
Signed-off-by: Andrew Morgan <ziltro@ziltro.com>

I left “one of -h, -R, -L, -z, -E, -r, -w, -v or no operation.” because 
those options are mutually exclusive.
Stefan Tauner - 2011-06-16 11:18:04
On Sat, 11 Jun 2011 23:05:46 +0100
Andrew Morgan <ziltro@ziltro.com> wrote:

> On 10/06/11 23:31, Pete Batard wrote:
> >
> >> regarding the man page patch:
> >>> -can be any of
> >>> +can be one of
> >> how is that better (non-native speaker here...)?
> >
> > Non native speaker either, but I think (feel) "any of" is better 
> > applied to very short lists, whereas "one of" is better applied to 
> > long ones, and our list has grown long. As the matter above, just a 
> > matter of individual perception.
> >
> 
> As someone who is a native English speaker I would say that "one of 
> <list>" implies you can select one item from <list> (only one) and "any 
> of <list>" implies you can select one or more option from <list>.
> I have had a brief look in 'man flashrom' and I would suggest removing 
> "any of" in all places and "one of" in one place, they don't seem needed.
> 
> Best explained in a patch, so I have attached one.
> Signed-off-by: Andrew Morgan <ziltro@ziltro.com>
> 
> I left “one of -h, -R, -L, -z, -E, -r, -w, -v or no operation.” because 
> those options are mutually exclusive.
> 

hello andrew

i have merged your patch with another one and committed it in r1339.
please see http://patchwork.coreboot.org/patch/3133/ for details.
thanks for your input!

Patch

Index: flashrom.8
===================================================================
--- flashrom.8	(revision 1333)
+++ flashrom.8	(working copy)
@@ -313,7 +313,7 @@ 
 .B "flashrom \-p dummy:bus=[type[+type[+type]]]"
 syntax where
 .B type
-can be any of
+can be
 .BR parallel ", " lpc ", " fwh ", " spi
 in any order. If you specify bus without type, all buses will be disabled.
 If you do not specify bus, all buses will be enabled.
@@ -361,12 +361,12 @@ 
 .sp
 syntax where
 .B model
-can be one of
+can be
 .BR 2232H ", " 4232H ", " jtagkey ", " openmoko ", " arm-usb-tiny ", " \
 arm-usb-tiny-h ", " arm-usb-ocd " or " arm-usb-ocd-h
 and
 .B interface
-can be any of
+can be
 .BR A ", or " B .
 The default model is
 .B 4232H
@@ -401,7 +401,7 @@ 
 .sp
 where
 .B frequency
-can be any of
+can be
 .BR 30k ", " 125k ", " 250k ", " 1M ", " 2M ", " 2.6M ", " 4M ", " 8M
 (in Hz). The default is the maximum frequency of 8 MHz.
 .TP
@@ -417,7 +417,7 @@ 
 .sp
 where
 .B value
-can be any of
+can be
 .BR 0V ", " 1.8V ", " 2.5V ", " 3.5V
 or the equivalent in mV.
 .TP