Comments
Patch
commit 3f222f9c71578a54e057e25feb2f3f65c9f5b58f
Author: Sven Schnelle <svens@stackframe.org>
Date: Sun Jun 12 16:55:56 2011 +0200
X60/T60: fix return value of mainboard_io_trap_handler()
The handler should return 1 if it handled the request. The current
code returns 0, which causes 'Unknown function' logs.
Change-Id: Ic296819a5f8c6f1f97b7d47148182226684882a0
Signed-off-by: Sven Schnelle <svens@stackframe.org>
@@ -68,11 +68,11 @@ int mainboard_io_trap_handler(int smif)
break;
default:
- return 1;
+ return 0;
}
- /* On success, the IO Trap Handler returns 0
- * On failure, the IO Trap Handler returns a value != 0 */
- return 0;
+ /* On success, the IO Trap Handler returns 1
+ * On failure, the IO Trap Handler returns a value != 1 */
+ return 1;
}
@@ -68,10 +68,10 @@ int mainboard_io_trap_handler(int smif)
break;
default:
- return 1;
+ return 0;
}
- /* On success, the IO Trap Handler returns 0
- * On failure, the IO Trap Handler returns a value != 0 */
- return 0;
+ /* On success, the IO Trap Handler returns 1
+ * On failure, the IO Trap Handler returns a value != 1 */
+ return 1;
}