Patchwork ROMSIP missing for kbuild based build

login
register
about
Submitter Myles Watson
Date 2009-10-01 18:02:46
Message ID <2831fecf0910011102v79a51d4cq43ddf50481908720@mail.gmail.com>
Download mbox | patch
Permalink /patch/318/
State Accepted
Commit r4704
Headers show

Comments

Myles Watson - 2009-10-01 18:02:46
> I'm missing the ROMSTRAP aka ROMSIP in image generated with new kbuild method.
> Try it for M2V-MX SE. It causes random HT errors and will not boot the board
> sometimes.
Try the attached patch.

Signed-off-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles
Rudolf Marek - 2009-10-01 18:06:47
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thank you for quick response:

    LINK       coreboot
/usr/bin/ld: section .romstrap loaded at [00000000fffffff0,0000000100000043]
overlaps section .reset loaded at [00000000fffffff0,00000000ffffffff]
/usr/bin/ld: /mnt/disc3/Moje_dilna/coreboot-v2/build/coreboot: section .romstrap
vma 0xfffffff0 overlaps previous sections
collect2: ld returned 1 exit status
make: *** [/mnt/disc3/Moje_dilna/coreboot-v2/build/coreboot] Error 1

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrE77cACgkQ3J9wPJqZRNV87QCfcvGkKGznVYxKOyrgvkOysDw0
xcAAniHs85FCbS9eORyjt9HPHWuVfCB4
=iZI0
-----END PGP SIGNATURE-----
Myles Watson - 2009-10-01 18:13:34
On Thu, Oct 1, 2009 at 12:06 PM, Rudolf Marek <r.marek@assembler.cz> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Thank you for quick response:
>
>    LINK       coreboot
> /usr/bin/ld: section .romstrap loaded at [00000000fffffff0,0000000100000043]
> overlaps section .reset loaded at [00000000fffffff0,00000000ffffffff]
> /usr/bin/ld: /mnt/disc3/Moje_dilna/coreboot-v2/build/coreboot: section .romstrap
> vma 0xfffffff0 overlaps previous sections
> collect2: ld returned 1 exit status
> make: *** [/mnt/disc3/Moje_dilna/coreboot-v2/build/coreboot] Error 1

    LINK       coreboot
    OBJCOPY    coreboot.bootblock
    CC         build/lib/version.o
    AR         coreboot.a
    CC         coreboot_ram.o
    CC         coreboot_ram
    PAYLOAD    none (as specified by user)

I didn't configure the build at all.  I just ran
./util/kbuildall/kbuildall asus/m2v-mx_se.

I'll help you track it down, but it works for me.

Thanks,
Myles
Myles Watson - 2009-10-01 18:17:41
On Thu, Oct 1, 2009 at 12:13 PM, Myles Watson <mylesgw@gmail.com> wrote:
> On Thu, Oct 1, 2009 at 12:06 PM, Rudolf Marek <r.marek@assembler.cz> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Thank you for quick response:
>>
>>    LINK       coreboot
>> /usr/bin/ld: section .romstrap loaded at [00000000fffffff0,0000000100000043]
>> overlaps section .reset loaded at [00000000fffffff0,00000000ffffffff]
>> /usr/bin/ld: /mnt/disc3/Moje_dilna/coreboot-v2/build/coreboot: section .romstrap
>> vma 0xfffffff0 overlaps previous sections
>> collect2: ld returned 1 exit status
>> make: *** [/mnt/disc3/Moje_dilna/coreboot-v2/build/coreboot] Error 1
>
>    LINK       coreboot
>    OBJCOPY    coreboot.bootblock
>    CC         build/lib/version.o
>    AR         coreboot.a
>    CC         coreboot_ram.o
>    CC         coreboot_ram
>    PAYLOAD    none (as specified by user)
>
> I didn't configure the build at all.  I just ran
> ./util/kbuildall/kbuildall asus/m2v-mx_se.

It looks like a dependency problem somewhere.  I replicated it.

Try
rm -rf build
make oldconfig
make

(make clean didn't do it for me)

Thanks,
Myles
Rudolf Marek - 2009-10-01 18:19:26
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Well I did just make clean which was not enough.

Thank you now the ROMSIP is there again

Acked-by: Rudolf Marek <r.marek@assembler.cz>

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrE8q4ACgkQ3J9wPJqZRNUdSgCeMaFCz1g51ZSWVbMeDuwPtXrk
huQAoJNLcn6FRdYo4gQbYAukEsWX7YBJ
=VR9p
-----END PGP SIGNATURE-----
Myles Watson - 2009-10-01 18:24:40
> Thank you now the ROMSIP is there again
I'm glad it was an easy fix :)

> Acked-by: Rudolf Marek <r.marek@assembler.cz>

Rev 4704.

Thanks,
Myles
Peter Stuge - 2009-10-01 22:56:32
Myles Watson wrote:
> It looks like a dependency problem somewhere.  I replicated it.
> 
> Try
> rm -rf build
> make oldconfig
> make
> 
> (make clean didn't do it for me)

Rudolf Marek wrote:
> Well I did just make clean which was not enough.

What do you think this dependency problem is?


//Peter
Myles Watson - 2009-10-01 23:05:48
On Thu, Oct 1, 2009 at 4:56 PM, Peter Stuge <peter@stuge.se> wrote:
> Myles Watson wrote:
>> It looks like a dependency problem somewhere.  I replicated it.
>>
>> Try
>> rm -rf build
>> make oldconfig
>> make
>>
>> (make clean didn't do it for me)
>
> Rudolf Marek wrote:
>> Well I did just make clean which was not enough.
>
> What do you think this dependency problem is?
I think make clean doesn't remove the load script.  Most of the time
this isn't a problem, but it should probably be fixed.

Thanks,
Myles

Patch

Index: svn/src/mainboard/asus/m2v-mx_se/Makefile.inc
===================================================================
--- svn.orig/src/mainboard/asus/m2v-mx_se/Makefile.inc
+++ svn/src/mainboard/asus/m2v-mx_se/Makefile.inc
@@ -31,6 +31,7 @@  obj-$(CONFIG_HAVE_ACPI_TABLES) +=  acpi_
 initobj-y += crt0.o
 # FIXME in $(top)/Makefile
 crt0-y += ../../../../src/cpu/x86/16bit/entry16.inc
+crt0-y += ../../../../src/southbridge/via/k8t890/romstrap.inc
 crt0-y += ../../../../src/cpu/x86/32bit/entry32.inc
 crt0-y += ../../../../src/cpu/x86/16bit/reset16.inc
 crt0-y += ../../../../src/arch/i386/lib/id.inc
@@ -39,6 +40,7 @@  crt0-y += auto.inc
 
 ldscript-y += ../../../../src/arch/i386/init/ldscript_fallback_cbfs.lb
 ldscript-y += ../../../../src/cpu/x86/16bit/entry16.lds
+ldscript-y += ../../../../src/southbridge/via/k8t890/romstrap.lds
 ldscript-y += ../../../../src/cpu/x86/16bit/reset16.lds
 ldscript-y += ../../../../src/arch/i386/lib/id.lds
 ldscript-y += ../../../../src/arch/i386/lib/failover.lds