| Submitter | Andrew Morgan |
|---|---|
| Date | 2011-06-28 22:53:41 |
| Message ID | <4E0A5B75.9080008@ziltro.com> |
| Download | mbox | patch |
| Permalink | /patch/3229/ |
| State | Accepted |
| Commit | r1388 |
| Headers | show |
Comments
Am 29.06.2011 00:53 schrieb Andrew Morgan: > satamv.c requires PCI port I/O which isn't currently available on > anything other than x86/x86_64. Generate the same compiler error as > other programmers eg. rayer_spi.c, which is where I copied the code from. > > Signed-off-by: Andrew Morgan <ziltro@ziltro.com> Thanks for your patch. I added the same code to atahpt.c and merged it into this patch. Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> and committed in r1388. Regards, Carl-Daniel
On 29.6.2011 00:53, Andrew Morgan wrote: > satamv.c requires PCI port I/O which isn't currently available on anything other > than x86/x86_64. Generate the same compiler error as other programmers eg. > rayer_spi.c, which is where I copied the code from. Hi, The PowerPC usually have a memory bar similar to MMCONFIG which generates the IO cycles. So, in fact you can have IO ports access which are just memory mapped reads or writes. This is CPU/SoC dependent so I guess it is OK this way, but this all was just FYI ;) Thanks Rudolf > > Signed-off-by: Andrew Morgan <ziltro@ziltro.com> > > > > _______________________________________________ > flashrom mailing list > flashrom@flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom
Patch
Index: satamv.c =================================================================== --- satamv.c (revision 1357) +++ satamv.c (working copy) @@ -19,6 +19,7 @@ */ /* Datasheets are not public (yet?) */ +#if defined(__i386__) || defined(__x86_64__) #include <stdlib.h> #include "flash.h" @@ -182,3 +183,6 @@ { return satamv_indirect_chip_readb(addr); } +#else +#error PCI port I/O access is not supported on this architecture yet. +#endif
satamv.c requires PCI port I/O which isn't currently available on anything other than x86/x86_64. Generate the same compiler error as other programmers eg. rayer_spi.c, which is where I copied the code from. Signed-off-by: Andrew Morgan <ziltro@ziltro.com>